[PATCH] staging: qlge: Block comments use a trailing */ on a separate line

[PATCH] staging: qlge: Block comments use a trailing */ on a separate line

[Gokce Kuler]

Deleted more * for block comments rules.

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
 drivers/staging/qlge/qlge_mpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 60c08d9..31322ec 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -1178,7 +1178,7 @@ void ql_mpi_idc_work(struct work_struct *work)
 		/* Signal the resulting link up AEN
 		 * that the frame routing and mac addr
 		 * needs to be set.
-		 * */
+		 */
 		set_bit(QL_CAM_RT_SET, &qdev->flags);
 		/* Do ACK if required */
 		if (timeout) {
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: qlge: Block comments use a trailing */ on a separate line

[Julia Lawall]

On Thu, 26 Mar 2020, Gokce Kuler wrote:

> Deleted more * for block comments rules.

The subject line and the log message should be in the imperative.
Actually, your subject line is quite confusing, because it describes the
situation one wants to end up with, rather than what should be done.
Something like "Adjust end of block comment" would be fine for the subject
line.  The log message could be "Drop an unnecessary * on the last line of
a block comment to follow the Linux kernel coding conventions.  Problem
found by checkpatch.".

julia

>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/qlge/qlge_mpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
> index 60c08d9..31322ec 100644
> --- a/drivers/staging/qlge/qlge_mpi.c
> +++ b/drivers/staging/qlge/qlge_mpi.c
> @@ -1178,7 +1178,7 @@ void ql_mpi_idc_work(struct work_struct *work)
>  		/* Signal the resulting link up AEN
>  		 * that the frame routing and mac addr
>  		 * needs to be set.
> -		 * */
> +		 */
>  		set_bit(QL_CAM_RT_SET, &qdev->flags);
>  		/* Do ACK if required */
>  		if (timeout) {
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200325231055.GA29122%40siyah2.
>

Re: [Outreachy kernel] [PATCH] staging: qlge: Block comments use a trailing */ on a separate line

[Gokce Kuler]

[-- Attachment #1: Type: text/plain, Size: 1918 bytes --]

Thanks for the feedback!

Julia Lawall <julia.lawall@inria.fr>, 26 Mar 2020 Per, 10:21 tarihinde şunu
yazdı:

>
>
> On Thu, 26 Mar 2020, Gokce Kuler wrote:
>
> > Deleted more * for block comments rules.
>
> The subject line and the log message should be in the imperative.
> Actually, your subject line is quite confusing, because it describes the
> situation one wants to end up with, rather than what should be done.
> Something like "Adjust end of block comment" would be fine for the subject
> line.  The log message could be "Drop an unnecessary * on the last line of
> a block comment to follow the Linux kernel coding conventions.  Problem
> found by checkpatch.".
>
> julia
>
> >
> > Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> > ---
> >  drivers/staging/qlge/qlge_mpi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/qlge/qlge_mpi.c
> b/drivers/staging/qlge/qlge_mpi.c
> > index 60c08d9..31322ec 100644
> > --- a/drivers/staging/qlge/qlge_mpi.c
> > +++ b/drivers/staging/qlge/qlge_mpi.c
> > @@ -1178,7 +1178,7 @@ void ql_mpi_idc_work(struct work_struct *work)
> >               /* Signal the resulting link up AEN
> >                * that the frame routing and mac addr
> >                * needs to be set.
> > -              * */
> > +              */
> >               set_bit(QL_CAM_RT_SET, &qdev->flags);
> >               /* Do ACK if required */
> >               if (timeout) {
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20200325231055.GA29122%40siyah2
> .
> >
>

[-- Attachment #2: Type: text/html, Size: 2739 bytes --]