All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: pasha.tatashin@soleen.com, jmorris@namei.org, sashal@kernel.org,
	ebiederm@xmission.com, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, corbet@lwn.net,
	catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org, maz@kernel.org,
	james.morse@arm.com, vladimir.murzin@arm.com,
	matthias.bgg@gmail.com, bhsharma@redhat.com, linux-mm@kvack.org,
	mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com,
	tglx@linutronix.de, selindag@gmail.com
Subject: [PATCH v9 01/18] arm64: kexec: make dtb_mem always enabled
Date: Wed, 25 Mar 2020 23:24:03 -0400	[thread overview]
Message-ID: <20200326032420.27220-2-pasha.tatashin@soleen.com> (raw)
In-Reply-To: <20200326032420.27220-1-pasha.tatashin@soleen.com>

Currently, dtb_mem is enabled only when CONFIG_KEXEC_FILE is
enabled. This adds ugly ifdefs to c files.

Always enabled dtb_mem, when it is not used, it is NULL.
Change the dtb_mem to phys_addr_t, as it is a physical address.

Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
---
 arch/arm64/include/asm/kexec.h    | 4 ++--
 arch/arm64/kernel/machine_kexec.c | 6 +-----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h
index d24b527e8c00..61530ec3a9b1 100644
--- a/arch/arm64/include/asm/kexec.h
+++ b/arch/arm64/include/asm/kexec.h
@@ -90,18 +90,18 @@ static inline void crash_prepare_suspend(void) {}
 static inline void crash_post_resume(void) {}
 #endif
 
-#ifdef CONFIG_KEXEC_FILE
 #define ARCH_HAS_KIMAGE_ARCH
 
 struct kimage_arch {
 	void *dtb;
-	unsigned long dtb_mem;
+	phys_addr_t dtb_mem;
 	/* Core ELF header buffer */
 	void *elf_headers;
 	unsigned long elf_headers_mem;
 	unsigned long elf_headers_sz;
 };
 
+#ifdef CONFIG_KEXEC_FILE
 extern const struct kexec_file_ops kexec_image_ops;
 
 struct kimage;
diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
index 8e9c924423b4..ae1bad0156cd 100644
--- a/arch/arm64/kernel/machine_kexec.c
+++ b/arch/arm64/kernel/machine_kexec.c
@@ -203,11 +203,7 @@ void machine_kexec(struct kimage *kimage)
 	 * In kexec_file case, the kernel starts directly without purgatory.
 	 */
 	cpu_soft_restart(reboot_code_buffer_phys, kimage->head, kimage->start,
-#ifdef CONFIG_KEXEC_FILE
-						kimage->arch.dtb_mem);
-#else
-						0);
-#endif
+			 kimage->arch.dtb_mem);
 
 	BUG(); /* Should never get here. */
 }
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: pasha.tatashin@soleen.com, jmorris@namei.org, sashal@kernel.org,
	ebiederm@xmission.com, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, corbet@lwn.net,
	catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org, maz@kernel.org,
	james.morse@arm.com, vladimir.murzin@arm.com,
	matthias.bgg@gmail.com, bhsharma@redhat.com, linux-mm@kvack.org,
	mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com,
	tglx@linutronix.de, selindag@gmail.com
Subject: [PATCH v9 01/18] arm64: kexec: make dtb_mem always enabled
Date: Wed, 25 Mar 2020 23:24:03 -0400	[thread overview]
Message-ID: <20200326032420.27220-2-pasha.tatashin@soleen.com> (raw)
In-Reply-To: <20200326032420.27220-1-pasha.tatashin@soleen.com>

Currently, dtb_mem is enabled only when CONFIG_KEXEC_FILE is
enabled. This adds ugly ifdefs to c files.

Always enabled dtb_mem, when it is not used, it is NULL.
Change the dtb_mem to phys_addr_t, as it is a physical address.

Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
---
 arch/arm64/include/asm/kexec.h    | 4 ++--
 arch/arm64/kernel/machine_kexec.c | 6 +-----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h
index d24b527e8c00..61530ec3a9b1 100644
--- a/arch/arm64/include/asm/kexec.h
+++ b/arch/arm64/include/asm/kexec.h
@@ -90,18 +90,18 @@ static inline void crash_prepare_suspend(void) {}
 static inline void crash_post_resume(void) {}
 #endif
 
-#ifdef CONFIG_KEXEC_FILE
 #define ARCH_HAS_KIMAGE_ARCH
 
 struct kimage_arch {
 	void *dtb;
-	unsigned long dtb_mem;
+	phys_addr_t dtb_mem;
 	/* Core ELF header buffer */
 	void *elf_headers;
 	unsigned long elf_headers_mem;
 	unsigned long elf_headers_sz;
 };
 
+#ifdef CONFIG_KEXEC_FILE
 extern const struct kexec_file_ops kexec_image_ops;
 
 struct kimage;
diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
index 8e9c924423b4..ae1bad0156cd 100644
--- a/arch/arm64/kernel/machine_kexec.c
+++ b/arch/arm64/kernel/machine_kexec.c
@@ -203,11 +203,7 @@ void machine_kexec(struct kimage *kimage)
 	 * In kexec_file case, the kernel starts directly without purgatory.
 	 */
 	cpu_soft_restart(reboot_code_buffer_phys, kimage->head, kimage->start,
-#ifdef CONFIG_KEXEC_FILE
-						kimage->arch.dtb_mem);
-#else
-						0);
-#endif
+			 kimage->arch.dtb_mem);
 
 	BUG(); /* Should never get here. */
 }
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-03-26  3:24 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26  3:24 [PATCH v9 00/18] arm64: MMU enabled kexec relocation Pavel Tatashin
2020-03-26  3:24 ` Pavel Tatashin
2020-03-26  3:24 ` Pavel Tatashin [this message]
2020-03-26  3:24   ` [PATCH v9 01/18] arm64: kexec: make dtb_mem always enabled Pavel Tatashin
2020-04-29 17:00   ` James Morse
2020-04-29 17:00     ` James Morse
2020-04-29 17:00     ` James Morse
2021-01-23  0:17     ` Pavel Tatashin
2021-01-23  0:17       ` Pavel Tatashin
2021-01-23  0:17       ` Pavel Tatashin
2021-01-23  0:17       ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 02/18] arm64: hibernate: move page handling function to new trans_pgd.c Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-04-29 17:00   ` James Morse
2020-04-29 17:00     ` James Morse
2020-04-29 17:00     ` James Morse
2021-01-23  0:18     ` Pavel Tatashin
2021-01-23  0:18       ` Pavel Tatashin
2021-01-23  0:18       ` Pavel Tatashin
2021-01-23  0:18       ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 03/18] arm64: trans_pgd: make trans_pgd_map_page generic Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-04-29 17:01   ` James Morse
2020-04-29 17:01     ` James Morse
2020-04-29 17:01     ` James Morse
2021-01-22 21:52     ` Pavel Tatashin
2021-01-22 21:52       ` Pavel Tatashin
2021-01-22 21:52       ` Pavel Tatashin
2021-01-22 21:52       ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 04/18] arm64: trans_pgd: pass allocator trans_pgd_create_copy Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-04-29 17:01   ` James Morse
2020-04-29 17:01     ` James Morse
2020-04-29 17:01     ` James Morse
2021-01-23  0:20     ` Pavel Tatashin
2021-01-23  0:20       ` Pavel Tatashin
2021-01-23  0:20       ` Pavel Tatashin
2021-01-23  0:20       ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 05/18] arm64: trans_pgd: pass NULL instead of init_mm to *_populate functions Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-04-29 17:01   ` James Morse
2020-04-29 17:01     ` James Morse
2020-04-29 17:01     ` James Morse
2021-01-23  0:22     ` Pavel Tatashin
2021-01-23  0:22       ` Pavel Tatashin
2021-01-23  0:22       ` Pavel Tatashin
2021-01-23  0:22       ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 06/18] arm64: mm: Always update TCR_EL1 from __cpu_set_tcr_t0sz() Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 07/18] arm64: trans_pgd: hibernate: idmap the single page that holds the copy page routines Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-04-29 17:01   ` James Morse
2020-04-29 17:01     ` James Morse
2020-04-29 17:01     ` James Morse
2021-01-23  0:35     ` Pavel Tatashin
2021-01-23  0:35       ` Pavel Tatashin
2021-01-23  0:35       ` Pavel Tatashin
2021-01-23  0:35       ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 08/18] arm64: kexec: move relocation function setup Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-04-29 17:01   ` James Morse
2020-04-29 17:01     ` James Morse
2020-04-29 17:01     ` James Morse
2021-01-23  1:01     ` Pavel Tatashin
2021-01-23  1:01       ` Pavel Tatashin
2021-01-23  1:01       ` Pavel Tatashin
2021-01-23  1:01       ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 09/18] arm64: kexec: call kexec_image_info only once Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-04-29 17:01   ` James Morse
2020-04-29 17:01     ` James Morse
2020-04-29 17:01     ` James Morse
2020-03-26  3:24 ` [PATCH v9 10/18] arm64: kexec: cpu_soft_restart change argument types Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-04-29 17:01   ` James Morse
2020-04-29 17:01     ` James Morse
2020-04-29 17:01     ` James Morse
2021-01-23  1:14     ` Pavel Tatashin
2021-01-23  1:14       ` Pavel Tatashin
2021-01-23  1:14       ` Pavel Tatashin
2021-01-23  1:14       ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 11/18] arm64: kexec: arm64_relocate_new_kernel clean-ups Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-05-07 16:22   ` James Morse
2020-05-07 16:22     ` James Morse
2020-05-07 16:22     ` James Morse
2020-03-26  3:24 ` [PATCH v9 12/18] arm64: kexec: arm64_relocate_new_kernel don't use x0 as temp Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-05-07 16:22   ` James Morse
2020-05-07 16:22     ` James Morse
2020-05-07 16:22     ` James Morse
2020-03-26  3:24 ` [PATCH v9 13/18] arm64: kexec: add expandable argument to relocation function Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-05-07 16:22   ` James Morse
2020-05-07 16:22     ` James Morse
2020-05-07 16:22     ` James Morse
2021-01-23  2:49     ` Pavel Tatashin
2021-01-23  2:49       ` Pavel Tatashin
2021-01-23  2:49       ` Pavel Tatashin
2021-01-23  2:49       ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 14/18] arm64: kexec: offset for " Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-05-07 16:22   ` James Morse
2020-05-07 16:22     ` James Morse
2020-05-07 16:22     ` James Morse
2020-03-26  3:24 ` [PATCH v9 15/18] arm64: kexec: kexec EL2 vectors Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-04-29 17:35   ` Marc Zyngier
2020-04-29 17:35     ` Marc Zyngier
2020-04-29 17:35     ` Marc Zyngier
2021-01-25 19:07     ` Pavel Tatashin
2021-01-25 19:07       ` Pavel Tatashin
2021-01-25 19:07       ` Pavel Tatashin
2021-01-25 19:07       ` Pavel Tatashin
2020-05-07 16:21   ` James Morse
2020-05-07 16:21     ` James Morse
2020-05-07 16:21     ` James Morse
2020-03-26  3:24 ` [PATCH v9 16/18] arm64: kexec: configure trans_pgd page table for kexec Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-05-07 16:22   ` James Morse
2020-05-07 16:22     ` James Morse
2020-05-07 16:22     ` James Morse
2020-03-26  3:24 ` [PATCH v9 17/18] arm64: kexec: enable MMU during kexec relocation Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin
2020-03-26  3:24 ` [PATCH v9 18/18] arm64: kexec: remove head from relocation argument Pavel Tatashin
2020-03-26  3:24   ` Pavel Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200326032420.27220-2-pasha.tatashin@soleen.com \
    --to=pasha.tatashin@soleen.com \
    --cc=bhsharma@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=ebiederm@xmission.com \
    --cc=james.morse@arm.com \
    --cc=jmorris@namei.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=maz@kernel.org \
    --cc=rfontana@redhat.com \
    --cc=sashal@kernel.org \
    --cc=selindag@gmail.com \
    --cc=steve.capper@arm.com \
    --cc=tglx@linutronix.de \
    --cc=vladimir.murzin@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.