* [Buildroot] [PATCH 1/1] package/connman: add missing libmnl dependency for nftables
@ 2020-03-08 20:53 James Hilliard
2020-03-08 21:44 ` Petr Vorel
2020-03-26 19:03 ` Yann E. MORIN
0 siblings, 2 replies; 3+ messages in thread
From: James Hilliard @ 2020-03-08 20:53 UTC (permalink / raw)
To: buildroot
Building with nftables support requires libmnl.
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/connman/Config.in | 1 +
package/connman/connman.mk | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/connman/Config.in b/package/connman/Config.in
index ac012dda54..48a2ee421c 100644
--- a/package/connman/Config.in
+++ b/package/connman/Config.in
@@ -33,6 +33,7 @@ config BR2_PACKAGE_CONNMAN_NFTABLES
bool "nftables"
depends on BR2_USE_WCHAR
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
+ select BR2_PACKAGE_LIBMNL
select BR2_PACKAGE_NFTABLES
help
Use nftables as firewall.
diff --git a/package/connman/connman.mk b/package/connman/connman.mk
index 701be8b59d..1ebfe9cf14 100644
--- a/package/connman/connman.mk
+++ b/package/connman/connman.mk
@@ -41,7 +41,7 @@ CONNMAN_CONF_OPTS += --with-firewall=iptables
CONNMAN_DEPENDENCIES += iptables
else ifeq ($(BR2_PACKAGE_CONNMAN_NFTABLES),y)
CONNMAN_CONF_OPTS += --with-firewall=nftables
-CONNMAN_DEPENDENCIES += nftables
+CONNMAN_DEPENDENCIES += libmnl nftables
endif
ifeq ($(BR2_PACKAGE_CONNMAN_LOOPBACK),y)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/connman: add missing libmnl dependency for nftables
2020-03-08 20:53 [Buildroot] [PATCH 1/1] package/connman: add missing libmnl dependency for nftables James Hilliard
@ 2020-03-08 21:44 ` Petr Vorel
2020-03-26 19:03 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2020-03-08 21:44 UTC (permalink / raw)
To: buildroot
Hi James,
> Building with nftables support requires libmnl.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Thanks for your fix!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/connman: add missing libmnl dependency for nftables
2020-03-08 20:53 [Buildroot] [PATCH 1/1] package/connman: add missing libmnl dependency for nftables James Hilliard
2020-03-08 21:44 ` Petr Vorel
@ 2020-03-26 19:03 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2020-03-26 19:03 UTC (permalink / raw)
To: buildroot
James, All,
On 2020-03-08 14:53 -0600, James Hilliard spake thusly:
> Building with nftables support requires libmnl.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Applied to master, after adding references to a few autobuild failures.
Thanks!
Regards,
Yann E. MORIN.
> ---
> package/connman/Config.in | 1 +
> package/connman/connman.mk | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/connman/Config.in b/package/connman/Config.in
> index ac012dda54..48a2ee421c 100644
> --- a/package/connman/Config.in
> +++ b/package/connman/Config.in
> @@ -33,6 +33,7 @@ config BR2_PACKAGE_CONNMAN_NFTABLES
> bool "nftables"
> depends on BR2_USE_WCHAR
> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
> + select BR2_PACKAGE_LIBMNL
> select BR2_PACKAGE_NFTABLES
> help
> Use nftables as firewall.
> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> index 701be8b59d..1ebfe9cf14 100644
> --- a/package/connman/connman.mk
> +++ b/package/connman/connman.mk
> @@ -41,7 +41,7 @@ CONNMAN_CONF_OPTS += --with-firewall=iptables
> CONNMAN_DEPENDENCIES += iptables
> else ifeq ($(BR2_PACKAGE_CONNMAN_NFTABLES),y)
> CONNMAN_CONF_OPTS += --with-firewall=nftables
> -CONNMAN_DEPENDENCIES += nftables
> +CONNMAN_DEPENDENCIES += libmnl nftables
> endif
>
> ifeq ($(BR2_PACKAGE_CONNMAN_LOOPBACK),y)
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-26 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-08 20:53 [Buildroot] [PATCH 1/1] package/connman: add missing libmnl dependency for nftables James Hilliard
2020-03-08 21:44 ` Petr Vorel
2020-03-26 19:03 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.