* [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
@ 2020-03-25 19:24 George Spelvin
2020-03-25 23:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: George Spelvin @ 2020-03-25 19:24 UTC (permalink / raw)
To: intel-gfx; +Cc: lkml, Matthew Auld
igt_mm_config() calls ilog2() on the (pseudo)random 21-bit number
s>>12. Once in 2 million seeds, this is zero and ilog2 summons
the nasal demons.
There was an attempt to handle this case with a max(), but that's
too late; ms could already be something bizarre.
Given that the low 12 bits of s and ms are always zero, it's a lot
simpler just to divide them by 4096, then everything fits into 32
bits, and we can easily generate a random number 1 <= s <= 0x1fffff.
Signed-off-by: George Spelvin <lkml@sdf.org>
Fixes: 14d1b9a6247c
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
---
drivers/gpu/drm/i915/selftests/i915_buddy.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_buddy.c b/drivers/gpu/drm/i915/selftests/i915_buddy.c
index 1b856bae67b53..b5d29dda45ddb 100644
--- a/drivers/gpu/drm/i915/selftests/i915_buddy.c
+++ b/drivers/gpu/drm/i915/selftests/i915_buddy.c
@@ -8,8 +8,6 @@
#include "../i915_selftest.h"
#include "i915_random.h"
-#define SZ_8G (1ULL << 33)
-
static void __igt_dump_block(struct i915_buddy_mm *mm,
struct i915_buddy_block *block,
bool buddy)
@@ -281,18 +279,22 @@ static int igt_check_mm(struct i915_buddy_mm *mm)
static void igt_mm_config(u64 *size, u64 *chunk_size)
{
I915_RND_STATE(prng);
- u64 s, ms;
+ u32 s, ms;
/* Nothing fancy, just try to get an interesting bit pattern */
prandom_seed_state(&prng, i915_selftest.random_seed);
- s = i915_prandom_u64_state(&prng) & (SZ_8G - 1);
- ms = BIT_ULL(12 + (prandom_u32_state(&prng) % ilog2(s >> 12)));
- s = max(s & -ms, ms);
+ /* Let size be a random number of pages up to 8 GB (2M pages) */
+ s = 1 + i915_prandom_u32_max_state((1 << (33-12)) - 1, &prng);
+ /* Let the chunk size be a random power of 2 less than size */
+ ms = (u32)1 << i915_prandom_u32_max_state(ilog2(s), &prng);
+ /* Round size down to the chunk size */
+ s &= -ms;
- *chunk_size = ms;
- *size = s;
+ /* Convert from pages to bytes */
+ *chunk_size = (u64)ms << 12;
+ *size = (u64)s << 12;
}
static int igt_buddy_alloc_smoke(void *arg)
--
2.26.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
2020-03-25 19:24 [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug George Spelvin
@ 2020-03-25 23:09 ` Patchwork
2020-03-25 23:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-03-25 23:09 UTC (permalink / raw)
To: George Spelvin; +Cc: intel-gfx
== Series Details ==
Series: drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
URL : https://patchwork.freedesktop.org/series/75090/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
11370081d24e drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
-:53: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#53: FILE: drivers/gpu/drm/i915/selftests/i915_buddy.c:289:
+ s = 1 + i915_prandom_u32_max_state((1 << (33-12)) - 1, &prng);
^
total: 0 errors, 0 warnings, 1 checks, 36 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
2020-03-25 19:24 [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug George Spelvin
2020-03-25 23:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-03-25 23:35 ` Patchwork
2020-03-26 3:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-03-25 23:35 UTC (permalink / raw)
To: George Spelvin; +Cc: intel-gfx
== Series Details ==
Series: drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
URL : https://patchwork.freedesktop.org/series/75090/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8190 -> Patchwork_17090
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/index.html
Known issues
------------
Here are the changes found in Patchwork_17090 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- {fi-tgl-u}: [DMESG-FAIL][1] ([i915#656]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/fi-tgl-u/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/fi-tgl-u/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@hangcheck:
- fi-icl-u2: [INCOMPLETE][3] ([fdo#108569]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/fi-icl-u2/igt@i915_selftest@live@hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/fi-icl-u2/igt@i915_selftest@live@hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
Participating hosts (40 -> 34)
------------------------------
Additional (7): fi-glk-dsi fi-ilk-650 fi-gdg-551 fi-elk-e7500 fi-bsw-kefka fi-blb-e6850 fi-bsw-nick
Missing (13): fi-hsw-4770r fi-bdw-samus fi-bdw-5557u fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-hsw-4770 fi-skl-lmem fi-kbl-7560u fi-byt-clapper fi-skl-6600u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8190 -> Patchwork_17090
CI-20190529: 20190529
CI_DRM_8190: 73f711b364bc85c8a7189487c09431eb1f515ed0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5538: 47becbc9cd1fc7b1b78692f90fd3dcd5a9066965 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17090: 11370081d24e95322f93cb8e80b92473ec70c674 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
11370081d24e drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
2020-03-25 19:24 [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug George Spelvin
2020-03-25 23:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-03-25 23:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-03-26 3:44 ` Patchwork
2020-03-26 17:04 ` [Intel-gfx] [PATCH] " Matthew Auld
2020-08-06 16:02 ` Chris Wilson
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-03-26 3:44 UTC (permalink / raw)
To: George Spelvin; +Cc: intel-gfx
== Series Details ==
Series: drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
URL : https://patchwork.freedesktop.org/series/75090/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8190_full -> Patchwork_17090_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17090_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17090_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17090_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@engines-mixed-process@rcs0:
- shard-kbl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl7/igt@gem_ctx_persistence@engines-mixed-process@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-kbl6/igt@gem_ctx_persistence@engines-mixed-process@rcs0.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-snb: [PASS][3] -> [TIMEOUT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-snb6/igt@i915_pm_rc6_residency@rc6-idle.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-snb4/igt@i915_pm_rc6_residency@rc6-idle.html
Known issues
------------
Here are the changes found in Patchwork_17090_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#180]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl4/igt@gem_ctx_isolation@rcs0-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110854])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@gem_exec_balancer@smoke.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb3/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@implicit-read-write-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276] / [i915#677]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@gem_exec_schedule@implicit-read-write-bsd1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb6/igt@gem_exec_schedule@implicit-read-write-bsd1.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [PASS][11] -> [SKIP][12] ([i915#677]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb3/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb4/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#112146]) +6 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb8/igt@gem_exec_schedule@preempt-bsd.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb1/igt@gem_exec_schedule@preempt-bsd.html
* igt@i915_selftest@live@execlists:
- shard-apl: [PASS][15] -> [INCOMPLETE][16] ([fdo#103927] / [i915#656])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@i915_selftest@live@execlists.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-apl7/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@requests:
- shard-iclb: [PASS][17] -> [INCOMPLETE][18] ([fdo#109644] / [fdo#110464])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb2/igt@i915_selftest@live@requests.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb5/igt@i915_selftest@live@requests.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#54] / [i915#93] / [i915#95])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#72])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#52] / [i915#54])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl3/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#79])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-glk2/igt@kms_flip@flip-vs-expired-vblank.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-glk9/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: [PASS][27] -> [FAIL][28] ([i915#79])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([i915#180]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][33] -> [FAIL][34] ([fdo#108145] / [i915#265])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_prime@basic-crc:
- shard-apl: [PASS][35] -> [FAIL][36] ([i915#1031] / [i915#95])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl4/igt@kms_prime@basic-crc.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-apl3/igt@kms_prime@basic-crc.html
- shard-kbl: [PASS][37] -> [FAIL][38] ([i915#1031] / [i915#93] / [i915#95])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl7/igt@kms_prime@basic-crc.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-kbl6/igt@kms_prime@basic-crc.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [PASS][41] -> [INCOMPLETE][42] ([i915#69])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl4/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-skl8/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@perf_pmu@init-busy-vcs1:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#112080]) +13 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@perf_pmu@init-busy-vcs1.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb6/igt@perf_pmu@init-busy-vcs1.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109276]) +29 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@prime_busy@hang-bsd2.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb7/igt@prime_busy@hang-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][47] ([fdo#110841]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][49] ([fdo#112080]) -> [PASS][50] +13 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb5/igt@gem_exec_parallel@vcs1-fds.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][51] ([i915#677]) -> [PASS][52] +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb2/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][53] ([fdo#112146]) -> [PASS][54] +4 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb5/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [SKIP][55] ([fdo#109276]) -> [PASS][56] +21 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@gem_softpin@noreloc-s3.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-apl7/igt@gem_softpin@noreloc-s3.html
* igt@gen9_exec_parse@allowed-all:
- shard-skl: [DMESG-WARN][59] ([i915#716]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl1/igt@gen9_exec_parse@allowed-all.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-skl1/igt@gen9_exec_parse@allowed-all.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [FAIL][63] ([i915#34]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl10/igt@kms_flip@plain-flip-fb-recreate.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-skl3/igt@kms_flip@plain-flip-fb-recreate.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][65] ([fdo#108145]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-glk: [FAIL][67] ([i915#899]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-y.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][69] ([i915#173]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@kms_psr@no_drrs.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb3/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb5/igt@kms_psr@psr2_cursor_render.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
#### Warnings ####
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][73] ([i915#454]) -> [SKIP][74] ([i915#468])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-tglb6/igt@i915_pm_dc@dc6-dpms.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: [FAIL][75] ([fdo#108145]) -> [FAIL][76] ([fdo#108145] / [i915#95])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [FAIL][77] ([i915#608]) -> [SKIP][78] ([fdo#109642] / [fdo#111068])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb2/igt@kms_psr2_su@page_flip.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-iclb3/igt@kms_psr2_su@page_flip.html
* igt@runner@aborted:
- shard-apl: ([FAIL][79], [FAIL][80]) ([fdo#103927] / [i915#716]) -> ([FAIL][81], [FAIL][82], [FAIL][83]) ([fdo#103927] / [i915#529] / [i915#716])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@runner@aborted.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl8/igt@runner@aborted.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-apl4/igt@runner@aborted.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-apl7/igt@runner@aborted.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shard-apl8/igt@runner@aborted.html
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109644]: https://bugs.freedesktop.org/show_bug.cgi?id=109644
[fdo#110464]: https://bugs.freedesktop.org/show_bug.cgi?id=110464
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1031]: https://gitlab.freedesktop.org/drm/intel/issues/1031
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#529]: https://gitlab.freedesktop.org/drm/intel/issues/529
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#608]: https://gitlab.freedesktop.org/drm/intel/issues/608
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8190 -> Patchwork_17090
CI-20190529: 20190529
CI_DRM_8190: 73f711b364bc85c8a7189487c09431eb1f515ed0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5538: 47becbc9cd1fc7b1b78692f90fd3dcd5a9066965 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17090: 11370081d24e95322f93cb8e80b92473ec70c674 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
2020-03-25 19:24 [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug George Spelvin
` (2 preceding siblings ...)
2020-03-26 3:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-03-26 17:04 ` Matthew Auld
2020-03-26 20:21 ` George Spelvin
2020-08-06 16:02 ` Chris Wilson
4 siblings, 1 reply; 8+ messages in thread
From: Matthew Auld @ 2020-03-26 17:04 UTC (permalink / raw)
To: George Spelvin; +Cc: Intel Graphics Development, Matthew Auld
On Wed, 25 Mar 2020 at 21:23, George Spelvin <lkml@sdf.org> wrote:
>
> igt_mm_config() calls ilog2() on the (pseudo)random 21-bit number
> s>>12. Once in 2 million seeds, this is zero and ilog2 summons
> the nasal demons.
>
> There was an attempt to handle this case with a max(), but that's
> too late; ms could already be something bizarre.
>
> Given that the low 12 bits of s and ms are always zero, it's a lot
> simpler just to divide them by 4096, then everything fits into 32
> bits, and we can easily generate a random number 1 <= s <= 0x1fffff.
>
> Signed-off-by: George Spelvin <lkml@sdf.org>
> Fixes: 14d1b9a6247c
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
2020-03-26 17:04 ` [Intel-gfx] [PATCH] " Matthew Auld
@ 2020-03-26 20:21 ` George Spelvin
2020-03-27 10:45 ` Matthew Auld
0 siblings, 1 reply; 8+ messages in thread
From: George Spelvin @ 2020-03-26 20:21 UTC (permalink / raw)
To: Matthew Auld; +Cc: lkml, intel-gfx
On Thu, Mar 26, 2020 at 05:04:43PM +0000, Matthew Auld wrote:
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Thank you! I got some incomprehensible error emails (reproduced at
https://patchwork.freedesktop.org/series/75090/) from the patchwork
daemon, complaining about additional test failures. Obviously, I care,
but I can't tell if this is a genuine error, or just a flaky test being
sensitive to the exact random number generation algorithm.
If you understand these messages, do they look like I broke something?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
2020-03-26 20:21 ` George Spelvin
@ 2020-03-27 10:45 ` Matthew Auld
0 siblings, 0 replies; 8+ messages in thread
From: Matthew Auld @ 2020-03-27 10:45 UTC (permalink / raw)
To: George Spelvin; +Cc: Intel Graphics Development
On Thu, 26 Mar 2020 at 20:21, George Spelvin <lkml@sdf.org> wrote:
>
> On Thu, Mar 26, 2020 at 05:04:43PM +0000, Matthew Auld wrote:
> > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
> Thank you! I got some incomprehensible error emails (reproduced at
> https://patchwork.freedesktop.org/series/75090/) from the patchwork
> daemon, complaining about additional test failures. Obviously, I care,
> but I can't tell if this is a genuine error, or just a flaky test being
> sensitive to the exact random number generation algorithm.
>
> If you understand these messages, do they look like I broke something?
No, doesn't seem to be related to your change.
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17090/shards-all.html?testfilter=buddy
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug
2020-03-25 19:24 [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug George Spelvin
` (3 preceding siblings ...)
2020-03-26 17:04 ` [Intel-gfx] [PATCH] " Matthew Auld
@ 2020-08-06 16:02 ` Chris Wilson
4 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2020-08-06 16:02 UTC (permalink / raw)
To: George Spelvin, intel-gfx; +Cc: lkml, Matthew Auld
Quoting George Spelvin (2020-03-25 19:24:29)
> igt_mm_config() calls ilog2() on the (pseudo)random 21-bit number
> s>>12. Once in 2 million seeds, this is zero and ilog2 summons
> the nasal demons.
I ran into a similar bug with random returning 0 and remembered this
patch sitting around.
Pushed, and many thanks for the fix!
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-08-06 16:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 19:24 [Intel-gfx] [PATCH] drivers/gpu/drm/i915/selftests/i915_buddy.c: Fix bug George Spelvin
2020-03-25 23:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-03-25 23:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-26 3:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-26 17:04 ` [Intel-gfx] [PATCH] " Matthew Auld
2020-03-26 20:21 ` George Spelvin
2020-03-27 10:45 ` Matthew Auld
2020-08-06 16:02 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.