* [PATCH] tools/power/x86/turbostat: Always print idle in the system configuration header
@ 2020-03-26 20:36 Doug Smythies
2020-08-13 21:16 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Doug Smythies @ 2020-03-26 20:36 UTC (permalink / raw)
To: lenb; +Cc: dsmythies, linux-kernel, linux-pm
If the --quiet option is not used, turbostat prints a useful system
configuration header during startup. Inclusion of idle system configuration
information is a function of inclusion in the columns choosen to be displayed.
Always list the idle system configuration.
Signed-off-by: Doug Smythies <dsmythies@telus.net>
---
tools/power/x86/turbostat/turbostat.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 33b370865d16..834b86676d00 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -3530,9 +3530,6 @@ dump_sysfs_cstate_config(void)
int state;
char *sp;
- if (!DO_BIC(BIC_sysfs))
- return;
-
if (access("/sys/devices/system/cpu/cpuidle", R_OK)) {
fprintf(outf, "cpuidle not loaded\n");
return;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/power/x86/turbostat: Always print idle in the system configuration header
2020-03-26 20:36 [PATCH] tools/power/x86/turbostat: Always print idle in the system configuration header Doug Smythies
@ 2020-08-13 21:16 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2020-08-13 21:16 UTC (permalink / raw)
To: Doug Smythies; +Cc: Doug Smythies, Linux Kernel Mailing List, Linux PM list
Applied.
thanks!
-Len
On Thu, Mar 26, 2020 at 4:36 PM Doug Smythies <doug.smythies@gmail.com> wrote:
>
> If the --quiet option is not used, turbostat prints a useful system
> configuration header during startup. Inclusion of idle system configuration
> information is a function of inclusion in the columns choosen to be displayed.
>
> Always list the idle system configuration.
>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> ---
> tools/power/x86/turbostat/turbostat.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 33b370865d16..834b86676d00 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -3530,9 +3530,6 @@ dump_sysfs_cstate_config(void)
> int state;
> char *sp;
>
> - if (!DO_BIC(BIC_sysfs))
> - return;
> -
> if (access("/sys/devices/system/cpu/cpuidle", R_OK)) {
> fprintf(outf, "cpuidle not loaded\n");
> return;
> --
> 2.25.1
>
--
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-13 21:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 20:36 [PATCH] tools/power/x86/turbostat: Always print idle in the system configuration header Doug Smythies
2020-08-13 21:16 ` Len Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.