* [PATCH] rtc: make definitions in include/uapi/linux/rtc.h actually useful for user space
@ 2020-03-24 4:12 Eugene Syromiatnikov
2020-03-26 20:47 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Eugene Syromiatnikov @ 2020-03-24 4:12 UTC (permalink / raw)
To: linux-rtc, linux-kernel, Alexandre Belloni
Cc: Alessandro Zummo, Dmitry V. Levin
BIT() macro is not defined in UAPI headers; there is, however, similarly
defined _BITUL() macro present in include/uapi/linux/const.h; use it
instead and include <linux/const.h> and <linux/ioctl.h> in order to make
the definitions provided in the header useful.
Fixes: 3431ca4837bf ("rtc: define RTC_VL_READ values")
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
---
include/uapi/linux/rtc.h | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/include/uapi/linux/rtc.h b/include/uapi/linux/rtc.h
index 095af36..83bba58 100644
--- a/include/uapi/linux/rtc.h
+++ b/include/uapi/linux/rtc.h
@@ -12,6 +12,9 @@
#ifndef _UAPI_LINUX_RTC_H_
#define _UAPI_LINUX_RTC_H_
+#include <linux/const.h>
+#include <linux/ioctl.h>
+
/*
* The struct used to pass data via the following ioctl. Similar to the
* struct tm in <time.h>, but it needs to be here so that the kernel
@@ -92,10 +95,10 @@ struct rtc_pll_info {
#define RTC_PLL_GET _IOR('p', 0x11, struct rtc_pll_info) /* Get PLL correction */
#define RTC_PLL_SET _IOW('p', 0x12, struct rtc_pll_info) /* Set PLL correction */
-#define RTC_VL_DATA_INVALID BIT(0) /* Voltage too low, RTC data is invalid */
-#define RTC_VL_BACKUP_LOW BIT(1) /* Backup voltage is low */
-#define RTC_VL_BACKUP_EMPTY BIT(2) /* Backup empty or not present */
-#define RTC_VL_ACCURACY_LOW BIT(3) /* Voltage is low, RTC accuracy is reduced */
+#define RTC_VL_DATA_INVALID _BITUL(0) /* Voltage too low, RTC data is invalid */
+#define RTC_VL_BACKUP_LOW _BITUL(1) /* Backup voltage is low */
+#define RTC_VL_BACKUP_EMPTY _BITUL(2) /* Backup empty or not present */
+#define RTC_VL_ACCURACY_LOW _BITUL(3) /* Voltage is low, RTC accuracy is reduced */
#define RTC_VL_READ _IOR('p', 0x13, unsigned int) /* Voltage low detection */
#define RTC_VL_CLR _IO('p', 0x14) /* Clear voltage low information */
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: make definitions in include/uapi/linux/rtc.h actually useful for user space
2020-03-24 4:12 [PATCH] rtc: make definitions in include/uapi/linux/rtc.h actually useful for user space Eugene Syromiatnikov
@ 2020-03-26 20:47 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-03-26 20:47 UTC (permalink / raw)
To: Eugene Syromiatnikov
Cc: linux-rtc, linux-kernel, Alessandro Zummo, Dmitry V. Levin
On 24/03/2020 05:12:09+0100, Eugene Syromiatnikov wrote:
> BIT() macro is not defined in UAPI headers; there is, however, similarly
> defined _BITUL() macro present in include/uapi/linux/const.h; use it
> instead and include <linux/const.h> and <linux/ioctl.h> in order to make
> the definitions provided in the header useful.
>
> Fixes: 3431ca4837bf ("rtc: define RTC_VL_READ values")
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
> ---
> include/uapi/linux/rtc.h | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-26 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 4:12 [PATCH] rtc: make definitions in include/uapi/linux/rtc.h actually useful for user space Eugene Syromiatnikov
2020-03-26 20:47 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.