All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: kbuild test robot <lkp@intel.com>
Cc: Joerg Roedel <jroedel@suse.de>,
	kbuild-all@lists.01.org, kvm@vger.kernel.org,
	Robert Hu <robert.hu@intel.com>,
	Farrah Chen <farrah.chen@intel.com>,
	Danmei Wei <danmei.wei@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm:queue 276/278] arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
Date: Thu, 26 Mar 2020 18:40:21 -0700	[thread overview]
Message-ID: <20200327014021.GD28014@linux.intel.com> (raw)
In-Reply-To: <202003270843.uYmVPJ2b%lkp@intel.com>

On Fri, Mar 27, 2020 at 08:29:47AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
>    arch/x86/kvm/svm/nested.c: In function 'nested_svm_init_mmu_context':
> >> arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
>      vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);
>                                                     ^~
> 
> vim +88 arch/x86/kvm/svm/nested.c
> 
>     78	
>     79	static void nested_svm_init_mmu_context(struct kvm_vcpu *vcpu)
>     80	{
>     81		WARN_ON(mmu_is_nested(vcpu));
>     82	
>     83		vcpu->arch.mmu = &vcpu->arch.guest_mmu;
>     84		kvm_init_shadow_mmu(vcpu);
>     85		vcpu->arch.mmu->get_guest_pgd     = nested_svm_get_tdp_cr3;
>     86		vcpu->arch.mmu->get_pdptr         = nested_svm_get_tdp_pdptr;
>     87		vcpu->arch.mmu->inject_page_fault = nested_svm_inject_npf_exit;
>   > 88		vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);

Tip of the iceberg.  kvm.git/queue is totally busted, the last two commits
remove code from svm.c but don't create the new files.

  $ git-tree kvm/queue
  arch/x86/kvm/Makefile
  arch/x86/kvm/svm/svm.c
  arch/x86/kvm/svm/svm.h

  $ gwo kvm/queue
  a7740c8860d7 ("KVM: SVM: Move SEV code to separate file")

>     89		reset_shadow_zero_bits_mask(vcpu, vcpu->arch.mmu);
>     90		vcpu->arch.walk_mmu              = &vcpu->arch.nested_mmu;
>     91	}
>     92	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org



WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [kvm:queue 276/278] arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
Date: Thu, 26 Mar 2020 18:40:21 -0700	[thread overview]
Message-ID: <20200327014021.GD28014@linux.intel.com> (raw)
In-Reply-To: <202003270843.uYmVPJ2b%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

On Fri, Mar 27, 2020 at 08:29:47AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
>    arch/x86/kvm/svm/nested.c: In function 'nested_svm_init_mmu_context':
> >> arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
>      vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);
>                                                     ^~
> 
> vim +88 arch/x86/kvm/svm/nested.c
> 
>     78	
>     79	static void nested_svm_init_mmu_context(struct kvm_vcpu *vcpu)
>     80	{
>     81		WARN_ON(mmu_is_nested(vcpu));
>     82	
>     83		vcpu->arch.mmu = &vcpu->arch.guest_mmu;
>     84		kvm_init_shadow_mmu(vcpu);
>     85		vcpu->arch.mmu->get_guest_pgd     = nested_svm_get_tdp_cr3;
>     86		vcpu->arch.mmu->get_pdptr         = nested_svm_get_tdp_pdptr;
>     87		vcpu->arch.mmu->inject_page_fault = nested_svm_inject_npf_exit;
>   > 88		vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);

Tip of the iceberg.  kvm.git/queue is totally busted, the last two commits
remove code from svm.c but don't create the new files.

  $ git-tree kvm/queue
  arch/x86/kvm/Makefile
  arch/x86/kvm/svm/svm.c
  arch/x86/kvm/svm/svm.h

  $ gwo kvm/queue
  a7740c8860d7 ("KVM: SVM: Move SEV code to separate file")

>     89		reset_shadow_zero_bits_mask(vcpu, vcpu->arch.mmu);
>     90		vcpu->arch.walk_mmu              = &vcpu->arch.nested_mmu;
>     91	}
>     92	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org


  reply	other threads:[~2020-03-27  1:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  0:29 [kvm:queue 276/278] arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops') kbuild test robot
2020-03-27  0:29 ` kbuild test robot
2020-03-27  1:40 ` Sean Christopherson [this message]
2020-03-27  1:40   ` Sean Christopherson
2020-03-27  8:42   ` Paolo Bonzini
2020-03-27  8:42     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200327014021.GD28014@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=danmei.wei@intel.com \
    --cc=farrah.chen@intel.com \
    --cc=jroedel@suse.de \
    --cc=kbuild-all@lists.01.org \
    --cc=kvm@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=robert.hu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.