* [PATCH] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails
@ 2020-03-27 6:26 Mao Zhongyi
2020-03-27 11:22 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 2+ messages in thread
From: Mao Zhongyi @ 2020-03-27 6:26 UTC (permalink / raw)
To: qemu-devel; +Cc: dgilbert, Mao Zhongyi
Although 'migrate_set_downtime' has been deprecated and replaced
with 'migrate_set_parameter downtime_limit', it has not been
completely eliminated, possibly due to compatibility with older
versions. I think as long as this old parameter is running, we
should report appropriate message when something goes wrong, not
be silent.
before:
(qemu) migrate_set_downtime -1
(qemu)
after:
(qemu) migrate_set_downtime -1
Error: Parameter 'downtime_limit' expects an integer in the range of 0 to 2000 seconds
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
---
monitor/hmp-cmds.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 9b94e67879..2a900a528a 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1181,8 +1181,14 @@ void hmp_migrate_pause(Monitor *mon, const QDict *qdict)
/* Kept for backwards compatibility */
void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict)
{
+ Error *err = NULL;
+
double value = qdict_get_double(qdict, "value");
- qmp_migrate_set_downtime(value, NULL);
+ qmp_migrate_set_downtime(value, &err);
+
+ if (err) {
+ hmp_handle_error(mon, err);
+ }
}
void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails
2020-03-27 6:26 [PATCH] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails Mao Zhongyi
@ 2020-03-27 11:22 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-27 11:22 UTC (permalink / raw)
To: Mao Zhongyi; +Cc: qemu-devel
* Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote:
> Although 'migrate_set_downtime' has been deprecated and replaced
> with 'migrate_set_parameter downtime_limit', it has not been
> completely eliminated, possibly due to compatibility with older
> versions. I think as long as this old parameter is running, we
> should report appropriate message when something goes wrong, not
> be silent.
>
> before:
> (qemu) migrate_set_downtime -1
> (qemu)
>
> after:
> (qemu) migrate_set_downtime -1
> Error: Parameter 'downtime_limit' expects an integer in the range of 0 to 2000 seconds
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> monitor/hmp-cmds.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 9b94e67879..2a900a528a 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -1181,8 +1181,14 @@ void hmp_migrate_pause(Monitor *mon, const QDict *qdict)
> /* Kept for backwards compatibility */
> void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict)
> {
> + Error *err = NULL;
> +
> double value = qdict_get_double(qdict, "value");
> - qmp_migrate_set_downtime(value, NULL);
> + qmp_migrate_set_downtime(value, &err);
> +
> + if (err) {
> + hmp_handle_error(mon, err);
> + }
> }
>
> void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict)
> --
> 2.17.1
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-27 11:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-27 6:26 [PATCH] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails Mao Zhongyi
2020-03-27 11:22 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.