All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gokce Kuler <gokcekuler@gmail.com>
Cc: outreachy-kernel@googlegroups.com, teddy.wang@siliconmotion.com,
	sudipm.mukherjee@gmail.com
Subject: Re: [PATCH] staging: sm750fb: no spaces before tabs
Date: Fri, 27 Mar 2020 07:37:44 +0100	[thread overview]
Message-ID: <20200327063744.GI1601217@kroah.com> (raw)
In-Reply-To: <20200326232041.GA29979@siyah2>

On Fri, Mar 27, 2020 at 02:20:41AM +0300, Gokce Kuler wrote:
> Add a space to follow the Linux kernel coding conventions.
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/sm750fb/sm750_cursor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
> index b67c545..94e9dd8c 100644
> --- a/drivers/staging/sm750fb/sm750_cursor.c
> +++ b/drivers/staging/sm750fb/sm750_cursor.c
> @@ -117,7 +117,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop,
>  
>  				/* 2 stands for forecolor and 1 for backcolor */
>  				data |= ((opr & (0x80 >> j)) ? 2 : 1) <<
> -				       	(j * 2);
> +				       	 (j * 2);

The original is correct here, why is checkpatch complaining?

thanks,

greg k-h


      reply	other threads:[~2020-03-27  6:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 23:20 [PATCH] staging: sm750fb: no spaces before tabs Gokce Kuler
2020-03-27  6:37 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200327063744.GI1601217@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gokcekuler@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.