* [PATCH] staging: sm750fb: no spaces before tabs
@ 2020-03-26 23:20 Gokce Kuler
2020-03-27 6:37 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Gokce Kuler @ 2020-03-26 23:20 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, teddy.wang, sudipm.mukherjee
Add a space to follow the Linux kernel coding conventions.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/sm750fb/sm750_cursor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index b67c545..94e9dd8c 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -117,7 +117,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop,
/* 2 stands for forecolor and 1 for backcolor */
data |= ((opr & (0x80 >> j)) ? 2 : 1) <<
- (j * 2);
+ (j * 2);
}
}
iowrite16(data, pbuffer);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sm750fb: no spaces before tabs
2020-03-26 23:20 [PATCH] staging: sm750fb: no spaces before tabs Gokce Kuler
@ 2020-03-27 6:37 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-03-27 6:37 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, teddy.wang, sudipm.mukherjee
On Fri, Mar 27, 2020 at 02:20:41AM +0300, Gokce Kuler wrote:
> Add a space to follow the Linux kernel coding conventions.
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/sm750fb/sm750_cursor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
> index b67c545..94e9dd8c 100644
> --- a/drivers/staging/sm750fb/sm750_cursor.c
> +++ b/drivers/staging/sm750fb/sm750_cursor.c
> @@ -117,7 +117,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop,
>
> /* 2 stands for forecolor and 1 for backcolor */
> data |= ((opr & (0x80 >> j)) ? 2 : 1) <<
> - (j * 2);
> + (j * 2);
The original is correct here, why is checkpatch complaining?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-27 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 23:20 [PATCH] staging: sm750fb: no spaces before tabs Gokce Kuler
2020-03-27 6:37 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.