[igt-dev] [PATCH i-g-t v3 0/2] tests/kms_concurrent: Test maximum number of planes supported by the platform

[igt-dev] [PATCH i-g-t v3 0/2] tests/kms_concurrent: Test maximum number of planes supported by the platform

[Mika Kahola]

There was an error in

commit 0ab05a51a059 ("tests/kms_concurrent: Test for maximum number of planes")

supported planes. This patch proposes a fix to this commit by first computing
the number of planes that are within platform's bandwidth requirements, resets
the display and then executes the actual testing.

v2: Remove uninitialized variable (Stan)
v3: Fix styling for commit reference (checkpatch)
    Fix possible memory leak (Juha-Pekka)

Mika Kahola (2):
  tests/kms_concurrent: Test maximum number of planes supported by the
    platform
  tests/kms_concurrent: Plug possible memory leaks

 tests/kms_concurrent.c | 110 ++++++++++++++++++++---------------------
 1 file changed, 53 insertions(+), 57 deletions(-)

-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v3 1/2] tests/kms_concurrent: Test maximum number of planes supported by the platform

[Mika Kahola]

There was an error in

commit 0ab05a51a059 ("tests/kms_concurrent: Test for maximum number of planes")

supported planes. This patch proposes a fix to this commit by first computing
the number of planes that are within platform's bandwidth requirements, resets
the display and then executes the actual testing.

v2: Remove uninitialized variable (Stan)
v3: Fix styling for commit reference (checkpatch)

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 tests/kms_concurrent.c | 102 ++++++++++++++++++-----------------------
 1 file changed, 45 insertions(+), 57 deletions(-)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 61137139..1a7c12fc 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -195,6 +195,25 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
 	igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
 }
 
+static int test_bandwidth(data_t *data, enum pipe pipe, igt_output_t *output)
+{
+
+	int n_planes = data->display.pipes[pipe].n_planes;
+	int i;
+	int ret;
+
+	igt_pipe_refresh(&data->display, pipe, true);
+
+	for (i = 1; i <= n_planes; i++) {
+		prepare_planes(data, pipe, i, output);
+		ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC | DRM_MODE_ATOMIC_TEST_ONLY);
+		if (ret != 0)
+			break;
+	}
+
+	return i - 1;
+}
+
 static void
 test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
 				igt_output_t *output)
@@ -208,7 +227,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
 	i = 0;
 	while (i < iterations || loop_forever) {
 		prepare_planes(data, pipe, max_planes, output);
-		igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
 		i++;
 	}
 }
@@ -241,44 +260,17 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
 	return mode;
 }
 
-static int
+static void
 test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
 {
 	const drmModeModeInfo *mode_hi, *mode_lo;
 	int iterations = opt.iterations < 1 ? 1 : opt.iterations;
 	bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
-	int i, c, ret;
-	int max_planes = data->display.pipes[pipe].n_planes;
-	igt_plane_t *primary;
-	drmModeModeInfo *mode;
+	int i;
 
 	i = 0;
 	while (i < iterations || loop_forever) {
 		igt_output_set_pipe(output, pipe);
-		for (c = 0; c < max_planes; c++) {
-			igt_plane_t *plane = igt_output_get_plane(output, c);
-
-			if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-				continue;
-			primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
-			data->plane[primary->index] = primary;
-			mode = igt_output_get_mode(output);
-			igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
-						DRM_FORMAT_XRGB8888,
-						LOCAL_I915_FORMAT_MOD_X_TILED,
-						0.0f, 0.0f, 1.0f,
-						&data->fb[primary->index]);
-			igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
-			ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
-			if (ret) {
-				igt_plane_set_fb(data->plane[i], NULL);
-				igt_remove_fb(data->drm_fd, &data->fb[i]);
-				data->plane[i] = NULL;
-				break;
-			}
-		}
-		max_planes = c;
-		igt_assert_lt(0, max_planes);
 
 		mode_hi = igt_output_get_mode(output);
 		mode_lo = get_lowres_mode(data, mode_hi, output);
@@ -293,48 +285,35 @@ test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
 
 		i++;
 	}
-
-	return max_planes;
 }
 
 static void
-run_test(data_t *data, enum pipe pipe, igt_output_t *output)
+run_test(data_t *data, enum pipe pipe, int max_planes, igt_output_t *output)
 {
-	int connected_outs;
-	int n_planes = data->display.pipes[pipe].n_planes;
-	int max_planes = n_planes;
-
 	if (!opt.user_seed)
 		opt.seed = time(NULL);
 
-	connected_outs = 0;
-	for_each_valid_output_on_pipe(&data->display, pipe, output) {
-		igt_info("Testing resolution with connector %s using pipe %s with seed %d\n",
-			 igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);
-
-		test_init(data, pipe, n_planes, output);
-		max_planes = test_resolution_with_output(data, pipe, output);
-
-		igt_fork(child, 1) {
-			test_plane_position_with_output(data, pipe, max_planes, output);
-		}
+	igt_info("Testing resolution with connector %s using pipe %s with seed %d\n",
+		 igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);
 
-		test_resolution_with_output(data, pipe, output);
+	test_init(data, pipe, max_planes, output);
+	igt_fork(child, 1) {
+		test_plane_position_with_output(data, pipe, max_planes, output);
+	}
 
-		igt_waitchildren();
+	test_resolution_with_output(data, pipe, output);
 
-		test_fini(data, pipe, n_planes, output);
+	igt_waitchildren();
 
-		connected_outs++;
-	}
+	test_fini(data, pipe, max_planes, output);
 
-	igt_skip_on(connected_outs == 0);
 }
 
 static void
 run_tests_for_pipe(data_t *data, enum pipe pipe)
 {
 	igt_output_t *output;
+	int max_planes;
 
 	igt_fixture {
 		int valid_tests = 0;
@@ -348,9 +327,18 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
 		igt_require_f(valid_tests, "no valid crtc/connector combinations found\n");
 	}
 
-	igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe))
-		for_each_valid_output_on_pipe(&data->display, pipe, output)
-			run_test(data, pipe, output);
+	igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe)) {
+		for_each_valid_output_on_pipe(&data->display, pipe, output) {
+			int n_planes = data->display.pipes[pipe].n_planes;
+
+			test_init(data, pipe, n_planes, output);
+			max_planes = test_bandwidth(data, pipe, output);
+			test_fini(data, pipe, n_planes, output);
+
+			igt_display_reset(&data->display);
+			run_test(data, pipe, max_planes, output);
+		}
+	}
 }
 
 static int opt_handler(int option, int option_index, void *input)
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v3 2/2] tests/kms_concurrent: Plug possible memory leaks

[Mika Kahola]

Free dynamically allocated memory that has a potential
to leak memory.

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 tests/kms_concurrent.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 1a7c12fc..1403e990 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -193,6 +193,10 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
 				    max_planes, output);
 
 	igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
+
+	free(x);
+	free(y);
+	free(size);
 }
 
 static int test_bandwidth(data_t *data, enum pipe pipe, igt_output_t *output)
@@ -228,6 +232,10 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
 	while (i < iterations || loop_forever) {
 		prepare_planes(data, pipe, max_planes, output);
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+
+		for (int c = 0; c < max_planes; c++)
+			igt_remove_fb(data->drm_fd, &data->fb[c]);
+
 		i++;
 	}
 }
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_concurrent: Test maximum number of planes supported by the platform

[Juha-Pekka Heikkila]

Set is

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>



On 26.3.2020 15.53, Mika Kahola wrote:
> There was an error in
> 
> commit 0ab05a51a059 ("tests/kms_concurrent: Test for maximum number of planes")
> 
> supported planes. This patch proposes a fix to this commit by first computing
> the number of planes that are within platform's bandwidth requirements, resets
> the display and then executes the actual testing.
> 
> v2: Remove uninitialized variable (Stan)
> v3: Fix styling for commit reference (checkpatch)
>      Fix possible memory leak (Juha-Pekka)
> 
> Mika Kahola (2):
>    tests/kms_concurrent: Test maximum number of planes supported by the
>      platform
>    tests/kms_concurrent: Plug possible memory leaks
> 
>   tests/kms_concurrent.c | 110 ++++++++++++++++++++---------------------
>   1 file changed, 53 insertions(+), 57 deletions(-)
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

[Patchwork]

== Series Details ==

Series: tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)
URL   : https://patchwork.freedesktop.org/series/75104/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8194 -> IGTPW_4359
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/index.html

Known issues
------------

  Here are the changes found in IGTPW_4359 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@i915_selftest@live@hangcheck:
    - fi-icl-guc:         [INCOMPLETE][1] ([fdo#108569]) -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/fi-icl-guc/igt@i915_selftest@live@hangcheck.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/fi-icl-guc/igt@i915_selftest@live@hangcheck.html

  
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569


Participating hosts (43 -> 41)
------------------------------

  Additional (4): fi-kbl-soraka fi-byt-n2820 fi-bdw-5557u fi-bwr-2160 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5539 -> IGTPW_4359

  CI-20190529: 20190529
  CI_DRM_8194: 0045c2479d9746be67d0b485ef0d92e238e4f2bd @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4359: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/index.html
  IGT_5539: e7aae12e37771a8b7796ba252574eb832a5839c3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_concurrent: Plug possible memory leaks

[Lisovskiy, Stanislav]

On Thu, Mar 26, 2020 at 03:53:22PM +0200, Mika Kahola wrote:
> Free dynamically allocated memory that has a potential
> to leak memory.
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>  tests/kms_concurrent.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

TBH dynamically allocating memory here seems to be overkill
anyway. We already know for sure that max planes that we are going
to have is no more than 8, We could just set limit of max planes to
lets say even 10 and just do all this stuff in stack, thus avoiding
those issues.

Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index 1a7c12fc..1403e990 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -193,6 +193,10 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
>  				    max_planes, output);
>  
>  	igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
> +
> +	free(x);
> +	free(y);
> +	free(size);
>  }
>  
>  static int test_bandwidth(data_t *data, enum pipe pipe, igt_output_t *output)
> @@ -228,6 +232,10 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
>  	while (i < iterations || loop_forever) {
>  		prepare_planes(data, pipe, max_planes, output);
>  		igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +
> +		for (int c = 0; c < max_planes; c++)
> +			igt_remove_fb(data->drm_fd, &data->fb[c]);
> +
>  		i++;
>  	}
>  }
> -- 
> 2.20.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_concurrent: Test maximum number of planes supported by the platform

[Lisovskiy, Stanislav]

On Thu, Mar 26, 2020 at 03:53:21PM +0200, Mika Kahola wrote:
> There was an error in
> 
> commit 0ab05a51a059 ("tests/kms_concurrent: Test for maximum number of planes")
> 
> supported planes. This patch proposes a fix to this commit by first computing
> the number of planes that are within platform's bandwidth requirements, resets
> the display and then executes the actual testing.
> 
> v2: Remove uninitialized variable (Stan)
> v3: Fix styling for commit reference (checkpatch)
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>


Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

> ---
>  tests/kms_concurrent.c | 102 ++++++++++++++++++-----------------------
>  1 file changed, 45 insertions(+), 57 deletions(-)
> 
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index 61137139..1a7c12fc 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -195,6 +195,25 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
>  	igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
>  }
>  
> +static int test_bandwidth(data_t *data, enum pipe pipe, igt_output_t *output)
> +{
> +
> +	int n_planes = data->display.pipes[pipe].n_planes;
> +	int i;
> +	int ret;
> +
> +	igt_pipe_refresh(&data->display, pipe, true);
> +
> +	for (i = 1; i <= n_planes; i++) {
> +		prepare_planes(data, pipe, i, output);
> +		ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC | DRM_MODE_ATOMIC_TEST_ONLY);
> +		if (ret != 0)
> +			break;
> +	}
> +
> +	return i - 1;
> +}
> +
>  static void
>  test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
>  				igt_output_t *output)
> @@ -208,7 +227,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
>  	i = 0;
>  	while (i < iterations || loop_forever) {
>  		prepare_planes(data, pipe, max_planes, output);
> -		igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> +		igt_display_commit2(&data->display, COMMIT_ATOMIC);
>  		i++;
>  	}
>  }
> @@ -241,44 +260,17 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
>  	return mode;
>  }
>  
> -static int
> +static void
>  test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
>  {
>  	const drmModeModeInfo *mode_hi, *mode_lo;
>  	int iterations = opt.iterations < 1 ? 1 : opt.iterations;
>  	bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
> -	int i, c, ret;
> -	int max_planes = data->display.pipes[pipe].n_planes;
> -	igt_plane_t *primary;
> -	drmModeModeInfo *mode;
> +	int i;
>  
>  	i = 0;
>  	while (i < iterations || loop_forever) {
>  		igt_output_set_pipe(output, pipe);
> -		for (c = 0; c < max_planes; c++) {
> -			igt_plane_t *plane = igt_output_get_plane(output, c);
> -
> -			if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -				continue;
> -			primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> -			data->plane[primary->index] = primary;
> -			mode = igt_output_get_mode(output);
> -			igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
> -						DRM_FORMAT_XRGB8888,
> -						LOCAL_I915_FORMAT_MOD_X_TILED,
> -						0.0f, 0.0f, 1.0f,
> -						&data->fb[primary->index]);
> -			igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
> -			ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> -			if (ret) {
> -				igt_plane_set_fb(data->plane[i], NULL);
> -				igt_remove_fb(data->drm_fd, &data->fb[i]);
> -				data->plane[i] = NULL;
> -				break;
> -			}
> -		}
> -		max_planes = c;
> -		igt_assert_lt(0, max_planes);
>  
>  		mode_hi = igt_output_get_mode(output);
>  		mode_lo = get_lowres_mode(data, mode_hi, output);
> @@ -293,48 +285,35 @@ test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
>  
>  		i++;
>  	}
> -
> -	return max_planes;
>  }
>  
>  static void
> -run_test(data_t *data, enum pipe pipe, igt_output_t *output)
> +run_test(data_t *data, enum pipe pipe, int max_planes, igt_output_t *output)
>  {
> -	int connected_outs;
> -	int n_planes = data->display.pipes[pipe].n_planes;
> -	int max_planes = n_planes;
> -
>  	if (!opt.user_seed)
>  		opt.seed = time(NULL);
>  
> -	connected_outs = 0;
> -	for_each_valid_output_on_pipe(&data->display, pipe, output) {
> -		igt_info("Testing resolution with connector %s using pipe %s with seed %d\n",
> -			 igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);
> -
> -		test_init(data, pipe, n_planes, output);
> -		max_planes = test_resolution_with_output(data, pipe, output);
> -
> -		igt_fork(child, 1) {
> -			test_plane_position_with_output(data, pipe, max_planes, output);
> -		}
> +	igt_info("Testing resolution with connector %s using pipe %s with seed %d\n",
> +		 igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);
>  
> -		test_resolution_with_output(data, pipe, output);
> +	test_init(data, pipe, max_planes, output);
> +	igt_fork(child, 1) {
> +		test_plane_position_with_output(data, pipe, max_planes, output);
> +	}
>  
> -		igt_waitchildren();
> +	test_resolution_with_output(data, pipe, output);
>  
> -		test_fini(data, pipe, n_planes, output);
> +	igt_waitchildren();
>  
> -		connected_outs++;
> -	}
> +	test_fini(data, pipe, max_planes, output);
>  
> -	igt_skip_on(connected_outs == 0);
>  }
>  
>  static void
>  run_tests_for_pipe(data_t *data, enum pipe pipe)
>  {
>  	igt_output_t *output;
> +	int max_planes;
>  
>  	igt_fixture {
>  		int valid_tests = 0;
> @@ -348,9 +327,18 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
>  		igt_require_f(valid_tests, "no valid crtc/connector combinations found\n");
>  	}
>  
> -	igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe))
> -		for_each_valid_output_on_pipe(&data->display, pipe, output)
> -			run_test(data, pipe, output);
> +	igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe)) {
> +		for_each_valid_output_on_pipe(&data->display, pipe, output) {
> +			int n_planes = data->display.pipes[pipe].n_planes;
> +
> +			test_init(data, pipe, n_planes, output);
> +			max_planes = test_bandwidth(data, pipe, output);
> +			test_fini(data, pipe, n_planes, output);
> +
> +			igt_display_reset(&data->display);
> +			run_test(data, pipe, max_planes, output);
> +		}
> +	}
>  }
>  
>  static int opt_handler(int option, int option_index, void *input)
> -- 
> 2.20.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_concurrent: Plug possible memory leaks

[Kahola, Mika]

Pushed! 

Thanks for the comments and reviews.

Cheers,
Mika

-----Original Message-----
From: Lisovskiy, Stanislav <stanislav.lisovskiy@intel.com> 
Sent: Friday, March 27, 2020 10:02 AM
To: Kahola, Mika <mika.kahola@intel.com>
Cc: igt-dev@lists.freedesktop.org; juhapekka.heikkila@gmail.com
Subject: Re: [PATCH i-g-t v3 2/2] tests/kms_concurrent: Plug possible memory leaks

On Thu, Mar 26, 2020 at 03:53:22PM +0200, Mika Kahola wrote:
> Free dynamically allocated memory that has a potential to leak memory.
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>  tests/kms_concurrent.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

TBH dynamically allocating memory here seems to be overkill anyway. We already know for sure that max planes that we are going to have is no more than 8, We could just set limit of max planes to lets say even 10 and just do all this stuff in stack, thus avoiding those issues.

Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c index 
> 1a7c12fc..1403e990 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -193,6 +193,10 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
>  				    max_planes, output);
>  
>  	igt_plane_set_fb(data->plane[primary->index], 
> &data->fb[primary->index]);
> +
> +	free(x);
> +	free(y);
> +	free(size);
>  }
>  
>  static int test_bandwidth(data_t *data, enum pipe pipe, igt_output_t 
> *output) @@ -228,6 +232,10 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
>  	while (i < iterations || loop_forever) {
>  		prepare_planes(data, pipe, max_planes, output);
>  		igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +
> +		for (int c = 0; c < max_planes; c++)
> +			igt_remove_fb(data->drm_fd, &data->fb[c]);
> +
>  		i++;
>  	}
>  }
> --
> 2.20.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

[Patchwork]

== Series Details ==

Series: tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)
URL   : https://patchwork.freedesktop.org/series/75104/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8194_full -> IGTPW_4359_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_4359_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_4359_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_4359_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_concurrent@pipe-b:
    - shard-hsw:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw5/igt@kms_concurrent@pipe-b.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw7/igt@kms_concurrent@pipe-b.html

  
New tests
---------

  New tests have been introduced between CI_DRM_8194_full and IGTPW_4359_full:

### New IGT tests (4) ###

  * igt@gem_ctx_isolation@clean:
    - Statuses :
    - Exec time: [None] s

  * igt@gem_ctx_isolation@dirty-create:
    - Statuses :
    - Exec time: [None] s

  * igt@gem_ctx_isolation@dirty-switch:
    - Statuses :
    - Exec time: [None] s

  * igt@gem_ctx_shared@exec-shared-gtt:
    - Statuses :
    - Exec time: [None] s

  

Known issues
------------

  Here are the changes found in IGTPW_4359_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_async@concurrent-writes-bsd:
    - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#112146]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb3/igt@gem_exec_async@concurrent-writes-bsd.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#110854])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb4/igt@gem_exec_balancer@smoke.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb7/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_parallel@vcs1-fds:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#112080]) +14 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html

  * igt@gem_exec_schedule@implicit-write-read-bsd:
    - shard-iclb:         [PASS][9] -> [SKIP][10] ([i915#677])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb5/igt@gem_exec_schedule@implicit-write-read-bsd.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb2/igt@gem_exec_schedule@implicit-write-read-bsd.html

  * igt@gem_exec_schedule@implicit-write-read-bsd1:
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#109276] / [i915#677]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb1/igt@gem_exec_schedule@implicit-write-read-bsd1.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb3/igt@gem_exec_schedule@implicit-write-read-bsd1.html

  * igt@gen9_exec_parse@allowed-all:
    - shard-apl:          [PASS][13] -> [DMESG-WARN][14] ([i915#716])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl8/igt@gen9_exec_parse@allowed-all.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl8/igt@gen9_exec_parse@allowed-all.html

  * igt@i915_pm_rps@reset:
    - shard-apl:          [PASS][15] -> [FAIL][16] ([i915#39])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl8/igt@i915_pm_rps@reset.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl3/igt@i915_pm_rps@reset.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen:
    - shard-kbl:          [PASS][17] -> [FAIL][18] ([i915#54] / [i915#93] / [i915#95]) +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html

  * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
    - shard-hsw:          [PASS][19] -> [FAIL][20] ([i915#57])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw7/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html

  * igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
    - shard-glk:          [PASS][21] -> [FAIL][22] ([i915#52] / [i915#54]) +3 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-glk6/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-glk1/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html

  * igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
    - shard-glk:          [PASS][23] -> [FAIL][24] ([i915#177] / [i915#52] / [i915#54])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-glk2/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-glk1/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html

  * igt@kms_fbcon_fbt@fbc:
    - shard-kbl:          [PASS][25] -> [FAIL][26] ([i915#64])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl6/igt@kms_fbcon_fbt@fbc.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl2/igt@kms_fbcon_fbt@fbc.html
    - shard-apl:          [PASS][27] -> [FAIL][28] ([i915#1525])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl4/igt@kms_fbcon_fbt@fbc.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl8/igt@kms_fbcon_fbt@fbc.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-hsw:          [PASS][29] -> [INCOMPLETE][30] ([i915#61]) +1 similar issue
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
    - shard-apl:          [PASS][31] -> [FAIL][32] ([i915#49] / [i915#95]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-kbl:          [PASS][33] -> [FAIL][34] ([i915#49]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite:
    - shard-glk:          [PASS][35] -> [FAIL][36] ([i915#49])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
    - shard-kbl:          [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +2 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-apl:          [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +4 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  * igt@kms_plane_cursor@pipe-a-overlay-size-256:
    - shard-kbl:          [PASS][41] -> [FAIL][42] ([i915#93] / [i915#95])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl6/igt@kms_plane_cursor@pipe-a-overlay-size-256.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl7/igt@kms_plane_cursor@pipe-a-overlay-size-256.html
    - shard-apl:          [PASS][43] -> [FAIL][44] ([i915#95])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl6/igt@kms_plane_cursor@pipe-a-overlay-size-256.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl6/igt@kms_plane_cursor@pipe-a-overlay-size-256.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][45] -> [SKIP][46] ([fdo#109642] / [fdo#111068])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb4/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_dpms:
    - shard-iclb:         [PASS][47] -> [SKIP][48] ([fdo#109441])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb2/igt@kms_psr@psr2_dpms.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb4/igt@kms_psr@psr2_dpms.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][49] -> [FAIL][50] ([i915#31])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl7/igt@kms_setmode@basic.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl4/igt@kms_setmode@basic.html

  * igt@prime_busy@hang-bsd2:
    - shard-iclb:         [PASS][51] -> [SKIP][52] ([fdo#109276]) +10 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb1/igt@prime_busy@hang-bsd2.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb5/igt@prime_busy@hang-bsd2.html

  
#### Possible fixes ####

  * igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd:
    - shard-apl:          [FAIL][53] -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl7/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl8/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html

  * igt@gem_exec_schedule@implicit-both-bsd1:
    - shard-iclb:         [SKIP][55] ([fdo#109276] / [i915#677]) -> [PASS][56] +2 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb7/igt@gem_exec_schedule@implicit-both-bsd1.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb4/igt@gem_exec_schedule@implicit-both-bsd1.html

  * igt@gem_exec_schedule@pi-userfault-bsd:
    - shard-iclb:         [SKIP][57] ([i915#677]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb1/igt@gem_exec_schedule@pi-userfault-bsd.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb6/igt@gem_exec_schedule@pi-userfault-bsd.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][59] ([fdo#112146]) -> [PASS][60] +8 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_exec_schedule@preempt-queue-bsd1:
    - shard-iclb:         [SKIP][61] ([fdo#109276]) -> [PASS][62] +17 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd1.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd1.html

  * igt@gem_userptr_blits@sync-unmap:
    - shard-snb:          [DMESG-WARN][63] ([fdo#111870] / [i915#478]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-snb1/igt@gem_userptr_blits@sync-unmap.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-snb5/igt@gem_userptr_blits@sync-unmap.html
    - shard-hsw:          [DMESG-WARN][65] ([fdo#111870]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw6/igt@gem_userptr_blits@sync-unmap.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-snb:          [TIMEOUT][67] ([i915#1526]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-snb1/igt@i915_pm_rc6_residency@rc6-idle.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-snb2/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@i915_pm_rpm@gem-idle:
    - shard-iclb:         [SKIP][69] ([i915#1316]) -> [PASS][70] +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb6/igt@i915_pm_rpm@gem-idle.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb1/igt@i915_pm_rpm@gem-idle.html
    - shard-glk:          [SKIP][71] ([fdo#109271]) -> [PASS][72] +1 similar issue
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-glk8/igt@i915_pm_rpm@gem-idle.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-glk5/igt@i915_pm_rpm@gem-idle.html
    - shard-tglb:         [SKIP][73] ([i915#1316]) -> [PASS][74] +1 similar issue
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-tglb2/igt@i915_pm_rpm@gem-idle.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-tglb1/igt@i915_pm_rpm@gem-idle.html

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-hsw:          [SKIP][75] ([fdo#109271]) -> [PASS][76]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw8/igt@i915_pm_rpm@system-suspend-execbuf.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw7/igt@i915_pm_rpm@system-suspend-execbuf.html

  * igt@i915_selftest@live@requests:
    - shard-tglb:         [INCOMPLETE][77] ([i915#1531]) -> [PASS][78]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-tglb2/igt@i915_selftest@live@requests.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-tglb1/igt@i915_selftest@live@requests.html

  * igt@kms_draw_crc@draw-method-rgb565-render-untiled:
    - shard-glk:          [FAIL][79] ([i915#52] / [i915#54]) -> [PASS][80] +3 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-glk6/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-glk9/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html

  * igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled:
    - shard-kbl:          [FAIL][81] ([fdo#108145] / [i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl7/igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl2/igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled.html
    - shard-apl:          [FAIL][83] ([fdo#108145] / [i915#52] / [i915#54] / [i915#95]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl1/igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl1/igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [DMESG-WARN][85] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][86]
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - shard-kbl:          [FAIL][87] ([i915#53] / [i915#93] / [i915#95]) -> [PASS][88]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
    - shard-apl:          [FAIL][89] ([i915#53] / [i915#95]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  * igt@kms_plane_cursor@pipe-a-viewport-size-64:
    - shard-kbl:          [FAIL][91] ([i915#93] / [i915#95]) -> [PASS][92] +1 similar issue
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl7/igt@kms_plane_cursor@pipe-a-viewport-size-64.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl2/igt@kms_plane_cursor@pipe-a-viewport-size-64.html
    - shard-apl:          [FAIL][93] ([i915#95]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl8/igt@kms_plane_cursor@pipe-a-viewport-size-64.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl8/igt@kms_plane_cursor@pipe-a-viewport-size-64.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-glk:          [FAIL][95] ([i915#899]) -> [PASS][96]
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-glk7/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-glk4/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][97] ([fdo#109441]) -> [PASS][98] +2 similar issues
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [DMESG-WARN][99] ([i915#180]) -> [PASS][100] +3 similar issues
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
    - shard-apl:          [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +2 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf_pmu@busy-vcs1:
    - shard-iclb:         [SKIP][103] ([fdo#112080]) -> [PASS][104] +3 similar issues
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb6/igt@perf_pmu@busy-vcs1.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb4/igt@perf_pmu@busy-vcs1.html

  
#### Warnings ####

  * igt@i915_pm_dc@dc3co-vpb-simulation:
    - shard-iclb:         [SKIP][105] ([i915#658]) -> [SKIP][106] ([i915#588])
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb6/igt@i915_pm_dc@dc3co-vpb-simulation.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html

  * igt@i915_pm_rpm@pc8-residency:
    - shard-iclb:         [SKIP][107] ([fdo#109293] / [fdo#109506]) -> [SKIP][108] ([i915#1316])
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-iclb6/igt@i915_pm_rpm@pc8-residency.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-iclb8/igt@i915_pm_rpm@pc8-residency.html
    - shard-tglb:         [SKIP][109] ([fdo#109506]) -> [SKIP][110] ([i915#1316])
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-tglb8/igt@i915_pm_rpm@pc8-residency.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-tglb8/igt@i915_pm_rpm@pc8-residency.html

  * igt@runner@aborted:
    - shard-hsw:          ([FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118]) ([fdo#111870] / [i915#1485]) -> ([FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125]) ([fdo#109271] / [fdo#111870] / [i915#1485])
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw5/igt@runner@aborted.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw6/igt@runner@aborted.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw6/igt@runner@aborted.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw5/igt@runner@aborted.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw6/igt@runner@aborted.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw7/igt@runner@aborted.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw5/igt@runner@aborted.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw8/igt@runner@aborted.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw7/igt@runner@aborted.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw7/igt@runner@aborted.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw7/igt@runner@aborted.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw6/igt@runner@aborted.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw2/igt@runner@aborted.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw2/igt@runner@aborted.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw1/igt@runner@aborted.html
    - shard-apl:          [FAIL][126] ([fdo#103927]) -> ([FAIL][127], [FAIL][128]) ([fdo#103927] / [i915#716])
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-apl4/igt@runner@aborted.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl8/igt@runner@aborted.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-apl4/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
  [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
  [i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316
  [i915#1485]: https://gitlab.freedesktop.org/drm/intel/issues/1485
  [i915#1525]: https://gitlab.freedesktop.org/drm/intel/issues/1525
  [i915#1526]: https://gitlab.freedesktop.org/drm/intel/issues/1526
  [i915#1531]: https://gitlab.freedesktop.org/drm/intel/issues/1531
  [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
  [i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
  [i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
  [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57
  [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
  [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
  [i915#64]: https://gitlab.freedesktop.org/drm/intel/issues/64
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
  [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
  [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
  [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (10 -> 8)
------------------------------

  Missing    (2): pig-skl-6260u pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5539 -> IGTPW_4359
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_8194: 0045c2479d9746be67d0b485ef0d92e238e4f2bd @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4359: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/index.html
  IGT_5539: e7aae12e37771a8b7796ba252574eb832a5839c3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

[Petri Latvala]

On Fri, Mar 27, 2020 at 10:05:59AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)
> URL   : https://patchwork.freedesktop.org/series/75104/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_8194_full -> IGTPW_4359_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with IGTPW_4359_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in IGTPW_4359_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/index.html
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in IGTPW_4359_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@kms_concurrent@pipe-b:
>     - shard-hsw:          [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw5/igt@kms_concurrent@pipe-b.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw7/igt@kms_concurrent@pipe-b.html


Pushed seconds before this result arrived...


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

[Kahola, Mika]

-----Original Message-----
From: Latvala, Petri <petri.latvala@intel.com> 
Sent: Friday, March 27, 2020 12:25 PM
To: igt-dev@lists.freedesktop.org
Cc: Kahola, Mika <mika.kahola@intel.com>
Subject: Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

On Fri, Mar 27, 2020 at 10:05:59AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)
> URL   : https://patchwork.freedesktop.org/series/75104/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_8194_full -> IGTPW_4359_full 
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with IGTPW_4359_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in IGTPW_4359_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/index.html
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in IGTPW_4359_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@kms_concurrent@pipe-b:
>     - shard-hsw:          [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8194/shard-hsw5/igt@kms_concurrent@pipe-b.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4359/shard-hsw7/igt@kms
> _concurrent@pipe-b.html


Pushed seconds before this result arrived...

Fail was only on hsw. I retest this as I don't think this was related to this change.

--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev4)

[Patchwork]

== Series Details ==

Series: tests/kms_concurrent: Test maximum number of planes supported by the platform (rev4)
URL   : https://patchwork.freedesktop.org/series/75104/
State : failure

== Summary ==

Applying: tests/kms_concurrent: Test maximum number of planes supported by the platform
Using index info to reconstruct a base tree...
M	tests/kms_concurrent.c
Falling back to patching base and 3-way merge...
Auto-merging tests/kms_concurrent.c
CONFLICT (content): Merge conflict in tests/kms_concurrent.c
Patch failed at 0001 tests/kms_concurrent: Test maximum number of planes supported by the platform
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

[Petri Latvala]

On Fri, Mar 27, 2020 at 01:45:44PM +0200, Kahola, Mika wrote:
> 
> Fail was only on hsw. I retest this as I don't think this was related to this change.

You can't retest this with a retest anymore, it doesn't apply.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

[Kahola, Mika]

-----Original Message-----
From: Latvala, Petri <petri.latvala@intel.com> 
Sent: Friday, March 27, 2020 2:34 PM
To: Kahola, Mika <mika.kahola@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

On Fri, Mar 27, 2020 at 01:45:44PM +0200, Kahola, Mika wrote:
> 
> Fail was only on hsw. I retest this as I don't think this was related to this change.

You can't retest this with a retest anymore, it doesn't apply.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

[Kahola, Mika]

-----Original Message-----
From: Latvala, Petri <petri.latvala@intel.com> 
Sent: Friday, March 27, 2020 2:34 PM
To: Kahola, Mika <mika.kahola@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

On Fri, Mar 27, 2020 at 01:45:44PM +0200, Kahola, Mika wrote:
> 
> Fail was only on hsw. I retest this as I don't think this was related to this change.

You can't retest this with a retest anymore, it doesn't apply.

I have to test this on my own HSW box.

-Mika-
-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

[Kahola, Mika]

-----Original Message-----
From: Latvala, Petri <petri.latvala@intel.com> 
Sent: Friday, March 27, 2020 2:34 PM
To: Kahola, Mika <mika.kahola@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Test maximum number of planes supported by the platform (rev3)

On Fri, Mar 27, 2020 at 01:45:44PM +0200, Kahola, Mika wrote:
> 
> Fail was only on hsw. I retest this as I don't think this was related to this change.

You can't retest this with a retest anymore, it doesn't apply.

I tested with pipe-B and unfortunately there is a problem with pipe B. The fix seems to be to move bandwidth calculation to igt_fixture instead of calculating it just before the test execution.

I'll throw a patch to fix this.

Cheers,
Mika


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev