All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@zonque.org>
To: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	Daniel Mack <daniel@zonque.org>
Subject: [PATCH] net: dsa: mv88e6xxx: don't force settings on CPU port
Date: Fri, 27 Mar 2020 20:51:56 +0100	[thread overview]
Message-ID: <20200327195156.1728163-1-daniel@zonque.org> (raw)

On hardware with a speed-reduced link to the CPU port, forcing the MAC
settings won't allow any packets to pass. The PHY will negotiate the
maximum possible speed, so let's allow the MAC to work with whatever
is available.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 2f993e673ec7..48808c4add4f 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -2426,7 +2426,7 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
 	 * state to any particular values on physical ports, but force the CPU
 	 * port and all DSA ports to their maximum bandwidth and full duplex.
 	 */
-	if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port))
+	if (dsa_is_dsa_port(ds, port))
 		err = mv88e6xxx_port_setup_mac(chip, port, LINK_FORCED_UP,
 					       SPEED_MAX, DUPLEX_FULL,
 					       PAUSE_OFF,
-- 
2.25.1


             reply	other threads:[~2020-03-27 19:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 19:51 Daniel Mack [this message]
2020-03-27 20:01 ` [PATCH] net: dsa: mv88e6xxx: don't force settings on CPU port Andrew Lunn
2020-03-27 20:48   ` Daniel Mack
2020-03-27 21:18     ` Andrew Lunn
2020-03-27 21:26       ` Daniel Mack
2020-03-27 23:52         ` Andrew Lunn
2020-03-30  9:29           ` Daniel Mack
2020-03-30 13:40             ` Andrew Lunn
2020-03-30 18:04               ` Daniel Mack
2020-03-30 18:23                 ` Andrew Lunn
2020-03-30 18:37                   ` Daniel Mack
2020-03-30 18:45                     ` Andrew Lunn
2020-06-22 18:43               ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200327195156.1728163-1-daniel@zonque.org \
    --to=daniel@zonque.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.