From: Jean-Philippe Menil <jpmenil@gmail.com>
To: daniel@iogearbox.net
Cc: kernel-janitors@vger.kernel.org, jpmenil@gmail.com,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4] bpf: fix build warning - missing prototype
Date: Fri, 27 Mar 2020 21:47:13 +0100 [thread overview]
Message-ID: <20200327204713.28050-1-jpmenil@gmail.com> (raw)
In-Reply-To: <3164e566-d54e-2254-32c4-d7fee47c37ea@iogearbox.net>
Fix build warnings when building net/bpf/test_run.o with W=1 due
to missing prototype for bpf_fentry_test{1..6}.
Instead of declaring prototypes, turn off warnings with
__diag_{push,ignore,pop} as pointed by Alexei.
Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
---
net/bpf/test_run.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
index 4c921f5154e0..73e703895343 100644
--- a/net/bpf/test_run.c
+++ b/net/bpf/test_run.c
@@ -114,6 +114,9 @@ static int bpf_test_finish(const union bpf_attr *kattr,
* architecture dependent calling conventions. 7+ can be supported in the
* future.
*/
+__diag_push();
+__diag_ignore(GCC, 8, "-Wmissing-prototypes",
+ "Global functions as their definitions will be in vmlinux BTF");
int noinline bpf_fentry_test1(int a)
{
return a + 1;
@@ -150,6 +153,8 @@ int noinline bpf_modify_return_test(int a, int *b)
return a + *b;
}
+__diag_pop();
+
ALLOW_ERROR_INJECTION(bpf_modify_return_test, ERRNO);
static void *bpf_test_init(const union bpf_attr *kattr, u32 size,
--
2.26.0
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Philippe Menil <jpmenil@gmail.com>
To: daniel@iogearbox.net
Cc: kernel-janitors@vger.kernel.org, jpmenil@gmail.com,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4] bpf: fix build warning - missing prototype
Date: Fri, 27 Mar 2020 20:47:13 +0000 [thread overview]
Message-ID: <20200327204713.28050-1-jpmenil@gmail.com> (raw)
In-Reply-To: <3164e566-d54e-2254-32c4-d7fee47c37ea@iogearbox.net>
Fix build warnings when building net/bpf/test_run.o with W=1 due
to missing prototype for bpf_fentry_test{1..6}.
Instead of declaring prototypes, turn off warnings with
__diag_{push,ignore,pop} as pointed by Alexei.
Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
---
net/bpf/test_run.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
index 4c921f5154e0..73e703895343 100644
--- a/net/bpf/test_run.c
+++ b/net/bpf/test_run.c
@@ -114,6 +114,9 @@ static int bpf_test_finish(const union bpf_attr *kattr,
* architecture dependent calling conventions. 7+ can be supported in the
* future.
*/
+__diag_push();
+__diag_ignore(GCC, 8, "-Wmissing-prototypes",
+ "Global functions as their definitions will be in vmlinux BTF");
int noinline bpf_fentry_test1(int a)
{
return a + 1;
@@ -150,6 +153,8 @@ int noinline bpf_modify_return_test(int a, int *b)
return a + *b;
}
+__diag_pop();
+
ALLOW_ERROR_INJECTION(bpf_modify_return_test, ERRNO);
static void *bpf_test_init(const union bpf_attr *kattr, u32 size,
--
2.26.0
next prev parent reply other threads:[~2020-03-27 20:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 14:08 [PATCH] bpf: fix build warning - missing prototype Jean-Philippe Menil
2020-03-22 14:08 ` Jean-Philippe Menil
2020-03-23 5:32 ` Yonghong Song
2020-03-23 5:32 ` Yonghong Song
2020-03-23 7:42 ` Jean-Philippe Menil
2020-03-23 7:42 ` Jean-Philippe Menil
2020-03-23 14:52 ` Yonghong Song
2020-03-23 14:52 ` Yonghong Song
2020-03-24 7:22 ` [PATCH v2] " Jean-Philippe Menil
2020-03-24 7:22 ` Jean-Philippe Menil
2020-03-24 16:19 ` Yonghong Song
2020-03-24 16:19 ` Yonghong Song
2020-03-26 23:54 ` Alexei Starovoitov
2020-03-26 23:54 ` Alexei Starovoitov
2020-03-27 7:55 ` [PATCH v3] " Jean-Philippe Menil
2020-03-27 7:55 ` Jean-Philippe Menil
2020-03-27 20:34 ` Daniel Borkmann
2020-03-27 20:34 ` Daniel Borkmann
2020-03-27 20:47 ` Jean-Philippe Menil [this message]
2020-03-27 20:47 ` [PATCH v4] " Jean-Philippe Menil
2020-03-28 17:15 ` Daniel Borkmann
2020-03-28 17:15 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327204713.28050-1-jpmenil@gmail.com \
--to=jpmenil@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.