From: Thierry Reding <thierry.reding@gmail.com>
To: Pascal Roeleven <dev@pascalroeleven.nl>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [RFC PATCH 1/4] pwm: sun4i: Remove redundant needs_delay
Date: Mon, 30 Mar 2020 16:16:57 +0200 [thread overview]
Message-ID: <20200330141657.GH2431644@ulmo> (raw)
In-Reply-To: <20200317155906.31288-2-dev@pascalroeleven.nl>
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
On Tue, Mar 17, 2020 at 04:59:03PM +0100, Pascal Roeleven wrote:
> 'needs_delay' does now always evaluate to true, so remove all
> occurrences.
>
> Signed-off-by: Pascal Roeleven <dev@pascalroeleven.nl>
> ---
> drivers/pwm/pwm-sun4i.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
I've applied this one since it's obviously correct. I'll hold off on the
others until it can be more broadly tested. Hopefully Maxime or Chen-Yu
can help review the remainder of this series as well.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Pascal Roeleven <dev-/1Tg0gxlrOS4ObxHbWkkimZHpeb/A1Y/@public.gmane.org>
Cc: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Maxime Ripard" <mripard-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Chen-Yu Tsai" <wens-jdAy2FN1RRM@public.gmane.org>,
"Philipp Zabel" <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [RFC PATCH 1/4] pwm: sun4i: Remove redundant needs_delay
Date: Mon, 30 Mar 2020 16:16:57 +0200 [thread overview]
Message-ID: <20200330141657.GH2431644@ulmo> (raw)
In-Reply-To: <20200317155906.31288-2-dev-/1Tg0gxlrOS4ObxHbWkkimZHpeb/A1Y/@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Tue, Mar 17, 2020 at 04:59:03PM +0100, Pascal Roeleven wrote:
> 'needs_delay' does now always evaluate to true, so remove all
> occurrences.
>
> Signed-off-by: Pascal Roeleven <dev-/1Tg0gxlrOS4ObxHbWkkimZHpeb/A1Y/@public.gmane.org>
> ---
> drivers/pwm/pwm-sun4i.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
I've applied this one since it's obviously correct. I'll hold off on the
others until it can be more broadly tested. Hopefully Maxime or Chen-Yu
can help review the remainder of this series as well.
Thierry
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Pascal Roeleven <dev@pascalroeleven.nl>
Cc: linux-pwm@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/4] pwm: sun4i: Remove redundant needs_delay
Date: Mon, 30 Mar 2020 16:16:57 +0200 [thread overview]
Message-ID: <20200330141657.GH2431644@ulmo> (raw)
In-Reply-To: <20200317155906.31288-2-dev@pascalroeleven.nl>
[-- Attachment #1.1: Type: text/plain, Size: 531 bytes --]
On Tue, Mar 17, 2020 at 04:59:03PM +0100, Pascal Roeleven wrote:
> 'needs_delay' does now always evaluate to true, so remove all
> occurrences.
>
> Signed-off-by: Pascal Roeleven <dev@pascalroeleven.nl>
> ---
> drivers/pwm/pwm-sun4i.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
I've applied this one since it's obviously correct. I'll hold off on the
others until it can be more broadly tested. Hopefully Maxime or Chen-Yu
can help review the remainder of this series as well.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-30 14:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 15:59 [RFC PATCH 0/4] pwm: sun4i: Properly turn pwm off and fix stuck output state Pascal Roeleven
2020-03-17 15:59 ` Pascal Roeleven
2020-03-17 15:59 ` [RFC PATCH 1/4] pwm: sun4i: Remove redundant needs_delay Pascal Roeleven
2020-03-17 15:59 ` Pascal Roeleven
2020-03-30 14:16 ` Thierry Reding [this message]
2020-03-30 14:16 ` Thierry Reding
2020-03-30 14:16 ` Thierry Reding
2020-03-17 15:59 ` [RFC PATCH 2/4] pwm: sun4i: Disable pwm before turning off clock gate Pascal Roeleven
2020-03-17 15:59 ` Pascal Roeleven
2020-04-09 15:19 ` Chen-Yu Tsai
2020-04-09 15:19 ` Chen-Yu Tsai
2020-04-09 15:19 ` Chen-Yu Tsai
2020-03-17 15:59 ` [RFC PATCH 3/4] pwm: sun4i: Move delay to function Pascal Roeleven
2020-03-17 15:59 ` Pascal Roeleven
2020-04-09 15:20 ` [linux-sunxi] " Chen-Yu Tsai
2020-04-09 15:20 ` Chen-Yu Tsai
2020-04-09 15:20 ` Chen-Yu Tsai
2020-03-17 15:59 ` [RFC PATCH 4/4] pwm: sun4i: Delay after writing the period Pascal Roeleven
2020-03-17 15:59 ` Pascal Roeleven
2020-04-09 15:20 ` Chen-Yu Tsai
2020-04-09 15:20 ` Chen-Yu Tsai
2020-04-09 15:20 ` Chen-Yu Tsai
2020-04-22 3:43 ` [linux-sunxi] " Samuel Holland
2020-04-22 3:43 ` Samuel Holland
2020-04-22 3:43 ` Samuel Holland
2020-04-22 8:40 ` [linux-sunxi] " Pascal Roeleven
2020-04-22 8:40 ` Pascal Roeleven
2020-04-22 8:40 ` Pascal Roeleven
2020-03-17 16:45 ` [RFC PATCH 0/4] pwm: sun4i: Properly turn pwm off and fix stuck output state Emil Lenngren
2020-03-17 16:45 ` Emil Lenngren
2020-03-17 18:15 ` Pascal Roeleven
2020-03-17 18:15 ` Pascal Roeleven
2020-03-17 19:35 ` Emil Lenngren
2020-03-17 19:35 ` Emil Lenngren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330141657.GH2431644@ulmo \
--to=thierry.reding@gmail.com \
--cc=dev@pascalroeleven.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.