Re: [PATCH v3] f2fs: fix long latency due to discard during umount

From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3] f2fs: fix long latency due to discard during umount
Date: Mon, 30 Mar 2020 16:57:40 +0800	[thread overview]
Message-ID: <202003301642.UXprwz6f%lkp@intel.com> (raw)
In-Reply-To: <1585550730-1858-1-git-send-email-stummala@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 3992 bytes --]

Hi Sahitya,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.6]
[cannot apply to f2fs/dev-test next-20200327]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Sahitya-Tummala/f2fs-fix-long-latency-due-to-discard-during-umount/20200330-151252
base:    7111951b8d4973bda27ff663f2cf18b663d15b48
config: nios2-randconfig-a001-20200329 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/f2fs/segment.c: In function '__issue_discard_cmd':
>> fs/f2fs/segment.c:1542:7: error: 'DEFAULT_IO_TIMEOUT' undeclared (first use in this function); did you mean 'BLK_DEFAULT_SG_TIMEOUT'?
    1542 |       DEFAULT_IO_TIMEOUT);
         |       ^~~~~~~~~~~~~~~~~~
         |       BLK_DEFAULT_SG_TIMEOUT
   fs/f2fs/segment.c:1542:7: note: each undeclared identifier is reported only once for each function it appears in

vim +1542 fs/f2fs/segment.c

  1489	
  1490	static int __issue_discard_cmd(struct f2fs_sb_info *sbi,
  1491						struct discard_policy *dpolicy)
  1492	{
  1493		struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
  1494		struct list_head *pend_list;
  1495		struct discard_cmd *dc, *tmp;
  1496		struct blk_plug plug;
  1497		int i, err, issued = 0;
  1498		bool io_interrupted = false;
  1499		bool retry;
  1500	
  1501		if (dpolicy->timeout != 0)
  1502			f2fs_update_time(sbi, dpolicy->timeout);
  1503	
  1504	retry:
  1505		retry = false;
  1506		for (i = MAX_PLIST_NUM - 1; i >= 0; i--) {
  1507			if (dpolicy->timeout != 0 &&
  1508					f2fs_time_over(sbi, dpolicy->timeout))
  1509				break;
  1510	
  1511			if (i + 1 < dpolicy->granularity)
  1512				break;
  1513	
  1514			if (i < DEFAULT_DISCARD_GRANULARITY && dpolicy->ordered)
  1515				return __issue_discard_cmd_orderly(sbi, dpolicy);
  1516	
  1517			pend_list = &dcc->pend_list[i];
  1518	
  1519			mutex_lock(&dcc->cmd_lock);
  1520			if (list_empty(pend_list))
  1521				goto next;
  1522			if (unlikely(dcc->rbtree_check))
  1523				f2fs_bug_on(sbi, !f2fs_check_rb_tree_consistence(sbi,
  1524									&dcc->root));
  1525			blk_start_plug(&plug);
  1526			list_for_each_entry_safe(dc, tmp, pend_list, list) {
  1527				f2fs_bug_on(sbi, dc->state != D_PREP);
  1528	
  1529				if (dpolicy->timeout != 0 &&
  1530					f2fs_time_over(sbi, dpolicy->timeout))
  1531					break;
  1532	
  1533				if (dpolicy->io_aware && i < dpolicy->io_aware_gran &&
  1534							!is_idle(sbi, DISCARD_TIME)) {
  1535					io_interrupted = true;
  1536					break;
  1537				}
  1538	
  1539				err = __submit_discard_cmd(sbi, dpolicy, dc, &issued);
  1540				if (err == -EAGAIN) {
  1541					congestion_wait(BLK_RW_ASYNC,
> 1542							DEFAULT_IO_TIMEOUT);
  1543					retry = true;
  1544				}
  1545	
  1546				if (issued >= dpolicy->max_requests)
  1547					break;
  1548			}
  1549			blk_finish_plug(&plug);
  1550	next:
  1551			mutex_unlock(&dcc->cmd_lock);
  1552	
  1553			if (issued >= dpolicy->max_requests || io_interrupted)
  1554				break;
  1555		}
  1556	
  1557		if (retry)
  1558			goto retry;
  1559	
  1560		if (!issued && io_interrupted)
  1561			issued = -1;
  1562	
  1563		return issued;
  1564	}
  1565	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 22926 bytes --]