[PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
@ 2020-03-25 20:59 ` Petr Štetiar
  0 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2020-03-25 20:59 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland
  Cc: Petr Štetiar, linux-arm-kernel, devicetree, linux-kernel

There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
to PE17 by default. So lets add this missing bit in the current hardware
description.

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 6dfafa1c879b..b9f90e19c035 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -32,6 +32,15 @@
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		user {
+			label = "a64-olinuxino:red:user";
+			gpios = <&pio 4 17 GPIO_ACTIVE_HIGH>; /* PE17 */
+		};
+	};
+
 	reg_usb1_vbus: usb1-vbus {
 		compatible = "regulator-fixed";
 		regulator-name = "usb1-vbus";

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
@ 2020-03-25 20:59 ` Petr Štetiar
  0 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2020-03-25 20:59 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland
  Cc: devicetree, Petr Štetiar, linux-kernel, linux-arm-kernel

There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
to PE17 by default. So lets add this missing bit in the current hardware
description.

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 6dfafa1c879b..b9f90e19c035 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -32,6 +32,15 @@
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		user {
+			label = "a64-olinuxino:red:user";
+			gpios = <&pio 4 17 GPIO_ACTIVE_HIGH>; /* PE17 */
+		};
+	};
+
 	reg_usb1_vbus: usb1-vbus {
 		compatible = "regulator-fixed";
 		regulator-name = "usb1-vbus";

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
  2020-03-25 20:59 ` Petr Štetiar
@ 2020-03-30 17:53   ` Maxime Ripard
  -1 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2020-03-30 17:53 UTC (permalink / raw)
  To: Petr Štetiar
  Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, linux-arm-kernel,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote:
> There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
> to PE17 by default. So lets add this missing bit in the current hardware
> description.
>
> Signed-off-by: Petr Štetiar <ynezz@true.cz>

QUeued for 5.8, thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
@ 2020-03-30 17:53   ` Maxime Ripard
  0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2020-03-30 17:53 UTC (permalink / raw)
  To: Petr Štetiar
  Cc: Mark Rutland, devicetree, linux-kernel, Chen-Yu Tsai,
	Rob Herring, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]

On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote:
> There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
> to PE17 by default. So lets add this missing bit in the current hardware
> description.
>
> Signed-off-by: Petr Štetiar <ynezz@true.cz>

QUeued for 5.8, thanks!
Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
  2020-03-30 17:53   ` Maxime Ripard
@ 2020-03-31  1:19     ` Chen-Yu Tsai
  -1 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2020-03-31  1:19 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Petr Štetiar, Rob Herring, Mark Rutland, linux-arm-kernel,
	devicetree, linux-kernel

On Tue, Mar 31, 2020 at 1:53 AM Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote:
> > There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
> > to PE17 by default. So lets add this missing bit in the current hardware
> > description.
> >
> > Signed-off-by: Petr Štetiar <ynezz@true.cz>
>
> QUeued for 5.8, thanks!

The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f])
as the child node name. This was recently brought to my attention. Do we
want to follow suit here?

ChenYu

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
@ 2020-03-31  1:19     ` Chen-Yu Tsai
  0 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2020-03-31  1:19 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Mark Rutland, devicetree, linux-kernel, Rob Herring,
	Petr Štetiar, linux-arm-kernel

On Tue, Mar 31, 2020 at 1:53 AM Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote:
> > There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
> > to PE17 by default. So lets add this missing bit in the current hardware
> > description.
> >
> > Signed-off-by: Petr Štetiar <ynezz@true.cz>
>
> QUeued for 5.8, thanks!

The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f])
as the child node name. This was recently brought to my attention. Do we
want to follow suit here?

ChenYu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
  2020-03-31  1:19     ` Chen-Yu Tsai
@ 2020-03-31  8:26       ` Petr Štetiar
  -1 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2020-03-31  8:26 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Maxime Ripard, Rob Herring, Mark Rutland, linux-arm-kernel,
	devicetree, linux-kernel

Chen-Yu Tsai <wens@csie.org> [2020-03-31 09:19:57]:

Hi,

> On Tue, Mar 31, 2020 at 1:53 AM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote:
> > > There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
> > > to PE17 by default. So lets add this missing bit in the current hardware
> > > description.
> > >
> > > Signed-off-by: Petr Štetiar <ynezz@true.cz>
> >
> > QUeued for 5.8, thanks!
> 
> The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f])
> as the child node name. This was recently brought to my attention. Do we
> want to follow suit here?

I can see following in Documentation/devicetree/bindings/leds/leds-gpio.yaml:

 patternProperties:
   # The first form is preferred, but fall back to just 'led' anywhere in the
   # node name to at least catch some child nodes.
   "(^led-[0-9a-f]$|led)":

So it seems like `led-0` is indeed preferred, should I send v2 or a new patch
as a fix on top of the previous one?

-- ynezz

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
@ 2020-03-31  8:26       ` Petr Štetiar
  0 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2020-03-31  8:26 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Mark Rutland, devicetree, linux-kernel, Rob Herring,
	Maxime Ripard, linux-arm-kernel

Chen-Yu Tsai <wens@csie.org> [2020-03-31 09:19:57]:

Hi,

> On Tue, Mar 31, 2020 at 1:53 AM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote:
> > > There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
> > > to PE17 by default. So lets add this missing bit in the current hardware
> > > description.
> > >
> > > Signed-off-by: Petr Štetiar <ynezz@true.cz>
> >
> > QUeued for 5.8, thanks!
> 
> The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f])
> as the child node name. This was recently brought to my attention. Do we
> want to follow suit here?

I can see following in Documentation/devicetree/bindings/leds/leds-gpio.yaml:

 patternProperties:
   # The first form is preferred, but fall back to just 'led' anywhere in the
   # node name to at least catch some child nodes.
   "(^led-[0-9a-f]$|led)":

So it seems like `led-0` is indeed preferred, should I send v2 or a new patch
as a fix on top of the previous one?

-- ynezz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
  2020-03-31  1:19     ` Chen-Yu Tsai
@ 2020-03-31  9:00       ` Maxime Ripard
  -1 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2020-03-31  9:00 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Petr Štetiar, Rob Herring, Mark Rutland, linux-arm-kernel,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

On Tue, Mar 31, 2020 at 09:19:57AM +0800, Chen-Yu Tsai wrote:
> On Tue, Mar 31, 2020 at 1:53 AM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote:
> > > There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
> > > to PE17 by default. So lets add this missing bit in the current hardware
> > > description.
> > >
> > > Signed-off-by: Petr Štetiar <ynezz@true.cz>
> >
> > QUeued for 5.8, thanks!
>
> The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f])
> as the child node name. This was recently brought to my attention. Do we
> want to follow suit here?

I've fixed it up, thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED
@ 2020-03-31  9:00       ` Maxime Ripard
  0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2020-03-31  9:00 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Mark Rutland, devicetree, linux-kernel, Rob Herring,
	Petr Štetiar, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 708 bytes --]

On Tue, Mar 31, 2020 at 09:19:57AM +0800, Chen-Yu Tsai wrote:
> On Tue, Mar 31, 2020 at 1:53 AM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote:
> > > There is a red LED marked as `GPIO_LED1` on the silkscreen and connected
> > > to PE17 by default. So lets add this missing bit in the current hardware
> > > description.
> > >
> > > Signed-off-by: Petr Štetiar <ynezz@true.cz>
> >
> > QUeued for 5.8, thanks!
>
> The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f])
> as the child node name. This was recently brought to my attention. Do we
> want to follow suit here?

I've fixed it up, thanks!
Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-03-31  9:00 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 20:59 [PATCH] arm64: dts: allwinner: a64: olinuxino: add user red LED Petr Štetiar
2020-03-25 20:59 ` Petr Štetiar
2020-03-30 17:53 ` Maxime Ripard
2020-03-30 17:53   ` Maxime Ripard
2020-03-31  1:19   ` Chen-Yu Tsai
2020-03-31  1:19     ` Chen-Yu Tsai
2020-03-31  8:26     ` Petr Štetiar
2020-03-31  8:26       ` Petr Štetiar
2020-03-31  9:00     ` Maxime Ripard
2020-03-31  9:00       ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.