* [igt-dev] [PATCH i-g-t 0/2] tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement
@ 2020-03-31 11:58 Mika Kahola
2020-03-31 11:58 ` [igt-dev] [PATCH i-g-t 1/2] Revert "tests/kms_concurrent: Test maximum number of planes supported by the platform" Mika Kahola
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Mika Kahola @ 2020-03-31 11:58 UTC (permalink / raw)
To: igt-dev; +Cc: petri.latvala
The first patch reverts a commit that caused regression on HSW pipe B/C tests. The second patch proposes
a different approach, compared to reverted patch, to calculate maximum number of planes that still meet the
bandwidth limitation.
Mika Kahola (2):
Revert "tests/kms_concurrent: Test maximum number of planes supported
by the platform"
tests/kms_concurrent: Use maximum number of planes that
display/platform combination supports
tests/kms_concurrent.c | 77 +++++++++++++++++-------------------------
1 file changed, 31 insertions(+), 46 deletions(-)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] Revert "tests/kms_concurrent: Test maximum number of planes supported by the platform"
2020-03-31 11:58 [igt-dev] [PATCH i-g-t 0/2] tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Mika Kahola
@ 2020-03-31 11:58 ` Mika Kahola
2020-03-31 11:58 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_concurrent: Use maximum number of planes that display/platform combination supports Mika Kahola
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Mika Kahola @ 2020-03-31 11:58 UTC (permalink / raw)
To: igt-dev; +Cc: petri.latvala
This reverts commit 2b65609b1de355ca501b58b7b03208f81c87b585.
---
tests/kms_concurrent.c | 102 +++++++++++++++++++++++------------------
1 file changed, 57 insertions(+), 45 deletions(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 1403e990..c212f6ec 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -199,25 +199,6 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
free(size);
}
-static int test_bandwidth(data_t *data, enum pipe pipe, igt_output_t *output)
-{
-
- int n_planes = data->display.pipes[pipe].n_planes;
- int i;
- int ret;
-
- igt_pipe_refresh(&data->display, pipe, true);
-
- for (i = 1; i <= n_planes; i++) {
- prepare_planes(data, pipe, i, output);
- ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC | DRM_MODE_ATOMIC_TEST_ONLY);
- if (ret != 0)
- break;
- }
-
- return i - 1;
-}
-
static void
test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
igt_output_t *output)
@@ -231,7 +212,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
i = 0;
while (i < iterations || loop_forever) {
prepare_planes(data, pipe, max_planes, output);
- igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
for (int c = 0; c < max_planes; c++)
igt_remove_fb(data->drm_fd, &data->fb[c]);
@@ -268,17 +249,44 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
return mode;
}
-static void
+static int
test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
{
const drmModeModeInfo *mode_hi, *mode_lo;
int iterations = opt.iterations < 1 ? 1 : opt.iterations;
bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
- int i;
+ int i, c, ret;
+ int max_planes = data->display.pipes[pipe].n_planes;
+ igt_plane_t *primary;
+ drmModeModeInfo *mode;
i = 0;
while (i < iterations || loop_forever) {
igt_output_set_pipe(output, pipe);
+ for (c = 0; c < max_planes; c++) {
+ igt_plane_t *plane = igt_output_get_plane(output, c);
+
+ if (plane->type != DRM_PLANE_TYPE_PRIMARY)
+ continue;
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ data->plane[primary->index] = primary;
+ mode = igt_output_get_mode(output);
+ igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ LOCAL_I915_FORMAT_MOD_X_TILED,
+ 0.0f, 0.0f, 1.0f,
+ &data->fb[primary->index]);
+ igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ if (ret) {
+ igt_plane_set_fb(data->plane[i], NULL);
+ igt_remove_fb(data->drm_fd, &data->fb[i]);
+ data->plane[i] = NULL;
+ break;
+ }
+ }
+ max_planes = c;
+ igt_assert_lt(0, max_planes);
mode_hi = igt_output_get_mode(output);
mode_lo = get_lowres_mode(data, mode_hi, output);
@@ -293,35 +301,48 @@ test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
i++;
}
+
+ return max_planes;
}
static void
-run_test(data_t *data, enum pipe pipe, int max_planes, igt_output_t *output)
+run_test(data_t *data, enum pipe pipe, igt_output_t *output)
{
+ int connected_outs;
+ int n_planes = data->display.pipes[pipe].n_planes;
+ int max_planes = n_planes;
+
if (!opt.user_seed)
opt.seed = time(NULL);
- igt_info("Testing resolution with connector %s using pipe %s with seed %d\n",
- igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);
+ connected_outs = 0;
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ igt_info("Testing resolution with connector %s using pipe %s with seed %d\n",
+ igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);
- test_init(data, pipe, max_planes, output);
- igt_fork(child, 1) {
- test_plane_position_with_output(data, pipe, max_planes, output);
- }
+ test_init(data, pipe, n_planes, output);
+ max_planes = test_resolution_with_output(data, pipe, output);
+
+ igt_fork(child, 1) {
+ test_plane_position_with_output(data, pipe, max_planes, output);
+ }
- test_resolution_with_output(data, pipe, output);
+ test_resolution_with_output(data, pipe, output);
- igt_waitchildren();
+ igt_waitchildren();
- test_fini(data, pipe, max_planes, output);
+ test_fini(data, pipe, n_planes, output);
+ connected_outs++;
+ }
+
+ igt_skip_on(connected_outs == 0);
}
static void
run_tests_for_pipe(data_t *data, enum pipe pipe)
{
igt_output_t *output;
- int max_planes;
igt_fixture {
int valid_tests = 0;
@@ -335,18 +356,9 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
igt_require_f(valid_tests, "no valid crtc/connector combinations found\n");
}
- igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe)) {
- for_each_valid_output_on_pipe(&data->display, pipe, output) {
- int n_planes = data->display.pipes[pipe].n_planes;
-
- test_init(data, pipe, n_planes, output);
- max_planes = test_bandwidth(data, pipe, output);
- test_fini(data, pipe, n_planes, output);
-
- igt_display_reset(&data->display);
- run_test(data, pipe, max_planes, output);
- }
- }
+ igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe))
+ for_each_valid_output_on_pipe(&data->display, pipe, output)
+ run_test(data, pipe, output);
}
static int opt_handler(int option, int option_index, void *input)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] tests/kms_concurrent: Use maximum number of planes that display/platform combination supports
2020-03-31 11:58 [igt-dev] [PATCH i-g-t 0/2] tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Mika Kahola
2020-03-31 11:58 ` [igt-dev] [PATCH i-g-t 1/2] Revert "tests/kms_concurrent: Test maximum number of planes supported by the platform" Mika Kahola
@ 2020-03-31 11:58 ` Mika Kahola
2020-04-01 6:51 ` Petri Latvala
2020-04-01 2:17 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Patchwork
` (3 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Mika Kahola @ 2020-03-31 11:58 UTC (permalink / raw)
To: igt-dev; +Cc: petri.latvala
There was an error in
commit 0ab05a51a059 ("tests/kms_concurrent: Test for maximum number of planes")
that calculates the maximum number of supported planes. The patch proposes to
test first if an atomic commit is successful with the selected number of planes.
In case of a failure, the number of planes is reduced by one assuming that the
failure was caused by bandwidth limit. The test loops at least as many iterations
as there are planes defined by the platform.
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
tests/kms_concurrent.c | 61 ++++++++++++------------------------------
1 file changed, 17 insertions(+), 44 deletions(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index c212f6ec..5de155f6 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -204,19 +204,23 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
igt_output_t *output)
{
int i;
- int iterations = opt.iterations < 1 ? 1 : opt.iterations;
+ int iterations = opt.iterations < 1 ? max_planes : opt.iterations;
bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
+ int ret;
igt_pipe_refresh(&data->display, pipe, true);
i = 0;
while (i < iterations || loop_forever) {
prepare_planes(data, pipe, max_planes, output);
- igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
for (int c = 0; c < max_planes; c++)
igt_remove_fb(data->drm_fd, &data->fb[c]);
+ if (ret != 0)
+ max_planes > 1 ? max_planes-- : 1;
+
i++;
}
}
@@ -249,44 +253,17 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
return mode;
}
-static int
-test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
+static void
+test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_output_t *output)
{
const drmModeModeInfo *mode_hi, *mode_lo;
- int iterations = opt.iterations < 1 ? 1 : opt.iterations;
+ int iterations = opt.iterations < 1 ? max_planes : opt.iterations;
bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
- int i, c, ret;
- int max_planes = data->display.pipes[pipe].n_planes;
- igt_plane_t *primary;
- drmModeModeInfo *mode;
+ int i;
i = 0;
while (i < iterations || loop_forever) {
igt_output_set_pipe(output, pipe);
- for (c = 0; c < max_planes; c++) {
- igt_plane_t *plane = igt_output_get_plane(output, c);
-
- if (plane->type != DRM_PLANE_TYPE_PRIMARY)
- continue;
- primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
- data->plane[primary->index] = primary;
- mode = igt_output_get_mode(output);
- igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
- DRM_FORMAT_XRGB8888,
- LOCAL_I915_FORMAT_MOD_X_TILED,
- 0.0f, 0.0f, 1.0f,
- &data->fb[primary->index]);
- igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
- ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
- if (ret) {
- igt_plane_set_fb(data->plane[i], NULL);
- igt_remove_fb(data->drm_fd, &data->fb[i]);
- data->plane[i] = NULL;
- break;
- }
- }
- max_planes = c;
- igt_assert_lt(0, max_planes);
mode_hi = igt_output_get_mode(output);
mode_lo = get_lowres_mode(data, mode_hi, output);
@@ -301,16 +278,12 @@ test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
i++;
}
-
- return max_planes;
}
static void
-run_test(data_t *data, enum pipe pipe, igt_output_t *output)
+run_test(data_t *data, enum pipe pipe, int max_planes, igt_output_t *output)
{
int connected_outs;
- int n_planes = data->display.pipes[pipe].n_planes;
- int max_planes = n_planes;
if (!opt.user_seed)
opt.seed = time(NULL);
@@ -320,18 +293,17 @@ run_test(data_t *data, enum pipe pipe, igt_output_t *output)
igt_info("Testing resolution with connector %s using pipe %s with seed %d\n",
igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);
- test_init(data, pipe, n_planes, output);
- max_planes = test_resolution_with_output(data, pipe, output);
+ test_init(data, pipe, max_planes, output);
igt_fork(child, 1) {
test_plane_position_with_output(data, pipe, max_planes, output);
}
- test_resolution_with_output(data, pipe, output);
+ test_resolution_with_output(data, pipe, max_planes, output);
igt_waitchildren();
- test_fini(data, pipe, n_planes, output);
+ test_fini(data, pipe, max_planes, output);
connected_outs++;
}
@@ -343,12 +315,13 @@ static void
run_tests_for_pipe(data_t *data, enum pipe pipe)
{
igt_output_t *output;
+ int n_planes = data->display.pipes[pipe].n_planes;
igt_fixture {
int valid_tests = 0;
igt_skip_on(pipe >= data->display.n_pipes);
- igt_require(data->display.pipes[pipe].n_planes > 0);
+ igt_require(n_planes > 0);
for_each_valid_output_on_pipe(&data->display, pipe, output)
valid_tests++;
@@ -358,7 +331,7 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe))
for_each_valid_output_on_pipe(&data->display, pipe, output)
- run_test(data, pipe, output);
+ run_test(data, pipe, n_planes, output);
}
static int opt_handler(int option, int option_index, void *input)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement
2020-03-31 11:58 [igt-dev] [PATCH i-g-t 0/2] tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Mika Kahola
2020-03-31 11:58 ` [igt-dev] [PATCH i-g-t 1/2] Revert "tests/kms_concurrent: Test maximum number of planes supported by the platform" Mika Kahola
2020-03-31 11:58 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_concurrent: Use maximum number of planes that display/platform combination supports Mika Kahola
@ 2020-04-01 2:17 ` Patchwork
2020-04-01 2:24 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-04-01 2:17 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement
URL : https://patchwork.freedesktop.org/series/75323/
State : failure
== Summary ==
IGT patchset build failed on latest successful build
98927dfde17aecaecfe67bb9853ceca326ca2b23 lib: Sync i915_pciids.h with kernel
273/286 testcase check: amdgpu/amd_prime OK 0.10 s
274/286 runner OK 5.43 s
275/286 runner_json OK 0.10 s
276/286 assembler: test/mov OK 0.03 s
277/286 assembler: test/frc OK 0.08 s
278/286 assembler: test/regtype OK 0.07 s
279/286 assembler: test/rndd OK 0.08 s
280/286 assembler: test/rndu OK 0.06 s
281/286 assembler: test/rnde OK 0.06 s
282/286 assembler: test/rnde-intsrc OK 0.06 s
283/286 assembler: test/rndz OK 0.05 s
284/286 assembler: test/lzd OK 0.03 s
285/286 assembler: test/not OK 0.05 s
286/286 assembler: test/immediate OK 0.04 s
OK: 285
FAIL: 1
SKIP: 0
TIMEOUT: 0
The output from the failed tests:
45/286 testcase check: kms_concurrent FAIL 0.37 s (exit status 1)
--- command ---
/home/cidrm/igt-gpu-tools/tests/igt_command_line.sh kms_concurrent
--- stdout ---
tests/kms_concurrent:
Checking invalid option handling...
Checking valid option handling...
Checking subtest enumeration...
test does not exit with 0 or 79 with --list-subtests!
FAIL: tests/kms_concurrent
--- stderr ---
Received signal SIGSEGV.
Stack trace:
#0 [fatal_sig_handler+0xd6]
#1 [killpg+0x40]
#2 [run_tests_for_pipe.constprop.7+0x4a]
#3 [__real_main371+0x5d]
#4 [main+0x39]
#5 [__libc_start_main+0xe7]
#6 [_start+0x2a]
-------
Full log written to /home/cidrm/igt-gpu-tools/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/python3 -u /usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement
2020-03-31 11:58 [igt-dev] [PATCH i-g-t 0/2] tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Mika Kahola
` (2 preceding siblings ...)
2020-04-01 2:17 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Patchwork
@ 2020-04-01 2:24 ` Patchwork
2020-04-01 6:16 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement (rev2) Patchwork
2020-04-01 6:26 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-04-01 2:24 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement
URL : https://patchwork.freedesktop.org/series/75323/
State : warning
== Summary ==
Did not get list of undocumented tests for this run, something is wrong!
Other than that, pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/126945 for the overview.
test:ninja-test has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2136974):
#2 [run_tests_for_pipe.constprop.0+0x3b]
#3 [__real_main371+0xb9]
#4 [main+0x30]
#5 [__libc_start_main+0xf3]
#6 [_start+0x2e]
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585707766:build_script
section_start:1585707766:after_script
Running after_script
section_end:1585707767:after_script
section_start:1585707767:upload_artifacts_on_failure
Uploading artifacts for failed job
section_end:1585707769:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
test:ninja-test-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2137002):
#4 [main+0x3c]
#5 [__libc_start_main+0xe4]
#6 [_start+0x34]
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585707801:build_script
section_start:1585707801:after_script
section_end:1585707803:after_script
section_start:1585707803:upload_artifacts_on_failure
Uploading artifacts...
build: found 1388 matching files
Uploading artifacts to coordinator... ok id=2137002 responseStatus=201 Created token=zb1xeA-b
section_end:1585707814:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
test:ninja-test-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2137004):
#6 [_start+0x34]
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585707855:build_script
section_start:1585707855:after_script
Running after_script
section_end:1585707856:after_script
section_start:1585707856:upload_artifacts_on_failure
Uploading artifacts for failed job
Uploading artifacts...
build: found 1388 matching files
Uploading artifacts to coordinator... ok id=2137004 responseStatus=201 Created token=xyTrQ86u
section_end:1585707866:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
test:ninja-test-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2136970):
Stack trace:
#0 [killpg+0x40]
#1 [run_tests_for_pipe+0x26]
#2 [__real_main371+0xc2]
#3 [main+0x36]
#4 [__libc_start_main+0xf3]
#5 [_start+0x2e]
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585707738:build_script
section_start:1585707738:after_script
section_end:1585707740:after_script
section_start:1585707740:upload_artifacts_on_failure
section_end:1585707741:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
test:ninja-test-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2137003):
--- stderr ---
Received signal SIGSEGV.
Stack trace:
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585707813:build_script
section_start:1585707813:after_script
section_end:1585707815:after_script
section_start:1585707815:upload_artifacts_on_failure
Uploading artifacts...
build: found 1388 matching files
Uploading artifacts to coordinator... ok id=2137003 responseStatus=201 Created token=9ZLurN_w
section_end:1585707824:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/126945
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement (rev2)
2020-03-31 11:58 [igt-dev] [PATCH i-g-t 0/2] tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Mika Kahola
` (3 preceding siblings ...)
2020-04-01 2:24 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
@ 2020-04-01 6:16 ` Patchwork
2020-04-01 6:26 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-04-01 6:16 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement (rev2)
URL : https://patchwork.freedesktop.org/series/75323/
State : failure
== Summary ==
IGT patchset build failed on latest successful build
98927dfde17aecaecfe67bb9853ceca326ca2b23 lib: Sync i915_pciids.h with kernel
273/286 testcase check: amdgpu/amd_prime OK 0.16 s
274/286 runner OK 5.47 s
275/286 runner_json OK 0.12 s
276/286 assembler: test/mov OK 0.09 s
277/286 assembler: test/frc OK 0.04 s
278/286 assembler: test/regtype OK 0.06 s
279/286 assembler: test/rndd OK 0.08 s
280/286 assembler: test/rndu OK 0.03 s
281/286 assembler: test/rnde OK 0.07 s
282/286 assembler: test/rnde-intsrc OK 0.07 s
283/286 assembler: test/rndz OK 0.04 s
284/286 assembler: test/lzd OK 0.06 s
285/286 assembler: test/not OK 0.05 s
286/286 assembler: test/immediate OK 0.05 s
OK: 285
FAIL: 1
SKIP: 0
TIMEOUT: 0
The output from the failed tests:
45/286 testcase check: kms_concurrent FAIL 0.27 s (exit status 1)
--- command ---
/home/cidrm/igt-gpu-tools/tests/igt_command_line.sh kms_concurrent
--- stdout ---
tests/kms_concurrent:
Checking invalid option handling...
Checking valid option handling...
Checking subtest enumeration...
test does not exit with 0 or 79 with --list-subtests!
FAIL: tests/kms_concurrent
--- stderr ---
Received signal SIGSEGV.
Stack trace:
#0 [fatal_sig_handler+0xd6]
#1 [killpg+0x40]
#2 [run_tests_for_pipe.constprop.7+0x4a]
#3 [__real_main371+0x5d]
#4 [main+0x39]
#5 [__libc_start_main+0xe7]
#6 [_start+0x2a]
-------
Full log written to /home/cidrm/igt-gpu-tools/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/python3 -u /usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement (rev2)
2020-03-31 11:58 [igt-dev] [PATCH i-g-t 0/2] tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Mika Kahola
` (4 preceding siblings ...)
2020-04-01 6:16 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement (rev2) Patchwork
@ 2020-04-01 6:26 ` Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-04-01 6:26 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement (rev2)
URL : https://patchwork.freedesktop.org/series/75323/
State : warning
== Summary ==
Did not get list of undocumented tests for this run, something is wrong!
Other than that, pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/127022 for the overview.
test:ninja-test has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2139162):
#0 [fatal_sig_handler+0x103]
#1 [killpg+0x40]
#2 [run_tests_for_pipe.constprop.0+0x3b]
#3 [__real_main371+0xb9]
#4 [main+0x30]
#5 [__libc_start_main+0xf3]
#6 [_start+0x2e]
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585722222:build_script
section_start:1585722222:after_script
section_end:1585722224:after_script
section_start:1585722224:upload_artifacts_on_failure
section_end:1585722226:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
test:ninja-test-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2139163):
#4 [main+0x3c]
#5 [__libc_start_main+0xe4]
#6 [_start+0x34]
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585722233:build_script
section_start:1585722233:after_script
section_end:1585722234:after_script
section_start:1585722234:upload_artifacts_on_failure
Uploading artifacts...
build: found 1388 matching files
Uploading artifacts to coordinator... ok id=2139163 responseStatus=201 Created token=XVi3RSkz
section_end:1585722252:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
test:ninja-test-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2139160):
#4 [main+0x26]
#5 [__libc_start_main+0x98]
#6 [_start+0x34]
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585722193:build_script
section_start:1585722193:after_script
section_end:1585722195:after_script
section_start:1585722195:upload_artifacts_on_failure
Uploading artifacts...
build: found 1388 matching files
Uploading artifacts to coordinator... ok id=2139160 responseStatus=201 Created token=wzbxKXcx
section_end:1585722204:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
test:ninja-test-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2139161):
#1 [run_tests_for_pipe+0x26]
#2 [__real_main371+0xc2]
#3 [main+0x36]
#4 [__libc_start_main+0xf3]
#5 [_start+0x2e]
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585722238:build_script
section_start:1585722238:after_script
Running after_script
section_end:1585722239:after_script
section_start:1585722239:upload_artifacts_on_failure
Uploading artifacts for failed job
section_end:1585722241:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
test:ninja-test-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2139164):
--- stderr ---
Received signal SIGSEGV.
Stack trace:
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
-------
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
section_end:1585722217:build_script
section_start:1585722217:after_script
section_end:1585722218:after_script
section_start:1585722218:upload_artifacts_on_failure
Uploading artifacts...
build: found 1388 matching files
Uploading artifacts to coordinator... ok id=2139164 responseStatus=201 Created token=iaDYwLy2
section_end:1585722228:upload_artifacts_on_failure
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/127022
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_concurrent: Use maximum number of planes that display/platform combination supports
2020-03-31 11:58 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_concurrent: Use maximum number of planes that display/platform combination supports Mika Kahola
@ 2020-04-01 6:51 ` Petri Latvala
0 siblings, 0 replies; 8+ messages in thread
From: Petri Latvala @ 2020-04-01 6:51 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
On Tue, Mar 31, 2020 at 02:58:24PM +0300, Mika Kahola wrote:
> There was an error in
>
> commit 0ab05a51a059 ("tests/kms_concurrent: Test for maximum number of planes")
>
> that calculates the maximum number of supported planes. The patch proposes to
> test first if an atomic commit is successful with the selected number of planes.
> In case of a failure, the number of planes is reduced by one assuming that the
> failure was caused by bandwidth limit. The test loops at least as many iterations
> as there are planes defined by the platform.
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_concurrent.c | 61 ++++++++++++------------------------------
> 1 file changed, 17 insertions(+), 44 deletions(-)
>
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index c212f6ec..5de155f6 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -204,19 +204,23 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
> igt_output_t *output)
> {
> int i;
> - int iterations = opt.iterations < 1 ? 1 : opt.iterations;
> + int iterations = opt.iterations < 1 ? max_planes : opt.iterations;
> bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
> + int ret;
>
> igt_pipe_refresh(&data->display, pipe, true);
>
> i = 0;
> while (i < iterations || loop_forever) {
> prepare_planes(data, pipe, max_planes, output);
> - igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
>
> for (int c = 0; c < max_planes; c++)
> igt_remove_fb(data->drm_fd, &data->fb[c]);
>
> + if (ret != 0)
> + max_planes > 1 ? max_planes-- : 1;
> +
> i++;
> }
> }
> @@ -249,44 +253,17 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
> return mode;
> }
>
> -static int
> -test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
> +static void
> +test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_output_t *output)
> {
> const drmModeModeInfo *mode_hi, *mode_lo;
> - int iterations = opt.iterations < 1 ? 1 : opt.iterations;
> + int iterations = opt.iterations < 1 ? max_planes : opt.iterations;
> bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
> - int i, c, ret;
> - int max_planes = data->display.pipes[pipe].n_planes;
> - igt_plane_t *primary;
> - drmModeModeInfo *mode;
> + int i;
>
> i = 0;
> while (i < iterations || loop_forever) {
> igt_output_set_pipe(output, pipe);
> - for (c = 0; c < max_planes; c++) {
> - igt_plane_t *plane = igt_output_get_plane(output, c);
> -
> - if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> - continue;
> - primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> - data->plane[primary->index] = primary;
> - mode = igt_output_get_mode(output);
> - igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
> - DRM_FORMAT_XRGB8888,
> - LOCAL_I915_FORMAT_MOD_X_TILED,
> - 0.0f, 0.0f, 1.0f,
> - &data->fb[primary->index]);
> - igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
> - ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> - if (ret) {
> - igt_plane_set_fb(data->plane[i], NULL);
> - igt_remove_fb(data->drm_fd, &data->fb[i]);
> - data->plane[i] = NULL;
> - break;
> - }
> - }
> - max_planes = c;
> - igt_assert_lt(0, max_planes);
>
> mode_hi = igt_output_get_mode(output);
> mode_lo = get_lowres_mode(data, mode_hi, output);
> @@ -301,16 +278,12 @@ test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
>
> i++;
> }
> -
> - return max_planes;
> }
>
> static void
> -run_test(data_t *data, enum pipe pipe, igt_output_t *output)
> +run_test(data_t *data, enum pipe pipe, int max_planes, igt_output_t *output)
> {
> int connected_outs;
> - int n_planes = data->display.pipes[pipe].n_planes;
> - int max_planes = n_planes;
>
> if (!opt.user_seed)
> opt.seed = time(NULL);
> @@ -320,18 +293,17 @@ run_test(data_t *data, enum pipe pipe, igt_output_t *output)
> igt_info("Testing resolution with connector %s using pipe %s with seed %d\n",
> igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);
>
> - test_init(data, pipe, n_planes, output);
> - max_planes = test_resolution_with_output(data, pipe, output);
> + test_init(data, pipe, max_planes, output);
>
> igt_fork(child, 1) {
> test_plane_position_with_output(data, pipe, max_planes, output);
> }
>
> - test_resolution_with_output(data, pipe, output);
> + test_resolution_with_output(data, pipe, max_planes, output);
>
> igt_waitchildren();
>
> - test_fini(data, pipe, n_planes, output);
> + test_fini(data, pipe, max_planes, output);
>
> connected_outs++;
> }
> @@ -343,12 +315,13 @@ static void
> run_tests_for_pipe(data_t *data, enum pipe pipe)
> {
> igt_output_t *output;
> + int n_planes = data->display.pipes[pipe].n_planes;
This was already communicated off-list but recording here as well:
data->display.pipes is invalid here if we're listing subtests.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-04-01 6:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31 11:58 [igt-dev] [PATCH i-g-t 0/2] tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Mika Kahola
2020-03-31 11:58 ` [igt-dev] [PATCH i-g-t 1/2] Revert "tests/kms_concurrent: Test maximum number of planes supported by the platform" Mika Kahola
2020-03-31 11:58 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_concurrent: Use maximum number of planes that display/platform combination supports Mika Kahola
2020-04-01 6:51 ` Petri Latvala
2020-04-01 2:17 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement Patchwork
2020-04-01 2:24 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2020-04-01 6:16 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_concurrent: Calculate maximum number of planes to meet bandwidth requirement (rev2) Patchwork
2020-04-01 6:26 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.