From: Tejun Heo <tj@kernel.org> To: Weiping Zhang <zwp10758@gmail.com> Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>, Bart Van Assche <bvanassche@acm.org>, Minwoo Im <minwoo.im.dev@gmail.com>, Thomas Gleixner <tglx@linutronix.de>, Ming Lei <ming.lei@redhat.com>, "Nadolski, Edmund" <edmund.nadolski@intel.com>, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v5 0/4] Add support Weighted Round Robin for blkcg and nvme Date: Tue, 31 Mar 2020 11:51:39 -0400 [thread overview] Message-ID: <20200331155139.GT162390@mtj.duckdns.org> (raw) In-Reply-To: <CAA70yB51=VQrL+2wC+DL8cYmGVACb2_w5UHc4XFn7MgZjUJaeg@mail.gmail.com> Hello, On Tue, Mar 31, 2020 at 11:47:41PM +0800, Weiping Zhang wrote: > Do you means drop the "io.wrr" or "blkio.wrr" in cgroup, and use a > dedicated interface > like /dev/xxx or /proc/xxx? Yes, something along that line. Given that it's nvme specific, it'd be best if the interface reflects that too - e.g. through a file under /sys/block/nvme*/device/. Jens, Christoph, what do you guys think? > I see the perf code: > struct fd f = fdget(fd) > struct cgroup_subsys_state *css = > css_tryget_online_from_dir(f.file->f_path.dentry, > &perf_event_cgrp_subsys); > > Looks can be applied to block cgroup in same way. Yeah, either fd or ino can be used to identify a cgroup. Thanks. -- tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org> To: Weiping Zhang <zwp10758@gmail.com> Cc: Jens Axboe <axboe@kernel.dk>, Bart Van Assche <bvanassche@acm.org>, linux-nvme@lists.infradead.org, Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org, Minwoo Im <minwoo.im.dev@gmail.com>, cgroups@vger.kernel.org, Keith Busch <kbusch@kernel.org>, "Nadolski, Edmund" <edmund.nadolski@intel.com>, Thomas Gleixner <tglx@linutronix.de>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH v5 0/4] Add support Weighted Round Robin for blkcg and nvme Date: Tue, 31 Mar 2020 11:51:39 -0400 [thread overview] Message-ID: <20200331155139.GT162390@mtj.duckdns.org> (raw) In-Reply-To: <CAA70yB51=VQrL+2wC+DL8cYmGVACb2_w5UHc4XFn7MgZjUJaeg@mail.gmail.com> Hello, On Tue, Mar 31, 2020 at 11:47:41PM +0800, Weiping Zhang wrote: > Do you means drop the "io.wrr" or "blkio.wrr" in cgroup, and use a > dedicated interface > like /dev/xxx or /proc/xxx? Yes, something along that line. Given that it's nvme specific, it'd be best if the interface reflects that too - e.g. through a file under /sys/block/nvme*/device/. Jens, Christoph, what do you guys think? > I see the perf code: > struct fd f = fdget(fd) > struct cgroup_subsys_state *css = > css_tryget_online_from_dir(f.file->f_path.dentry, > &perf_event_cgrp_subsys); > > Looks can be applied to block cgroup in same way. Yeah, either fd or ino can be used to identify a cgroup. Thanks. -- tejun _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-31 15:51 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-04 3:30 [PATCH v5 0/4] Add support Weighted Round Robin for blkcg and nvme Weiping Zhang 2020-02-04 3:30 ` Weiping Zhang 2020-02-04 3:30 ` Weiping Zhang 2020-02-04 3:31 ` [PATCH v5 1/4] block: add weighted round robin for blkcgroup Weiping Zhang 2020-02-04 3:31 ` Weiping Zhang 2020-02-04 3:31 ` Weiping Zhang 2020-02-04 3:31 ` [PATCH v5 2/4] nvme: add get_ams for nvme_ctrl_ops Weiping Zhang 2020-02-04 3:31 ` Weiping Zhang 2020-02-04 3:31 ` Weiping Zhang 2020-02-04 3:31 ` [PATCH v5 3/4] nvme-pci: rename module parameter write_queues to read_queues Weiping Zhang 2020-02-04 3:31 ` Weiping Zhang 2020-02-04 3:31 ` Weiping Zhang 2020-02-04 3:31 ` [PATCH v5 4/4] nvme: add support weighted round robin queue Weiping Zhang 2020-02-04 3:31 ` Weiping Zhang 2020-02-04 3:31 ` Weiping Zhang 2020-02-04 15:42 ` [PATCH v5 0/4] Add support Weighted Round Robin for blkcg and nvme Keith Busch 2020-02-04 15:42 ` Keith Busch 2020-02-16 8:09 ` Weiping Zhang 2020-02-16 8:09 ` Weiping Zhang 2020-02-16 8:09 ` Weiping Zhang 2020-03-31 6:17 ` Weiping Zhang 2020-03-31 6:17 ` Weiping Zhang 2020-03-31 10:29 ` Paolo Valente 2020-03-31 10:29 ` Paolo Valente 2020-03-31 14:36 ` Tejun Heo 2020-03-31 14:36 ` Tejun Heo 2020-03-31 14:36 ` Tejun Heo 2020-03-31 15:47 ` Weiping Zhang 2020-03-31 15:47 ` Weiping Zhang 2020-03-31 15:47 ` Weiping Zhang 2020-03-31 15:51 ` Tejun Heo [this message] 2020-03-31 15:51 ` Tejun Heo 2020-03-31 15:52 ` Christoph Hellwig 2020-03-31 15:52 ` Christoph Hellwig 2020-03-31 15:52 ` Christoph Hellwig 2020-03-31 15:54 ` Tejun Heo 2020-03-31 15:54 ` Tejun Heo 2020-03-31 15:54 ` Tejun Heo 2020-03-31 16:31 ` Weiping Zhang 2020-03-31 16:31 ` Weiping Zhang 2020-03-31 16:31 ` Weiping Zhang 2020-03-31 16:33 ` Christoph Hellwig 2020-03-31 16:33 ` Christoph Hellwig 2020-03-31 16:33 ` Christoph Hellwig 2020-03-31 16:52 ` Weiping Zhang 2020-03-31 16:52 ` Weiping Zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200331155139.GT162390@mtj.duckdns.org \ --to=tj@kernel.org \ --cc=axboe@kernel.dk \ --cc=bvanassche@acm.org \ --cc=cgroups@vger.kernel.org \ --cc=edmund.nadolski@intel.com \ --cc=hch@lst.de \ --cc=kbusch@kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=ming.lei@redhat.com \ --cc=minwoo.im.dev@gmail.com \ --cc=tglx@linutronix.de \ --cc=zwp10758@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.