[Outreachy] [PATCH 0/2] staging: qlge: Resolve various warnings reported by checkpatch.pl

[Outreachy] [PATCH 0/2] staging: qlge: Resolve various warnings reported by checkpatch.pl

[Soumyajit Deb]

This patchset resolves coding style and indentation issues reported by
checkpatch.pl
This patchset removes unnecessary blank lines and properly indents the
multiline comments by shifting the end of multiline comments "*/" to the
next line to improve code readability and adhere to the uniform coding
style, all for the same file qlge_mpi.c present under
drivers/staging/qlge directory.

Soumyajit Deb (2):
  staging: qlge: Remove extra blank lines
  staging: qlge: Properly indent the multiline comments

 drivers/staging/qlge/qlge_mpi.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

-- 
2.17.1

[Outreachy] [PATCH 1/2] staging: qlge: Remove extra blank lines

[Soumyajit Deb]

Remove unnecessary extra blank lines to improve code readability and to
adhere to the Linux Kernel coding style.
Reported by checkpatch.pl

Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
---
 drivers/staging/qlge/qlge_mpi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 60c08d9cc034..b30992825612 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -119,7 +119,6 @@ int ql_own_firmware(struct ql_adapter *qdev)
 		return 1;
 
 	return 0;
-
 }
 
 static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp)
@@ -358,7 +357,6 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp)
 		for (i = 0; i < mbcp->out_count; i++)
 			netif_err(qdev, drv, qdev->ndev, "mbox_out[%d] = 0x%.08x.\n",
 				  i, mbcp->mbox_out[i]);
-
 	}
 
 	return status;
@@ -406,7 +404,6 @@ static int ql_mpi_handler(struct ql_adapter *qdev, struct mbox_params *mbcp)
 	}
 
 	switch (mbcp->mbox_out[0]) {
-
 	/* This case is only active when we arrive here
 	 * as a result of issuing a mailbox command to
 	 * the firmware.
-- 
2.17.1

[Outreachy] [PATCH 2/2] staging: qlge: Properly indent the multiline comments

[Soumyajit Deb]

Shift the end of multiline comments "*/" to the next line to improve
code readability and to adhere to a uniform coding style.
Reported by checkpatch.pl

Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
---
 drivers/staging/qlge/qlge_mpi.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index b30992825612..43e8e3cae60c 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -387,7 +387,8 @@ static void ql_init_fw_done(struct ql_adapter *qdev, struct mbox_params *mbcp)
  *  This can get called iteratively from the mpi_work thread
  *  when events arrive via an interrupt.
  *  It also gets called when a mailbox command is polling for
- *  it's completion. */
+ *  it's completion.
+ */
 static int ql_mpi_handler(struct ql_adapter *qdev, struct mbox_params *mbcp)
 {
 	int status;
@@ -517,7 +518,7 @@ static int ql_mpi_handler(struct ql_adapter *qdev, struct mbox_params *mbcp)
 	 * changed when a mailbox command is waiting
 	 * for a response and an AEN arrives and
 	 * is handled.
-	 * */
+	 */
 	mbcp->out_count = orig_count;
 	return status;
 }
@@ -552,7 +553,8 @@ static int ql_mailbox_command(struct ql_adapter *qdev, struct mbox_params *mbcp)
 	 * here because some AEN might arrive while
 	 * we're waiting for the mailbox command to
 	 * complete. If more than 5 seconds expire we can
-	 * assume something is wrong. */
+	 * assume something is wrong.
+	 */
 	count = jiffies + HZ * MAILBOX_TIMEOUT;
 	do {
 		/* Wait for the interrupt to come in. */
@@ -1175,7 +1177,7 @@ void ql_mpi_idc_work(struct work_struct *work)
 		/* Signal the resulting link up AEN
 		 * that the frame routing and mac addr
 		 * needs to be set.
-		 * */
+		 */
 		set_bit(QL_CAM_RT_SET, &qdev->flags);
 		/* Do ACK if required */
 		if (timeout) {
-- 
2.17.1

Re: [Outreachy] [PATCH 0/2] staging: qlge: Resolve various warnings reported by checkpatch.pl

[Greg KH]

On Wed, Apr 01, 2020 at 12:21:18PM +0530, Soumyajit Deb wrote:
> This patchset resolves coding style and indentation issues reported by
> checkpatch.pl
> This patchset removes unnecessary blank lines and properly indents the
> multiline comments by shifting the end of multiline comments "*/" to the
> next line to improve code readability and adhere to the uniform coding
> style, all for the same file qlge_mpi.c present under
> drivers/staging/qlge directory.
> 
> Soumyajit Deb (2):
>   staging: qlge: Remove extra blank lines
>   staging: qlge: Properly indent the multiline comments

The subject lines for this patch set are the same as your subject lines
for your other patch set, making it impossible for me to tell which one
to apply and which to ignore.

It seems like you want me to apply both, but with identical subjects,
and the patches doing different things, that feels really odd.

I've dropped all of the patches for this driver now from my review
queue, please make a single patch series for this driver with these
patches, and change the subject lines to be unique.

thanks,

greg k-h