* [PATCH -next] ext4: remove set but not used variable 'es'
@ 2020-04-02 3:39 Jason Yan
2020-04-14 1:56 ` Theodore Y. Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-02 3:39 UTC (permalink / raw)
To: tytso, adilger.kernel, linux-ext4, linux-kernel; +Cc: Jason Yan
Fix the following gcc warning:
fs/ext4/super.c:599:27: warning: variable 'es' set but not used [-Wunused-but-set-variable]
struct ext4_super_block *es;
^~
Fixes: 2ea2fc775321 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
fs/ext4/super.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9728e7b0e84f..0725cb120b77 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -596,7 +596,6 @@ void __ext4_error_file(struct file *file, const char *function,
{
va_list args;
struct va_format vaf;
- struct ext4_super_block *es;
struct inode *inode = file_inode(file);
char pathname[80], *path;
@@ -604,7 +603,6 @@ void __ext4_error_file(struct file *file, const char *function,
return;
trace_ext4_error(inode->i_sb, function, line);
- es = EXT4_SB(inode->i_sb)->s_es;
if (ext4_error_ratelimit(inode->i_sb)) {
path = file_path(file, pathname, sizeof(pathname));
if (IS_ERR(path))
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ext4: remove set but not used variable 'es'
2020-04-02 3:39 [PATCH -next] ext4: remove set but not used variable 'es' Jason Yan
@ 2020-04-14 1:56 ` Theodore Y. Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Y. Ts'o @ 2020-04-14 1:56 UTC (permalink / raw)
To: Jason Yan; +Cc: adilger.kernel, linux-ext4, linux-kernel
On Thu, Apr 02, 2020 at 11:39:39AM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> fs/ext4/super.c:599:27: warning: variable 'es' set but not used [-Wunused-but-set-variable]
> struct ext4_super_block *es;
> ^~
> Fixes: 2ea2fc775321 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-14 1:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 3:39 [PATCH -next] ext4: remove set but not used variable 'es' Jason Yan
2020-04-14 1:56 ` Theodore Y. Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.