All of lore.kernel.org
 help / color / mirror / Atom feed
* [lunn:v5.6-rc5-net-next-cable-test 14/20] drivers/net/phy/phy.c:883 phy_stop() warn: inconsistent indenting
@ 2020-04-06  0:58 kbuild test robot
  0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2020-04-06  0:58 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

tree:   https://github.com/lunn/linux.git v5.6-rc5-net-next-cable-test
head:   4d530d4f0eedfa1955cfa0e472b51bc8f097516c
commit: e7e8b4a9e90fa9fbbba1c0a802779e95a59d6e73 [14/20] net: phy: Put interface into oper testing during cable test

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

smatch warnings:
drivers/net/phy/phy.c:883 phy_stop() warn: inconsistent indenting

vim +883 drivers/net/phy/phy.c

   864	
   865	/**
   866	 * phy_stop - Bring down the PHY link, and stop checking the status
   867	 * @phydev: target phy_device struct
   868	 */
   869	void phy_stop(struct phy_device *phydev)
   870	{
   871		struct net_device *dev = phydev->attached_dev;
   872	
   873		if (!phy_is_started(phydev)) {
   874			WARN(1, "called from state %s\n",
   875			     phy_state_to_str(phydev->state));
   876			return;
   877		}
   878	
   879		mutex_lock(&phydev->lock);
   880	
   881		if (phydev->state == PHY_CABLETEST) {
   882			phy_cable_test_abort(phydev);
 > 883			 netif_testing_off(dev);
   884		}
   885	
   886		if (phydev->sfp_bus)
   887			sfp_upstream_stop(phydev->sfp_bus);
   888	
   889		phydev->state = PHY_HALTED;
   890	
   891		mutex_unlock(&phydev->lock);
   892	
   893		phy_state_machine(&phydev->state_queue.work);
   894		phy_stop_machine(phydev);
   895	
   896		/* Cannot call flush_scheduled_work() here as desired because
   897		 * of rtnl_lock(), but PHY_HALTED shall guarantee irq handler
   898		 * will not reenable interrupts.
   899		 */
   900	}
   901	EXPORT_SYMBOL(phy_stop);
   902	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-04-06  0:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06  0:58 [lunn:v5.6-rc5-net-next-cable-test 14/20] drivers/net/phy/phy.c:883 phy_stop() warn: inconsistent indenting kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.