* [PATCH] ASoC: qcom: common: Silence EPROBE_DEFER messages
@ 2020-04-06 0:36 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-04-06 0:36 UTC (permalink / raw)
To: Patrick Lai, Banajit Goswami, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-kernel, srinivas.kandagatla
The Qualcomm sound card typically depends on several other drivers,
resulting in plenty of noise in the kernel log due to probe deferral.
Silence these errors.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
sound/soc/qcom/common.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c
index 6c20bdd850f3..cb266d7ec03e 100644
--- a/sound/soc/qcom/common.c
+++ b/sound/soc/qcom/common.c
@@ -80,7 +80,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card)
ret = snd_soc_of_get_dai_name(cpu, &link->cpus->dai_name);
if (ret) {
- dev_err(card->dev, "%s: error getting cpu dai name\n", link->name);
+ if (ret != -EPROBE_DEFER)
+ dev_err(card->dev, "%s: error getting cpu dai name", link->name);
goto err;
}
@@ -96,7 +97,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card)
ret = snd_soc_of_get_dai_link_codecs(dev, codec, link);
if (ret < 0) {
- dev_err(card->dev, "%s: codec dai not found\n", link->name);
+ if (ret != -EPROBE_DEFER)
+ dev_err(card->dev, "%s: codec dai not found\n", link->name);
goto err;
}
link->no_pcm = 1;
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ASoC: qcom: common: Silence EPROBE_DEFER messages
@ 2020-04-06 0:36 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-04-06 0:36 UTC (permalink / raw)
To: Patrick Lai, Banajit Goswami, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, srinivas.kandagatla, linux-kernel
The Qualcomm sound card typically depends on several other drivers,
resulting in plenty of noise in the kernel log due to probe deferral.
Silence these errors.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
sound/soc/qcom/common.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c
index 6c20bdd850f3..cb266d7ec03e 100644
--- a/sound/soc/qcom/common.c
+++ b/sound/soc/qcom/common.c
@@ -80,7 +80,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card)
ret = snd_soc_of_get_dai_name(cpu, &link->cpus->dai_name);
if (ret) {
- dev_err(card->dev, "%s: error getting cpu dai name\n", link->name);
+ if (ret != -EPROBE_DEFER)
+ dev_err(card->dev, "%s: error getting cpu dai name", link->name);
goto err;
}
@@ -96,7 +97,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card)
ret = snd_soc_of_get_dai_link_codecs(dev, codec, link);
if (ret < 0) {
- dev_err(card->dev, "%s: codec dai not found\n", link->name);
+ if (ret != -EPROBE_DEFER)
+ dev_err(card->dev, "%s: codec dai not found\n", link->name);
goto err;
}
link->no_pcm = 1;
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: qcom: common: Silence EPROBE_DEFER messages
2020-04-06 0:36 ` Bjorn Andersson
@ 2020-04-06 11:12 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2020-04-06 11:12 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Patrick Lai, Banajit Goswami, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-kernel, srinivas.kandagatla
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Sun, Apr 05, 2020 at 05:36:56PM -0700, Bjorn Andersson wrote:
> The Qualcomm sound card typically depends on several other drivers,
> resulting in plenty of noise in the kernel log due to probe deferral.
> Silence these errors.
This then means that if something is missing a depdenceny it becomes
impossible to tell what the problem is from the logs. Please at most
reduce these to a dev_dbg().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: qcom: common: Silence EPROBE_DEFER messages
@ 2020-04-06 11:12 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2020-04-06 11:12 UTC (permalink / raw)
To: Bjorn Andersson
Cc: alsa-devel, Banajit Goswami, linux-kernel, Patrick Lai,
Takashi Iwai, Liam Girdwood, srinivas.kandagatla
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Sun, Apr 05, 2020 at 05:36:56PM -0700, Bjorn Andersson wrote:
> The Qualcomm sound card typically depends on several other drivers,
> resulting in plenty of noise in the kernel log due to probe deferral.
> Silence these errors.
This then means that if something is missing a depdenceny it becomes
impossible to tell what the problem is from the logs. Please at most
reduce these to a dev_dbg().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-06 11:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 0:36 [PATCH] ASoC: qcom: common: Silence EPROBE_DEFER messages Bjorn Andersson
2020-04-06 0:36 ` Bjorn Andersson
2020-04-06 11:12 ` Mark Brown
2020-04-06 11:12 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.