* [PATCH] mmc: sdhci-sprd: Drop redundant cap flags
@ 2020-04-06 11:37 Ulf Hansson
2020-04-07 1:18 ` Baolin Wang
2020-04-07 5:46 ` Adrian Hunter
0 siblings, 2 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-04-06 11:37 UTC (permalink / raw)
To: linux-mmc, Ulf Hansson, Adrian Hunter; +Cc: Baolin Wang, Chunyan Zhang
The MMC_CAP_ERASE and MMC_CAP_CMD23 flags are already being set in the
common sdhci_setup_host(). This makes it redundant to set them for
sdhci-sprd, so let's drop them.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/mmc/host/sdhci-sprd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
index 2ab42c59e4f8..60c3a4c620f9 100644
--- a/drivers/mmc/host/sdhci-sprd.c
+++ b/drivers/mmc/host/sdhci-sprd.c
@@ -556,7 +556,8 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
sdhci_sprd_voltage_switch;
host->mmc->caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED |
- MMC_CAP_ERASE | MMC_CAP_CMD23 | MMC_CAP_WAIT_WHILE_BUSY;
+ MMC_CAP_WAIT_WHILE_BUSY;
+
ret = mmc_of_parse(host->mmc);
if (ret)
goto pltfm_free;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-sprd: Drop redundant cap flags
2020-04-06 11:37 [PATCH] mmc: sdhci-sprd: Drop redundant cap flags Ulf Hansson
@ 2020-04-07 1:18 ` Baolin Wang
2020-04-07 5:46 ` Adrian Hunter
1 sibling, 0 replies; 3+ messages in thread
From: Baolin Wang @ 2020-04-07 1:18 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-mmc, Adrian Hunter, Chunyan Zhang
On Mon, Apr 6, 2020 at 7:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> The MMC_CAP_ERASE and MMC_CAP_CMD23 flags are already being set in the
> common sdhci_setup_host(). This makes it redundant to set them for
> sdhci-sprd, so let's drop them.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Thanks Ulf.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
> ---
> drivers/mmc/host/sdhci-sprd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 2ab42c59e4f8..60c3a4c620f9 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -556,7 +556,8 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
> sdhci_sprd_voltage_switch;
>
> host->mmc->caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED |
> - MMC_CAP_ERASE | MMC_CAP_CMD23 | MMC_CAP_WAIT_WHILE_BUSY;
> + MMC_CAP_WAIT_WHILE_BUSY;
> +
> ret = mmc_of_parse(host->mmc);
> if (ret)
> goto pltfm_free;
> --
> 2.20.1
>
--
Baolin Wang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-sprd: Drop redundant cap flags
2020-04-06 11:37 [PATCH] mmc: sdhci-sprd: Drop redundant cap flags Ulf Hansson
2020-04-07 1:18 ` Baolin Wang
@ 2020-04-07 5:46 ` Adrian Hunter
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2020-04-07 5:46 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: Baolin Wang, Chunyan Zhang
On 6/04/20 2:37 pm, Ulf Hansson wrote:
> The MMC_CAP_ERASE and MMC_CAP_CMD23 flags are already being set in the
> common sdhci_setup_host(). This makes it redundant to set them for
> sdhci-sprd, so let's drop them.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-sprd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 2ab42c59e4f8..60c3a4c620f9 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -556,7 +556,8 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
> sdhci_sprd_voltage_switch;
>
> host->mmc->caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED |
> - MMC_CAP_ERASE | MMC_CAP_CMD23 | MMC_CAP_WAIT_WHILE_BUSY;
> + MMC_CAP_WAIT_WHILE_BUSY;
> +
> ret = mmc_of_parse(host->mmc);
> if (ret)
> goto pltfm_free;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-07 5:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 11:37 [PATCH] mmc: sdhci-sprd: Drop redundant cap flags Ulf Hansson
2020-04-07 1:18 ` Baolin Wang
2020-04-07 5:46 ` Adrian Hunter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.