From: Kees Cook <keescook@chromium.org>
To: "Frédéric Pierret" <frederic.pierret@qubes-os.org>
Cc: re.emese@gmail.com, kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gcc-common.h: 'params.h' has been dropped in GCC10
Date: Tue, 7 Apr 2020 10:48:12 -0700 [thread overview]
Message-ID: <202004071044.0B773CCB4B@keescook> (raw)
In-Reply-To: <3119553b-49dc-9d88-158f-2665f56f7b5c@qubes-os.org>
On Tue, Apr 07, 2020 at 07:22:55PM +0200, Frédéric Pierret wrote:
>
>
> On 2020-04-07 18:45, Kees Cook wrote:
> >
> > Hi! Thanks for the patch. I don't think this is a hack: it's the right
> > thing to do here, yes? GCC 10 includes this helper in gimple.h, so we
> > can ifdef it out in gcc-common.h.
> >
> > -Kees
> Hi Kees,
> Thank you very much for your comment. Would you like me to rephrase the commit including your comment too? "Hacky" mostly meaning humble modification from my point of view :)
Heh, no worries. I've just reproduced the failure you found with gcc 10,
and I've updated your commit log (and added -Wno-format-diag to the plug
builds). Here's what I've got in my tree now:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/gcc-plugins&id=dda632f1bc6da784baab8069e26547e3f4144dbe
Thanks for the patch!
-Kees
--
Kees Cook
prev parent reply other threads:[~2020-04-07 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 11:32 [PATCH] gcc-common.h: 'params.h' has been dropped in GCC10 Frédéric Pierret (fepitre)
2020-04-07 16:45 ` Kees Cook
2020-04-07 17:22 ` Frédéric Pierret
2020-04-07 17:48 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004071044.0B773CCB4B@keescook \
--to=keescook@chromium.org \
--cc=frederic.pierret@qubes-os.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=re.emese@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.