All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Frédéric Pierret" <frederic.pierret@qubes-os.org>
To: Kees Cook <keescook@chromium.org>
Cc: re.emese@gmail.com, kernel-hardening@lists.openwall.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gcc-common.h: 'params.h' has been dropped in GCC10
Date: Tue, 7 Apr 2020 19:22:55 +0200	[thread overview]
Message-ID: <3119553b-49dc-9d88-158f-2665f56f7b5c@qubes-os.org> (raw)
In-Reply-To: <202004070945.D6E095F7@keescook>


[-- Attachment #1.1: Type: text/plain, Size: 461 bytes --]



On 2020-04-07 18:45, Kees Cook wrote:
> 
> Hi! Thanks for the patch. I don't think this is a hack: it's the right
> thing to do here, yes? GCC 10 includes this helper in gimple.h, so we
> can ifdef it out in gcc-common.h.
> 
> -Kees
Hi Kees,
Thank you very much for your comment. Would you like me to rephrase the commit including your comment too? "Hacky" mostly meaning humble modification from my point of view :)

Best regards,
Frédéric


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-04-07 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 11:32 [PATCH] gcc-common.h: 'params.h' has been dropped in GCC10 Frédéric Pierret (fepitre)
2020-04-07 16:45 ` Kees Cook
2020-04-07 17:22   ` Frédéric Pierret [this message]
2020-04-07 17:48     ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3119553b-49dc-9d88-158f-2665f56f7b5c@qubes-os.org \
    --to=frederic.pierret@qubes-os.org \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=re.emese@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.