* Coverity: btusb_work(): Null pointer dereferences
@ 2020-04-06 15:49 coverity-bot
2020-04-07 10:54 ` Narasimman, Sathish
0 siblings, 1 reply; 4+ messages in thread
From: coverity-bot @ 2020-04-06 15:49 UTC (permalink / raw)
To: Sathish Narasimman
Cc: Marcel Holtmann, Chethan T N, kbuild test robot, Amit K Bag,
Hsin-Yu Chao, Johan Hedberg, Gustavo A. R. Silva, linux-next
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20200406 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints")
Coverity reported the following:
*** CID 1492498: Null pointer dereferences (FORWARD_NULL)
/drivers/bluetooth/btusb.c: 1665 in btusb_work()
1659 }
1660 } else if (data->air_mode == HCI_NOTIFY_ENABLE_SCO_TRANSP) {
1661
1662 data->usb_alt6_packet_flow = true;
1663
1664 /* Check if Alt 6 is supported for Transparent audio */
vvv CID 1492498: Null pointer dereferences (FORWARD_NULL)
vvv Passing "data" to "btusb_find_altsetting", which dereferences null "data->isoc".
1665 if (btusb_find_altsetting(data, 6))
1666 new_alts = 6;
1667 else
1668 bt_dev_err(hdev, "Device does not support ALT setting 6");
1669 }
1670
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1492498 ("Null pointer dereferences")
Fixes: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: Coverity: btusb_work(): Null pointer dereferences 2020-04-06 15:49 Coverity: btusb_work(): Null pointer dereferences coverity-bot @ 2020-04-07 10:54 ` Narasimman, Sathish 2020-04-07 18:14 ` Kees Cook 0 siblings, 1 reply; 4+ messages in thread From: Narasimman, Sathish @ 2020-04-07 10:54 UTC (permalink / raw) To: coverity-bot Cc: Marcel Holtmann, Tumkur Narayan, Chethan, lkp, Bag, Amit K, Hsin-Yu Chao, Hedberg, Johan, Gustavo A. R. Silva, linux-next Hi I think this is False Positive. In the function btusb_probe the memory allocation is happened and verified for NULL. I don't this so checking for NULL evey time is required. Sample code snip In function "btusb_probe" { data = devm_kzalloc(&intf->dev, sizeof(*data), GFP_KERNEL); if (!data) return -ENOMEM; .... INIT_WORK(&data->work, btusb_work); } Regards Sathish N -----Original Message----- From: coverity-bot <keescook@chromium.org> Sent: Monday, April 6, 2020 9:20 PM To: Narasimman, Sathish <sathish.narasimman@intel.com> Cc: Marcel Holtmann <marcel@holtmann.org>; Tumkur Narayan, Chethan <chethan.tumkur.narayan@intel.com>; lkp <lkp@intel.com>; Bag, Amit K <amit.k.bag@intel.com>; Hsin-Yu Chao <hychao@chromium.org>; Hedberg, Johan <johan.hedberg@intel.com>; Gustavo A. R. Silva <gustavo@embeddedor.com>; linux-next@vger.kernel.org Subject: Coverity: btusb_work(): Null pointer dereferences Hello! This is an experimental automated report about issues detected by Coverity from a scan of next-20200406 as part of the linux-next weekly scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints") Coverity reported the following: *** CID 1492498: Null pointer dereferences (FORWARD_NULL) /drivers/bluetooth/btusb.c: 1665 in btusb_work() 1659 } 1660 } else if (data->air_mode == HCI_NOTIFY_ENABLE_SCO_TRANSP) { 1661 1662 data->usb_alt6_packet_flow = true; 1663 1664 /* Check if Alt 6 is supported for Transparent audio */ vvv CID 1492498: Null pointer dereferences (FORWARD_NULL) vvv Passing "data" to "btusb_find_altsetting", which dereferences null "data->isoc". 1665 if (btusb_find_altsetting(data, 6)) 1666 new_alts = 6; 1667 else 1668 bt_dev_err(hdev, "Device does not support ALT setting 6"); 1669 } 1670 If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@chromium.org> Addresses-Coverity-ID: 1492498 ("Null pointer dereferences") Fixes: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints") Thanks for your attention! -- Coverity-bot ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Coverity: btusb_work(): Null pointer dereferences 2020-04-07 10:54 ` Narasimman, Sathish @ 2020-04-07 18:14 ` Kees Cook 2020-04-08 7:38 ` Narasimman, Sathish 0 siblings, 1 reply; 4+ messages in thread From: Kees Cook @ 2020-04-07 18:14 UTC (permalink / raw) To: Narasimman, Sathish Cc: Marcel Holtmann, Tumkur Narayan, Chethan, lkp, Bag, Amit K, Hsin-Yu Chao, Hedberg, Johan, Gustavo A. R. Silva, linux-next On Tue, Apr 07, 2020 at 10:54:22AM +0000, Narasimman, Sathish wrote: > Hi > > I think this is False Positive. > > In the function btusb_probe the memory allocation is happened and verified for NULL. > I don't this so checking for NULL evey time is required. > > Sample code snip > > In function "btusb_probe" > { > data = devm_kzalloc(&intf->dev, sizeof(*data), GFP_KERNEL); > if (!data) > return -ENOMEM; > .... > INIT_WORK(&data->work, btusb_work); > > } This warning is talking about data->isoc, which is checked for NULL in other places before the call to btusb_find_altsetting(), which doesn't check for NULL. -Kees > > > Regards > Sathish N > > -----Original Message----- > From: coverity-bot <keescook@chromium.org> > Sent: Monday, April 6, 2020 9:20 PM > To: Narasimman, Sathish <sathish.narasimman@intel.com> > Cc: Marcel Holtmann <marcel@holtmann.org>; Tumkur Narayan, Chethan <chethan.tumkur.narayan@intel.com>; lkp <lkp@intel.com>; Bag, Amit K <amit.k.bag@intel.com>; Hsin-Yu Chao <hychao@chromium.org>; Hedberg, Johan <johan.hedberg@intel.com>; Gustavo A. R. Silva <gustavo@embeddedor.com>; linux-next@vger.kernel.org > Subject: Coverity: btusb_work(): Null pointer dereferences > > Hello! > > This is an experimental automated report about issues detected by Coverity from a scan of next-20200406 as part of the linux-next weekly scan project: > https://scan.coverity.com/projects/linux-next-weekly-scan > > You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits: > > baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints") > > Coverity reported the following: > > *** CID 1492498: Null pointer dereferences (FORWARD_NULL) > /drivers/bluetooth/btusb.c: 1665 in btusb_work() > 1659 } > 1660 } else if (data->air_mode == HCI_NOTIFY_ENABLE_SCO_TRANSP) { > 1661 > 1662 data->usb_alt6_packet_flow = true; > 1663 > 1664 /* Check if Alt 6 is supported for Transparent audio */ > vvv CID 1492498: Null pointer dereferences (FORWARD_NULL) > vvv Passing "data" to "btusb_find_altsetting", which dereferences null "data->isoc". > 1665 if (btusb_find_altsetting(data, 6)) > 1666 new_alts = 6; > 1667 else > 1668 bt_dev_err(hdev, "Device does not support ALT setting 6"); > 1669 } > 1670 > > If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): > > Reported-by: coverity-bot <keescook+coverity-bot@chromium.org> > Addresses-Coverity-ID: 1492498 ("Null pointer dereferences") > Fixes: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints") > > > Thanks for your attention! > > -- > Coverity-bot -- Kees Cook ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: Coverity: btusb_work(): Null pointer dereferences 2020-04-07 18:14 ` Kees Cook @ 2020-04-08 7:38 ` Narasimman, Sathish 0 siblings, 0 replies; 4+ messages in thread From: Narasimman, Sathish @ 2020-04-08 7:38 UTC (permalink / raw) To: Kees Cook Cc: Marcel Holtmann, Tumkur Narayan, Chethan, lkp, Bag, Amit K, Hsin-Yu Chao, Hedberg, Johan, Gustavo A. R. Silva, linux-next Hi Respective Fix for this updated and merged in Bluetooth-next. Thanks Sathish N -----Original Message----- From: Kees Cook <keescook@chromium.org> Sent: Tuesday, April 7, 2020 11:44 PM To: Narasimman, Sathish <sathish.narasimman@intel.com> Cc: Marcel Holtmann <marcel@holtmann.org>; Tumkur Narayan, Chethan <chethan.tumkur.narayan@intel.com>; lkp <lkp@intel.com>; Bag, Amit K <amit.k.bag@intel.com>; Hsin-Yu Chao <hychao@chromium.org>; Hedberg, Johan <johan.hedberg@intel.com>; Gustavo A. R. Silva <gustavo@embeddedor.com>; linux-next@vger.kernel.org Subject: Re: Coverity: btusb_work(): Null pointer dereferences On Tue, Apr 07, 2020 at 10:54:22AM +0000, Narasimman, Sathish wrote: > Hi > > I think this is False Positive. > > In the function btusb_probe the memory allocation is happened and verified for NULL. > I don't this so checking for NULL evey time is required. > > Sample code snip > > In function "btusb_probe" > { > data = devm_kzalloc(&intf->dev, sizeof(*data), GFP_KERNEL); > if (!data) > return -ENOMEM; > .... > INIT_WORK(&data->work, btusb_work); > > } This warning is talking about data->isoc, which is checked for NULL in other places before the call to btusb_find_altsetting(), which doesn't check for NULL. -Kees > > > Regards > Sathish N > > -----Original Message----- > From: coverity-bot <keescook@chromium.org> > Sent: Monday, April 6, 2020 9:20 PM > To: Narasimman, Sathish <sathish.narasimman@intel.com> > Cc: Marcel Holtmann <marcel@holtmann.org>; Tumkur Narayan, Chethan > <chethan.tumkur.narayan@intel.com>; lkp <lkp@intel.com>; Bag, Amit K > <amit.k.bag@intel.com>; Hsin-Yu Chao <hychao@chromium.org>; Hedberg, > Johan <johan.hedberg@intel.com>; Gustavo A. R. Silva > <gustavo@embeddedor.com>; linux-next@vger.kernel.org > Subject: Coverity: btusb_work(): Null pointer dereferences > > Hello! > > This is an experimental automated report about issues detected by Coverity from a scan of next-20200406 as part of the linux-next weekly scan project: > https://scan.coverity.com/projects/linux-next-weekly-scan > > You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits: > > baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB > Endpoints") > > Coverity reported the following: > > *** CID 1492498: Null pointer dereferences (FORWARD_NULL) > /drivers/bluetooth/btusb.c: 1665 in btusb_work() > 1659 } > 1660 } else if (data->air_mode == HCI_NOTIFY_ENABLE_SCO_TRANSP) { > 1661 > 1662 data->usb_alt6_packet_flow = true; > 1663 > 1664 /* Check if Alt 6 is supported for Transparent audio */ > vvv CID 1492498: Null pointer dereferences (FORWARD_NULL) > vvv Passing "data" to "btusb_find_altsetting", which dereferences null "data->isoc". > 1665 if (btusb_find_altsetting(data, 6)) > 1666 new_alts = 6; > 1667 else > 1668 bt_dev_err(hdev, "Device does not support ALT setting 6"); > 1669 } > 1670 > > If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): > > Reported-by: coverity-bot <keescook+coverity-bot@chromium.org> > Addresses-Coverity-ID: 1492498 ("Null pointer dereferences") > Fixes: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB > Endpoints") > > > Thanks for your attention! > > -- > Coverity-bot -- Kees Cook ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-08 7:38 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-04-06 15:49 Coverity: btusb_work(): Null pointer dereferences coverity-bot 2020-04-07 10:54 ` Narasimman, Sathish 2020-04-07 18:14 ` Kees Cook 2020-04-08 7:38 ` Narasimman, Sathish
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.