* [PATCH] mmc: s3cmci: Drop redundant code in s3cmci_setup_data()
@ 2020-04-07 14:39 Ulf Hansson
2020-04-09 12:10 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Ulf Hansson @ 2020-04-07 14:39 UTC (permalink / raw)
To: linux-mmc, Ulf Hansson; +Cc: Ben Dooks, Krzysztof Kozlowski, Kukjin Kim
The in-parameter struct mmc_data *data is never NULL, because the caller
always provides a valid pointer. Hence drop the corresponding redundant
code.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/mmc/host/s3cmci.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index 1e616ae56b13..444b2769ae2c 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -958,13 +958,6 @@ static int s3cmci_setup_data(struct s3cmci_host *host, struct mmc_data *data)
{
u32 dcon, imsk, stoptries = 3;
- /* write DCON register */
-
- if (!data) {
- writel(0, host->base + S3C2410_SDIDCON);
- return 0;
- }
-
if ((data->blksz & 3) != 0) {
/* We cannot deal with unaligned blocks with more than
* one block being transferred. */
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: s3cmci: Drop redundant code in s3cmci_setup_data()
2020-04-07 14:39 [PATCH] mmc: s3cmci: Drop redundant code in s3cmci_setup_data() Ulf Hansson
@ 2020-04-09 12:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-04-09 12:10 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-mmc, Ben Dooks, Kukjin Kim
On Tue, Apr 07, 2020 at 04:39:03PM +0200, Ulf Hansson wrote:
> The in-parameter struct mmc_data *data is never NULL, because the caller
> always provides a valid pointer. Hence drop the corresponding redundant
> code.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/mmc/host/s3cmci.c | 7 -------
> 1 file changed, 7 deletions(-)
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-09 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 14:39 [PATCH] mmc: s3cmci: Drop redundant code in s3cmci_setup_data() Ulf Hansson
2020-04-09 12:10 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.