[PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules

[PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules

[Vadym Kochan]

Allow to add/del remap window by external modules at runtime.

Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
---
 drivers/bus/mvebu-mbus.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 5b2a11a88951..3b443748a469 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -914,6 +914,7 @@ int mvebu_mbus_add_window_remap_by_id(unsigned int target,
 
 	return mvebu_mbus_alloc_window(s, base, size, remap, target, attribute);
 }
+EXPORT_SYMBOL_GPL(mvebu_mbus_add_window_remap_by_id);
 
 int mvebu_mbus_add_window_by_id(unsigned int target, unsigned int attribute,
 				phys_addr_t base, size_t size)
@@ -933,6 +934,7 @@ int mvebu_mbus_del_window(phys_addr_t base, size_t size)
 	mvebu_mbus_disable_window(&mbus_state, win);
 	return 0;
 }
+EXPORT_SYMBOL_GPL(mvebu_mbus_del_window);
 
 void mvebu_mbus_get_pcie_mem_aperture(struct resource *res)
 {
-- 
2.17.1

Re: [PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules

[Christoph Hellwig]

On Tue, Mar 24, 2020 at 09:06:23PM +0200, Vadym Kochan wrote:
> Allow to add/del remap window by external modules at runtime.

Please send this together with your driver submission.

Re: [PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules

[Vadym Kochan]

Hi Christoph,

On Wed, Mar 25, 2020 at 06:58:01AM -0700, Christoph Hellwig wrote:
> On Tue, Mar 24, 2020 at 09:06:23PM +0200, Vadym Kochan wrote:
> > Allow to add/del remap window by external modules at runtime.
> 
> Please send this together with your driver submission.

The driver itself is just servicing user process to configure io
windows via ioctl, so I think it is not so useful ?

Thanks,
Vadym Kochan

Re: [PATCH] bus: mbus: export mvebu_mbus_{add,del}_window for modules

[Christoph Hellwig]

On Tue, Apr 07, 2020 at 06:12:19PM +0300, Vadym Kochan wrote:
> Hi Christoph,
> 
> On Wed, Mar 25, 2020 at 06:58:01AM -0700, Christoph Hellwig wrote:
> > On Tue, Mar 24, 2020 at 09:06:23PM +0200, Vadym Kochan wrote:
> > > Allow to add/del remap window by external modules at runtime.
> > 
> > Please send this together with your driver submission.
> 
> The driver itself is just servicing user process to configure io
> windows via ioctl, so I think it is not so useful ?

If you want the export in mainline your driver needs to be as well.