From: Christoph Hellwig <hch@lst.de>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org, Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-debug: fix displaying of dma allocation type
Date: Wed, 8 Apr 2020 21:16:44 +0200 [thread overview]
Message-ID: <20200408191644.GA12239@lst.de> (raw)
In-Reply-To: <ccd0cca4-ca89-3ecd-90d5-66e5e4090f41@ti.com>
On Wed, Apr 08, 2020 at 10:13:55PM +0300, Grygorii Strashko wrote:
>>> -static const char *type2name[5] = { "single", "page",
>>> +static const char *type2name[5] = { "single",
>>> "scather-gather", "coherent",
>>> "resource" };
>>
>> To make sure this doesn't happen anymore, can you switch to
>> named initializers?
>>
>
> Just to clarify.
> Do you mean
> [dma_debug_coherent] = "coherent",
> ?
Yes.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] dma-debug: fix displaying of dma allocation type
Date: Wed, 8 Apr 2020 21:16:44 +0200 [thread overview]
Message-ID: <20200408191644.GA12239@lst.de> (raw)
In-Reply-To: <ccd0cca4-ca89-3ecd-90d5-66e5e4090f41@ti.com>
On Wed, Apr 08, 2020 at 10:13:55PM +0300, Grygorii Strashko wrote:
>>> -static const char *type2name[5] = { "single", "page",
>>> +static const char *type2name[5] = { "single",
>>> "scather-gather", "coherent",
>>> "resource" };
>>
>> To make sure this doesn't happen anymore, can you switch to
>> named initializers?
>>
>
> Just to clarify.
> Do you mean
> [dma_debug_coherent] = "coherent",
> ?
Yes.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-04-08 19:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 18:48 [PATCH] dma-debug: fix displaying of dma allocation type Grygorii Strashko
2020-04-08 18:48 ` Grygorii Strashko via iommu
2020-04-08 18:49 ` Christoph Hellwig
2020-04-08 18:49 ` Christoph Hellwig
2020-04-08 19:13 ` Grygorii Strashko
2020-04-08 19:13 ` Grygorii Strashko via iommu
2020-04-08 19:16 ` Christoph Hellwig [this message]
2020-04-08 19:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408191644.GA12239@lst.de \
--to=hch@lst.de \
--cc=grygorii.strashko@ti.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nsekhar@ti.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.