[chrome-os:chromeos-5.4 41/42] drivers/extcon/extcon-tcss-cros-ec.c:532: undefined reference to `cros_usbpd_unregister_notify'

[chrome-os:chromeos-5.4 41/42] drivers/extcon/extcon-tcss-cros-ec.c:532: undefined reference to `cros_usbpd_unregister_notify'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 4068 bytes --]

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head:   ff2563dc8815082d0417f1c1b57fd85d62cdb2bc
commit: d7e2f3997581e202e414caec61385db234927e81 [41/42] CHROMIUM: extcon: Use PD-notifier
config: i386-randconfig-d002-20200408 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        git checkout d7e2f3997581e202e414caec61385db234927e81
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/extcon/extcon-tcss-cros-ec.o: in function `cros_ec_tcss_remove':
>> drivers/extcon/extcon-tcss-cros-ec.c:532: undefined reference to `cros_usbpd_unregister_notify'
   ld: drivers/extcon/extcon-tcss-cros-ec.o: in function `cros_ec_tcss_probe':
>> drivers/extcon/extcon-tcss-cros-ec.c:585: undefined reference to `cros_usbpd_register_notify'
>> ld: drivers/extcon/extcon-tcss-cros-ec.c:613: undefined reference to `cros_usbpd_unregister_notify'

vim +532 drivers/extcon/extcon-tcss-cros-ec.c

   527	
   528	static int cros_ec_tcss_remove(struct platform_device *pdev)
   529	{
   530		struct cros_ec_tcss_info *info = platform_get_drvdata(pdev);
   531	
 > 532		cros_usbpd_unregister_notify(&info->notifier);
   533		cancel_work_sync(&info->bh_work);
   534		mutex_destroy(&info->lock);
   535	
   536		return 0;
   537	}
   538	
   539	static int cros_ec_tcss_probe(struct platform_device *pdev)
   540	{
   541		struct cros_ec_tcss_info *info;
   542		struct cros_ec_device *ec;
   543		struct device *dev;
   544		int ret;
   545		u8 i;
   546	
   547		if (!pdev || !pdev->dev.parent)
   548			return -ENODEV;
   549	
   550		ec = dev_get_drvdata(pdev->dev.parent);
   551		dev = &pdev->dev;
   552	
   553		if (!ec || !dev)
   554			return -ENODEV;
   555	
   556		info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL);
   557		if (!info)
   558			return -ENOMEM;
   559	
   560		info->ec = ec;
   561		info->dev = dev;
   562	
   563		info->scu = devm_intel_scu_ipc_dev_get(dev);
   564		if (!info->scu)
   565			return -EPROBE_DEFER;
   566	
   567		ret = cros_ec_pd_get_num_ports(info);
   568		if (ret < 0) {
   569			dev_err(dev, "failed getting number of ports! ret = %d\n", ret);
   570			return -ENODEV;
   571		}
   572	
   573		info->tcss = devm_kzalloc(dev, sizeof(*info->tcss) * info->num_ports,
   574					  GFP_KERNEL);
   575		if (!info->tcss)
   576			return -ENOMEM;
   577	
   578		platform_set_drvdata(pdev, info);
   579	
   580		mutex_init(&info->lock);
   581		INIT_WORK(&info->bh_work, cros_ec_tcss_bh_work);
   582	
   583		/* Get Port detection events from the EC */
   584		info->notifier.notifier_call = cros_ec_tcss_event;
 > 585		ret = cros_usbpd_register_notify(&info->notifier);
   586		if (ret < 0) {
   587			dev_err(dev, "failed to register notifier\n");
   588			goto destroy_mutex;
   589		}
   590	
   591		mutex_lock(&info->lock);
   592		/* Perform initial detection */
   593		for (i = 0; i < info->num_ports; i++) {
   594			ret = cros_ec_pd_get_port_info(info, i);
   595			if (ret < 0) {
   596				dev_err(dev, "failed getting USB port info! ret = %d\n",
   597					ret);
   598				goto remove_tcss;
   599			}
   600	
   601			ret = cros_ec_tcss_detect_cable(info, true, i);
   602			if (ret < 0) {
   603				dev_err(dev, "failed to detect initial cable state\n");
   604				goto remove_tcss;
   605			}
   606		}
   607		mutex_unlock(&info->lock);
   608	
   609	return 0;
   610	
   611	remove_tcss:
   612		mutex_unlock(&info->lock);
 > 613		cros_usbpd_unregister_notify(&info->notifier);
   614		cancel_work_sync(&info->bh_work);
   615	destroy_mutex:
   616		mutex_destroy(&info->lock);
   617	
   618		return ret;
   619	}
   620	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31037 bytes --]