All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/legacy: Fix type for drm_local_map.offset
Date: Thu, 9 Apr 2020 09:07:34 +0200	[thread overview]
Message-ID: <20200409070734.GP3456981@phenom.ffwll.local> (raw)
In-Reply-To: <CAKMK7uE2t=z71dtJitmoKwrrZxgciEDRrNPMQ1FyiLO7s-VKag@mail.gmail.com>

On Fri, Apr 03, 2020 at 07:16:28PM +0200, Daniel Vetter wrote:
> On Fri, Apr 3, 2020 at 7:14 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > On Fri, Apr 3, 2020 at 1:29 AM Daniel Vetter <daniel@ffwll.ch> wrote:
> > >
> > > > Tested-by: Nathan Chancellor <natechancellor@gmail.com> # build
> > >
> > > This works too, missed it when replying to Linus
> > >
> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > >
> > > Linus I guess this one is better, but like I explained it really
> > > doesn't matter what we do with drm legacy code, it's a horror show
> > > that should be disabled on all modern distros anyway. We just keep it
> > > because of "never break old uapi".
> >
> > Ok, That patch from Chris looks fine to me too.
> >
> > dma_addr_t and resource_size_t aren't the same, but at least
> > dma_addr_t should always be the bigger one.
> >
> > And it does look like nothing else ever takes the address of this
> > field, so the ones that might want just the resource_size_t part will
> > at least have enough bits.
> >
> > So I think Chris' patch is the way to go. I'm assuming I'll get it
> > through the normal drm tree channels, this doesn't sound _so_ urgent
> > that I'd need to expedite that patch into my tree and apply it
> > directly.
> 
> Ok, sounds good.
> 
> Chris can you pls push this to drm-misc-next-fixes? That should be
> enough for the pull request train next week.

Ok I applied this now, seems to have fallen through a few cracks. Might
only make it after easter :-/
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/legacy: Fix type for drm_local_map.offset
Date: Thu, 9 Apr 2020 09:07:34 +0200	[thread overview]
Message-ID: <20200409070734.GP3456981@phenom.ffwll.local> (raw)
In-Reply-To: <CAKMK7uE2t=z71dtJitmoKwrrZxgciEDRrNPMQ1FyiLO7s-VKag@mail.gmail.com>

On Fri, Apr 03, 2020 at 07:16:28PM +0200, Daniel Vetter wrote:
> On Fri, Apr 3, 2020 at 7:14 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > On Fri, Apr 3, 2020 at 1:29 AM Daniel Vetter <daniel@ffwll.ch> wrote:
> > >
> > > > Tested-by: Nathan Chancellor <natechancellor@gmail.com> # build
> > >
> > > This works too, missed it when replying to Linus
> > >
> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > >
> > > Linus I guess this one is better, but like I explained it really
> > > doesn't matter what we do with drm legacy code, it's a horror show
> > > that should be disabled on all modern distros anyway. We just keep it
> > > because of "never break old uapi".
> >
> > Ok, That patch from Chris looks fine to me too.
> >
> > dma_addr_t and resource_size_t aren't the same, but at least
> > dma_addr_t should always be the bigger one.
> >
> > And it does look like nothing else ever takes the address of this
> > field, so the ones that might want just the resource_size_t part will
> > at least have enough bits.
> >
> > So I think Chris' patch is the way to go. I'm assuming I'll get it
> > through the normal drm tree channels, this doesn't sound _so_ urgent
> > that I'd need to expedite that patch into my tree and apply it
> > directly.
> 
> Ok, sounds good.
> 
> Chris can you pls push this to drm-misc-next-fixes? That should be
> enough for the pull request train next week.

Ok I applied this now, seems to have fallen through a few cracks. Might
only make it after easter :-/
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-04-09  7:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01  5:50 [git pull] drm for 5.7-rc1 Dave Airlie
2020-04-01  5:50 ` Dave Airlie
2020-04-01  9:22 ` Jani Nikula
2020-04-01  9:22   ` Jani Nikula
2020-04-01 22:35 ` pr-tracker-bot
2020-04-01 22:35   ` pr-tracker-bot
2020-04-02 20:33 ` Nathan Chancellor
2020-04-02 20:33   ` Nathan Chancellor
2020-04-02 20:43   ` Linus Torvalds
2020-04-02 20:43     ` Linus Torvalds
2020-04-03  8:12     ` Daniel Vetter
2020-04-03  8:12       ` Daniel Vetter
2020-04-02 21:59   ` [PATCH] drm/legacy: Fix type for drm_local_map.offset Chris Wilson
2020-04-02 21:59     ` Chris Wilson
2020-04-03  1:34     ` Nathan Chancellor
2020-04-03  1:34       ` Nathan Chancellor
2020-04-03  8:28       ` Daniel Vetter
2020-04-03  8:28         ` Daniel Vetter
2020-04-03 17:14         ` Linus Torvalds
2020-04-03 17:14           ` Linus Torvalds
2020-04-03 17:16           ` Daniel Vetter
2020-04-03 17:16             ` Daniel Vetter
2020-04-09  7:07             ` Daniel Vetter [this message]
2020-04-09  7:07               ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409070734.GP3456981@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.