* [PATCH] scsi: qla1280: make qla1280_firmware_mutex and qla1280_fw_tbl static
@ 2020-04-09 8:49 Jason Yan
2020-04-15 1:42 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-09 8:49 UTC (permalink / raw)
To: mdr, jejb, martin.petersen, linux-scsi, linux-kernel; +Cc: Jason Yan
Fix the following sparse warning:
drivers/scsi/qla1280.c:529:1: warning: symbol 'qla1280_firmware_mutex'
was not declared. Should it be static?
drivers/scsi/qla1280.c:538:15: warning: symbol 'qla1280_fw_tbl' was not
declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/qla1280.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 3337cd341d21..441a45349349 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -526,7 +526,7 @@ static struct pci_device_id qla1280_pci_tbl[] = {
};
MODULE_DEVICE_TABLE(pci, qla1280_pci_tbl);
-DEFINE_MUTEX(qla1280_firmware_mutex);
+static DEFINE_MUTEX(qla1280_firmware_mutex);
struct qla_fw {
char *fwname;
@@ -535,7 +535,7 @@ struct qla_fw {
#define QL_NUM_FW_IMAGES 3
-struct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = {
+static struct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = {
{"qlogic/1040.bin", NULL}, /* image 0 */
{"qlogic/1280.bin", NULL}, /* image 1 */
{"qlogic/12160.bin", NULL}, /* image 2 */
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qla1280: make qla1280_firmware_mutex and qla1280_fw_tbl static
2020-04-09 8:49 [PATCH] scsi: qla1280: make qla1280_firmware_mutex and qla1280_fw_tbl static Jason Yan
@ 2020-04-15 1:42 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-04-15 1:42 UTC (permalink / raw)
To: Jason Yan; +Cc: mdr, jejb, martin.petersen, linux-scsi, linux-kernel
Jason,
> Fix the following sparse warning:
>
> drivers/scsi/qla1280.c:529:1: warning: symbol 'qla1280_firmware_mutex'
> was not declared. Should it be static?
> drivers/scsi/qla1280.c:538:15: warning: symbol 'qla1280_fw_tbl' was not
> declared. Should it be static?
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-15 1:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 8:49 [PATCH] scsi: qla1280: make qla1280_firmware_mutex and qla1280_fw_tbl static Jason Yan
2020-04-15 1:42 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.