* [PATCH] USB: serial: garmin_gps: remove some defined but not used variables
@ 2020-04-09 8:51 Jason Yan
2020-04-22 7:49 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-09 8:51 UTC (permalink / raw)
To: johan, gregkh, linux-usb, linux-kernel; +Cc: Jason Yan
Fix the following gcc warning:
drivers/usb/serial/garmin_gps.c:192:28: warning: ‘PRIVATE_REQ’ defined
but not used [-Wunused-const-variable=]
static unsigned char const PRIVATE_REQ[]
^~~~~~~~~~~
drivers/usb/serial/garmin_gps.c:186:28: warning: ‘GARMIN_STOP_PVT_REQ’
defined but not used [-Wunused-const-variable=]
static unsigned char const GARMIN_STOP_PVT_REQ[]
^~~~~~~~~~~~~~~~~~~
drivers/usb/serial/garmin_gps.c:184:28: warning: ‘GARMIN_START_PVT_REQ’
defined but not used [-Wunused-const-variable=]
static unsigned char const GARMIN_START_PVT_REQ[]
^~~~~~~~~~~~~~~~~~~~
drivers/usb/serial/garmin_gps.c:182:28: warning:
‘GARMIN_APP_LAYER_REPLY’ defined but not used [-Wunused-const-variable=]
static unsigned char const GARMIN_APP_LAYER_REPLY[]
^~~~~~~~~~~~~~~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/usb/serial/garmin_gps.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index ffd984142171..3b39d1e39fbf 100644
--- a/drivers/usb/serial/garmin_gps.c
+++ b/drivers/usb/serial/garmin_gps.c
@@ -179,19 +179,10 @@ static unsigned char const GARMIN_START_SESSION_REPLY[]
= { 0, 0, 0, 0, 6, 0, 0, 0, 4, 0, 0, 0 };
static unsigned char const GARMIN_BULK_IN_AVAIL_REPLY[]
= { 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0 };
-static unsigned char const GARMIN_APP_LAYER_REPLY[]
- = { 0x14, 0, 0, 0 };
-static unsigned char const GARMIN_START_PVT_REQ[]
- = { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 49, 0 };
-static unsigned char const GARMIN_STOP_PVT_REQ[]
- = { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 50, 0 };
static unsigned char const GARMIN_STOP_TRANSFER_REQ[]
= { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 0, 0 };
static unsigned char const GARMIN_STOP_TRANSFER_REQ_V2[]
= { 20, 0, 0, 0, 10, 0, 0, 0, 1, 0, 0, 0, 0 };
-static unsigned char const PRIVATE_REQ[]
- = { 0x4B, 0x6E, 0x10, 0x01, 0xFF, 0, 0, 0, 0xFF, 0, 0, 0 };
-
static const struct usb_device_id id_table[] = {
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] USB: serial: garmin_gps: remove some defined but not used variables
2020-04-09 8:51 [PATCH] USB: serial: garmin_gps: remove some defined but not used variables Jason Yan
@ 2020-04-22 7:49 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2020-04-22 7:49 UTC (permalink / raw)
To: Jason Yan; +Cc: johan, gregkh, linux-usb, linux-kernel
On Thu, Apr 09, 2020 at 04:51:43PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/usb/serial/garmin_gps.c:192:28: warning: ‘PRIVATE_REQ’ defined
> but not used [-Wunused-const-variable=]
> static unsigned char const PRIVATE_REQ[]
> ^~~~~~~~~~~
> drivers/usb/serial/garmin_gps.c:186:28: warning: ‘GARMIN_STOP_PVT_REQ’
> defined but not used [-Wunused-const-variable=]
> static unsigned char const GARMIN_STOP_PVT_REQ[]
> ^~~~~~~~~~~~~~~~~~~
> drivers/usb/serial/garmin_gps.c:184:28: warning: ‘GARMIN_START_PVT_REQ’
> defined but not used [-Wunused-const-variable=]
> static unsigned char const GARMIN_START_PVT_REQ[]
> ^~~~~~~~~~~~~~~~~~~~
> drivers/usb/serial/garmin_gps.c:182:28: warning:
> ‘GARMIN_APP_LAYER_REPLY’ defined but not used [-Wunused-const-variable=]
> static unsigned char const GARMIN_APP_LAYER_REPLY[]
> ^~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
You should mention that this is a W=1 one warning which isn't enabled
by default.
> ---
> drivers/usb/serial/garmin_gps.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
> index ffd984142171..3b39d1e39fbf 100644
> --- a/drivers/usb/serial/garmin_gps.c
> +++ b/drivers/usb/serial/garmin_gps.c
> @@ -179,19 +179,10 @@ static unsigned char const GARMIN_START_SESSION_REPLY[]
> = { 0, 0, 0, 0, 6, 0, 0, 0, 4, 0, 0, 0 };
> static unsigned char const GARMIN_BULK_IN_AVAIL_REPLY[]
> = { 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0 };
> -static unsigned char const GARMIN_APP_LAYER_REPLY[]
> - = { 0x14, 0, 0, 0 };
> -static unsigned char const GARMIN_START_PVT_REQ[]
> - = { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 49, 0 };
> -static unsigned char const GARMIN_STOP_PVT_REQ[]
> - = { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 50, 0 };
> static unsigned char const GARMIN_STOP_TRANSFER_REQ[]
> = { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 0, 0 };
> static unsigned char const GARMIN_STOP_TRANSFER_REQ_V2[]
> = { 20, 0, 0, 0, 10, 0, 0, 0, 1, 0, 0, 0, 0 };
> -static unsigned char const PRIVATE_REQ[]
> - = { 0x4B, 0x6E, 0x10, 0x01, 0xFF, 0, 0, 0, 0xFF, 0, 0, 0 };
> -
I'm reluctant to simply remove these as they document the protocol
without any real downsides besides the W=1 warning.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-22 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 8:51 [PATCH] USB: serial: garmin_gps: remove some defined but not used variables Jason Yan
2020-04-22 7:49 ` Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.