All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Oliver Graute <oliver.graute@gmail.com>
Cc: dmitry.torokhov@gmail.com,
	Oliver Graute <oliver.graute@kococonnector.com>,
	Marco Felsch <m.felsch@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] Input: edt-ft5x06 - fix crash on EDT EP0110M09
Date: Thu, 9 Apr 2020 13:45:01 +0300	[thread overview]
Message-ID: <20200409104501.GW3676135@smile.fi.intel.com> (raw)
In-Reply-To: <1586424425-27038-1-git-send-email-oliver.graute@gmail.com>

On Thu, Apr 09, 2020 at 11:27:01AM +0200, Oliver Graute wrote:
> From: Oliver Graute <oliver.graute@kococonnector.com>
> 
> remove edt_ft5x06_ts_readwrite() call because this result in a stack
> corruption crash on EP011M09

And how it's supposed now to work on the rest of variants?

> [    2.968250] edt_ft5x06 1-0038: 1-0038 supply vcc not found, using dummy regulator
> [    2.991327] input: EP0110M09 as /devices/platform/bus@5a000000/5a820000.i2c/i2c-1/1-0038/input/input0
> [    3.011818] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: edt_ft5x06_ts_probe+0x9e4/0xa98
> [    3.022519] CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 5.6.0-rc1-next-20200214+ #69
> [    3.030261] Hardware name: Advantech iMX8QM DMSSE20 (DT)
> [    3.035583] Workqueue: events deferred_probe_work_func
> [    3.040724] Call trace:
> [    3.043179]  dump_backtrace+0x0/0x1c0
> [    3.046839]  show_stack+0x14/0x20
> [    3.050161]  dump_stack+0xb4/0xfc
> [    3.053477]  panic+0x158/0x320
> [    3.056531]  print_tainted+0x0/0xa8
> [    3.060015]  edt_ft5x06_ts_probe+0x9e4/0xa98
> [    3.064286]  i2c_device_probe+0x2d0/0x2f8

No need to have below attached to the commit message. It's irrelevant.

> [    3.068299]  really_probe+0xd8/0x438
> [    3.071874]  driver_probe_device+0xdc/0x130
> [    3.076064]  __device_attach_driver+0x88/0x108

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-04-09 10:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09  9:27 [PATCH v1] Input: edt-ft5x06 - fix crash on EDT EP0110M09 Oliver Graute
2020-04-09 10:45 ` Andy Shevchenko [this message]
2020-04-09 10:52 ` Marco Felsch
2020-04-09 12:02   ` Oliver Graute
2020-04-09 12:36     ` Andy Shevchenko
2020-04-09 20:36       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409104501.GW3676135@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=oliver.graute@gmail.com \
    --cc=oliver.graute@kococonnector.com \
    --cc=p.zabel@pengutronix.de \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.