From: Oliver Graute <oliver.graute@gmail.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: dmitry.torokhov@gmail.com,
Oliver Graute <oliver.graute@kococonnector.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] Input: edt-ft5x06 - fix crash on EDT EP0110M09
Date: Thu, 9 Apr 2020 14:02:42 +0200 [thread overview]
Message-ID: <20200409120242.GA17410@portage> (raw)
In-Reply-To: <20200409105253.qvezbikpbnrkig52@pengutronix.de>
On 09/04/20, Marco Felsch wrote:
> Hi Oliver,
>
> thanks for your patch.
>
> On 20-04-09 11:27, Oliver Graute wrote:
> > From: Oliver Graute <oliver.graute@kococonnector.com>
>
> ...
>
> > drivers/input/touchscreen/edt-ft5x06.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> > index 06aa8ba0b6d7..6fbc87d041a1 100644
> > --- a/drivers/input/touchscreen/edt-ft5x06.c
> > +++ b/drivers/input/touchscreen/edt-ft5x06.c
> > @@ -819,10 +819,6 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
> > * to have garbage in there
> > */
> > memset(rdbuf, 0, sizeof(rdbuf));
> > - error = edt_ft5x06_ts_readwrite(client, 1, "\xBB",
> > - EDT_NAME_LEN - 1, rdbuf);
> > - if (error)
> > - return error;
>
>
> I don't see how this call can corrupt the stack..
I admit that this is strange. The patch fixed my problems so I posted
it. Still interested in the root-cause.
Best regards,
Oliver
next prev parent reply other threads:[~2020-04-09 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 9:27 [PATCH v1] Input: edt-ft5x06 - fix crash on EDT EP0110M09 Oliver Graute
2020-04-09 10:45 ` Andy Shevchenko
2020-04-09 10:52 ` Marco Felsch
2020-04-09 12:02 ` Oliver Graute [this message]
2020-04-09 12:36 ` Andy Shevchenko
2020-04-09 20:36 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409120242.GA17410@portage \
--to=oliver.graute@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=oliver.graute@kococonnector.com \
--cc=p.zabel@pengutronix.de \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.