All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] coresight: cti: make some symbols static
@ 2020-04-13  8:22 ` Jason Yan
  0 siblings, 0 replies; 4+ messages in thread
From: Jason Yan @ 2020-04-13  8:22 UTC (permalink / raw)
  To: mathieu.poirier, suzuki.poulose, mike.leach, alexander.shishkin,
	linux-arm-kernel, linux-kernel
  Cc: Jason Yan, Hulk Robot

Fix the following sparse warning:

drivers/hwtracing/coresight/coresight-cti.c:22:1: warning: symbol
'ect_net' was not declared. Should it be static?
drivers/hwtracing/coresight/coresight-cti.c:625:32: warning: symbol
'cti_ops_ect' was not declared. Should it be static?
drivers/hwtracing/coresight/coresight-cti.c:630:28: warning: symbol
'cti_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/hwtracing/coresight/coresight-cti.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c
index 9e262f5a85e3..7fc1fc8d7738 100644
--- a/drivers/hwtracing/coresight/coresight-cti.c
+++ b/drivers/hwtracing/coresight/coresight-cti.c
@@ -19,7 +19,7 @@
  */
 
 /* net of CTI devices connected via CTM */
-LIST_HEAD(ect_net);
+static LIST_HEAD(ect_net);
 
 /* protect the list */
 static DEFINE_MUTEX(ect_mutex);
@@ -622,12 +622,12 @@ int cti_disable(struct coresight_device *csdev)
 	return cti_disable_hw(drvdata);
 }
 
-const struct coresight_ops_ect cti_ops_ect = {
+static const struct coresight_ops_ect cti_ops_ect = {
 	.enable = cti_enable,
 	.disable = cti_disable,
 };
 
-const struct coresight_ops cti_ops = {
+static const struct coresight_ops cti_ops = {
 	.ect_ops = &cti_ops_ect,
 };
 
-- 
2.21.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] coresight: cti: make some symbols static
@ 2020-04-13  8:22 ` Jason Yan
  0 siblings, 0 replies; 4+ messages in thread
From: Jason Yan @ 2020-04-13  8:22 UTC (permalink / raw)
  To: mathieu.poirier, suzuki.poulose, mike.leach, alexander.shishkin,
	linux-arm-kernel, linux-kernel
  Cc: Hulk Robot, Jason Yan

Fix the following sparse warning:

drivers/hwtracing/coresight/coresight-cti.c:22:1: warning: symbol
'ect_net' was not declared. Should it be static?
drivers/hwtracing/coresight/coresight-cti.c:625:32: warning: symbol
'cti_ops_ect' was not declared. Should it be static?
drivers/hwtracing/coresight/coresight-cti.c:630:28: warning: symbol
'cti_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/hwtracing/coresight/coresight-cti.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c
index 9e262f5a85e3..7fc1fc8d7738 100644
--- a/drivers/hwtracing/coresight/coresight-cti.c
+++ b/drivers/hwtracing/coresight/coresight-cti.c
@@ -19,7 +19,7 @@
  */
 
 /* net of CTI devices connected via CTM */
-LIST_HEAD(ect_net);
+static LIST_HEAD(ect_net);
 
 /* protect the list */
 static DEFINE_MUTEX(ect_mutex);
@@ -622,12 +622,12 @@ int cti_disable(struct coresight_device *csdev)
 	return cti_disable_hw(drvdata);
 }
 
-const struct coresight_ops_ect cti_ops_ect = {
+static const struct coresight_ops_ect cti_ops_ect = {
 	.enable = cti_enable,
 	.disable = cti_disable,
 };
 
-const struct coresight_ops cti_ops = {
+static const struct coresight_ops cti_ops = {
 	.ect_ops = &cti_ops_ect,
 };
 
-- 
2.21.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] coresight: cti: make some symbols static
  2020-04-13  8:22 ` Jason Yan
@ 2020-04-13 17:58   ` Mathieu Poirier
  -1 siblings, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2020-04-13 17:58 UTC (permalink / raw)
  To: Jason Yan
  Cc: suzuki.poulose, mike.leach, alexander.shishkin, linux-arm-kernel,
	linux-kernel, Hulk Robot

On Mon, Apr 13, 2020 at 04:22:24PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> drivers/hwtracing/coresight/coresight-cti.c:22:1: warning: symbol
> 'ect_net' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-cti.c:625:32: warning: symbol
> 'cti_ops_ect' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-cti.c:630:28: warning: symbol
> 'cti_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/hwtracing/coresight/coresight-cti.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c
> index 9e262f5a85e3..7fc1fc8d7738 100644
> --- a/drivers/hwtracing/coresight/coresight-cti.c
> +++ b/drivers/hwtracing/coresight/coresight-cti.c
> @@ -19,7 +19,7 @@
>   */
>  
>  /* net of CTI devices connected via CTM */
> -LIST_HEAD(ect_net);
> +static LIST_HEAD(ect_net);
>  
>  /* protect the list */
>  static DEFINE_MUTEX(ect_mutex);
> @@ -622,12 +622,12 @@ int cti_disable(struct coresight_device *csdev)
>  	return cti_disable_hw(drvdata);
>  }
>  
> -const struct coresight_ops_ect cti_ops_ect = {
> +static const struct coresight_ops_ect cti_ops_ect = {
>  	.enable = cti_enable,
>  	.disable = cti_disable,
>  };
>  
> -const struct coresight_ops cti_ops = {
> +static const struct coresight_ops cti_ops = {
>  	.ect_ops = &cti_ops_ect,
>  };

Applied - thanks,
Mathieu

>  
> -- 
> 2.21.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] coresight: cti: make some symbols static
@ 2020-04-13 17:58   ` Mathieu Poirier
  0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2020-04-13 17:58 UTC (permalink / raw)
  To: Jason Yan
  Cc: suzuki.poulose, alexander.shishkin, linux-kernel, Hulk Robot,
	linux-arm-kernel, mike.leach

On Mon, Apr 13, 2020 at 04:22:24PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> drivers/hwtracing/coresight/coresight-cti.c:22:1: warning: symbol
> 'ect_net' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-cti.c:625:32: warning: symbol
> 'cti_ops_ect' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-cti.c:630:28: warning: symbol
> 'cti_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/hwtracing/coresight/coresight-cti.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c
> index 9e262f5a85e3..7fc1fc8d7738 100644
> --- a/drivers/hwtracing/coresight/coresight-cti.c
> +++ b/drivers/hwtracing/coresight/coresight-cti.c
> @@ -19,7 +19,7 @@
>   */
>  
>  /* net of CTI devices connected via CTM */
> -LIST_HEAD(ect_net);
> +static LIST_HEAD(ect_net);
>  
>  /* protect the list */
>  static DEFINE_MUTEX(ect_mutex);
> @@ -622,12 +622,12 @@ int cti_disable(struct coresight_device *csdev)
>  	return cti_disable_hw(drvdata);
>  }
>  
> -const struct coresight_ops_ect cti_ops_ect = {
> +static const struct coresight_ops_ect cti_ops_ect = {
>  	.enable = cti_enable,
>  	.disable = cti_disable,
>  };
>  
> -const struct coresight_ops cti_ops = {
> +static const struct coresight_ops cti_ops = {
>  	.ect_ops = &cti_ops_ect,
>  };

Applied - thanks,
Mathieu

>  
> -- 
> 2.21.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-13 17:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13  8:22 [PATCH] coresight: cti: make some symbols static Jason Yan
2020-04-13  8:22 ` Jason Yan
2020-04-13 17:58 ` Mathieu Poirier
2020-04-13 17:58   ` Mathieu Poirier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.