* [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device()
@ 2020-03-26 21:10 ` Wolfram Sang
0 siblings, 0 replies; 11+ messages in thread
From: Wolfram Sang @ 2020-03-26 21:10 UTC (permalink / raw)
To: linux-i2c
Cc: linux-samsung-soc, patches, Russell King, Krzysztof Kozlowski,
linux-kernel, Wolfram Sang, Kukjin Kim, linux-arm-kernel
Move away from the deprecated API and remove printing a stale 'ret'
value.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
index 937d0a83f8fd..34f1baa10c54 100644
--- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
+++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
@@ -405,10 +405,9 @@ static int wlf_gf_module_probe(struct i2c_client *i2c,
gf_mods[i].name, rev + 1);
for (j = 0; j < gf_mods[i].num_i2c_devs; j++) {
- if (!i2c_new_device(i2c->adapter,
- &(gf_mods[i].i2c_devs[j])))
- dev_err(&i2c->dev,
- "Failed to register dev: %d\n", ret);
+ if (IS_ERR(i2c_new_client_device(i2c->adapter,
+ &(gf_mods[i].i2c_devs[j]))))
+ dev_err(&i2c->dev, "Failed to register\n");
}
spi_register_board_info(gf_mods[i].spi_devs,
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device()
@ 2020-03-26 21:10 ` Wolfram Sang
0 siblings, 0 replies; 11+ messages in thread
From: Wolfram Sang @ 2020-03-26 21:10 UTC (permalink / raw)
To: linux-i2c
Cc: linux-samsung-soc, patches, Russell King, Krzysztof Kozlowski,
linux-kernel, Wolfram Sang, Kukjin Kim, linux-arm-kernel
Move away from the deprecated API and remove printing a stale 'ret'
value.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
index 937d0a83f8fd..34f1baa10c54 100644
--- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
+++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
@@ -405,10 +405,9 @@ static int wlf_gf_module_probe(struct i2c_client *i2c,
gf_mods[i].name, rev + 1);
for (j = 0; j < gf_mods[i].num_i2c_devs; j++) {
- if (!i2c_new_device(i2c->adapter,
- &(gf_mods[i].i2c_devs[j])))
- dev_err(&i2c->dev,
- "Failed to register dev: %d\n", ret);
+ if (IS_ERR(i2c_new_client_device(i2c->adapter,
+ &(gf_mods[i].i2c_devs[j]))))
+ dev_err(&i2c->dev, "Failed to register\n");
}
spi_register_board_info(gf_mods[i].spi_devs,
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device()
2020-03-26 21:10 ` Wolfram Sang
(?)
@ 2020-03-27 11:50 ` Charles Keepax
-1 siblings, 0 replies; 11+ messages in thread
From: Charles Keepax @ 2020-03-27 11:50 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Kukjin Kim, Krzysztof Kozlowski, Russell King,
patches, linux-arm-kernel, linux-samsung-soc, linux-kernel
On Thu, Mar 26, 2020 at 10:10:14PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API and remove printing a stale 'ret'
> value.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device()
@ 2020-03-27 11:50 ` Charles Keepax
0 siblings, 0 replies; 11+ messages in thread
From: Charles Keepax @ 2020-03-27 11:50 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-samsung-soc, patches, Russell King, Krzysztof Kozlowski,
linux-kernel, Kukjin Kim, linux-i2c, linux-arm-kernel
On Thu, Mar 26, 2020 at 10:10:14PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API and remove printing a stale 'ret'
> value.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device()
@ 2020-03-27 11:50 ` Charles Keepax
0 siblings, 0 replies; 11+ messages in thread
From: Charles Keepax @ 2020-03-27 11:50 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-samsung-soc, patches, Russell King, Krzysztof Kozlowski,
linux-kernel, Kukjin Kim, linux-i2c, linux-arm-kernel
On Thu, Mar 26, 2020 at 10:10:14PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API and remove printing a stale 'ret'
> value.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device()
2020-03-26 21:10 ` Wolfram Sang
@ 2020-04-13 10:29 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-04-13 10:29 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Kukjin Kim, Russell King, patches, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On Thu, Mar 26, 2020 at 10:10:14PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API and remove printing a stale 'ret'
> value.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> arch/arm/mach-s3c64xx/mach-crag6410-module.c | 7 +++----
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device()
@ 2020-04-13 10:29 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-04-13 10:29 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-samsung-soc, patches, Russell King, linux-kernel,
Kukjin Kim, linux-i2c, linux-arm-kernel
On Thu, Mar 26, 2020 at 10:10:14PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API and remove printing a stale 'ret'
> value.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> arch/arm/mach-s3c64xx/mach-crag6410-module.c | 7 +++----
Thanks, applied.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread