* [PATCH v1] pinctrl: baytrail: Enable pin configuration setting for GPIO chip
@ 2020-03-31 15:24 Andy Shevchenko
2020-04-01 9:46 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-03-31 15:24 UTC (permalink / raw)
To: Mika Westerberg, linux-gpio, Linus Walleij, Hans de Goede; +Cc: Andy Shevchenko
It appears that pin configuration for GPIO chip hasn't been enabled yet
due to absence of ->set_config() callback.
Enable it here for Intel Baytrail.
Fixes: c501d0b149de ("pinctrl: baytrail: Add pin control operations")
Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-baytrail.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index b409642f168d..9b821c9cbd16 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -1286,6 +1286,7 @@ static const struct gpio_chip byt_gpio_chip = {
.direction_output = byt_gpio_direction_output,
.get = byt_gpio_get,
.set = byt_gpio_set,
+ .set_config = gpiochip_generic_config,
.dbg_show = byt_gpio_dbg_show,
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] pinctrl: baytrail: Enable pin configuration setting for GPIO chip
2020-03-31 15:24 [PATCH v1] pinctrl: baytrail: Enable pin configuration setting for GPIO chip Andy Shevchenko
@ 2020-04-01 9:46 ` Mika Westerberg
2020-04-13 10:46 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2020-04-01 9:46 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio, Linus Walleij, Hans de Goede
On Tue, Mar 31, 2020 at 06:24:28PM +0300, Andy Shevchenko wrote:
> It appears that pin configuration for GPIO chip hasn't been enabled yet
> due to absence of ->set_config() callback.
>
> Enable it here for Intel Baytrail.
>
> Fixes: c501d0b149de ("pinctrl: baytrail: Add pin control operations")
> Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] pinctrl: baytrail: Enable pin configuration setting for GPIO chip
2020-04-01 9:46 ` Mika Westerberg
@ 2020-04-13 10:46 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-04-13 10:46 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-gpio, Linus Walleij, Hans de Goede
On Wed, Apr 01, 2020 at 12:46:20PM +0300, Mika Westerberg wrote:
> On Tue, Mar 31, 2020 at 06:24:28PM +0300, Andy Shevchenko wrote:
> > It appears that pin configuration for GPIO chip hasn't been enabled yet
> > due to absence of ->set_config() callback.
> >
> > Enable it here for Intel Baytrail.
> >
> > Fixes: c501d0b149de ("pinctrl: baytrail: Add pin control operations")
> > Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Pushed to fixes, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-13 10:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31 15:24 [PATCH v1] pinctrl: baytrail: Enable pin configuration setting for GPIO chip Andy Shevchenko
2020-04-01 9:46 ` Mika Westerberg
2020-04-13 10:46 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.