All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm/userfaultfd: Disable userfaultfd-wp on x86_32
@ 2020-04-13 14:16 Peter Xu
  2020-04-13 18:35 ` Andrea Arcangeli
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Xu @ 2020-04-13 14:16 UTC (permalink / raw)
  To: linux-kernel, linux-mm
  Cc: peterx, Andrew Morton, Andrea Arcangeli, Hillf Danton,
	Naresh Kamboju, kernel test robot

Userfaultfd-wp is not yet working on 32bit hosts, but it's
accidentally enabled previously.  Disable it.

Fixes: 5a281062af1d ("userfaultfd: wp: add WP pagetable tracking to x86")
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Hillf Danton <hdanton@sina.com>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Reported-by: kernel test robot <lkp@intel.com>
Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 8d078642b4be..7a7d2db366a3 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -149,7 +149,7 @@ config X86
 	select HAVE_ARCH_TRACEHOOK
 	select HAVE_ARCH_TRANSPARENT_HUGEPAGE
 	select HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD if X86_64
-	select HAVE_ARCH_USERFAULTFD_WP		if USERFAULTFD
+	select HAVE_ARCH_USERFAULTFD_WP         if X86_64 && USERFAULTFD
 	select HAVE_ARCH_VMAP_STACK		if X86_64
 	select HAVE_ARCH_WITHIN_STACK_FRAMES
 	select HAVE_ASM_MODVERSIONS
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm/userfaultfd: Disable userfaultfd-wp on x86_32
  2020-04-13 14:16 [PATCH] mm/userfaultfd: Disable userfaultfd-wp on x86_32 Peter Xu
@ 2020-04-13 18:35 ` Andrea Arcangeli
  0 siblings, 0 replies; 2+ messages in thread
From: Andrea Arcangeli @ 2020-04-13 18:35 UTC (permalink / raw)
  To: Peter Xu
  Cc: linux-kernel, linux-mm, Andrew Morton, Hillf Danton,
	Naresh Kamboju, kernel test robot

On Mon, Apr 13, 2020 at 10:16:08AM -0400, Peter Xu wrote:
> Userfaultfd-wp is not yet working on 32bit hosts, but it's
> accidentally enabled previously.  Disable it.
> 
> Fixes: 5a281062af1d ("userfaultfd: wp: add WP pagetable tracking to x86")
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Hillf Danton <hdanton@sina.com>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  arch/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>

Thanks,
Andrea


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-13 18:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 14:16 [PATCH] mm/userfaultfd: Disable userfaultfd-wp on x86_32 Peter Xu
2020-04-13 18:35 ` Andrea Arcangeli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.