* [PATCH] power: supply: bq24257_charger: Replace depends on REGMAP_I2C with select
@ 2020-04-13 14:10 Enric Balletbo i Serra
2020-04-13 15:34 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Enric Balletbo i Serra @ 2020-04-13 14:10 UTC (permalink / raw)
To: linux-kernel; +Cc: Collabora Kernel ML, Sebastian Reichel, linux-pm
regmap is a library function that gets selected by drivers that need
it. No driver modules should depend on it. Depending on REGMAP_I2C makes
this driver only build if another driver already selected REGMAP_I2C,
as the symbol can't be selected through the menu kernel configuration.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/power/supply/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
index f3424fdce341..d37ec0d03237 100644
--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -577,7 +577,7 @@ config CHARGER_BQ24257
tristate "TI BQ24250/24251/24257 battery charger driver"
depends on I2C
depends on GPIOLIB || COMPILE_TEST
- depends on REGMAP_I2C
+ select REGMAP_I2C
help
Say Y to enable support for the TI BQ24250, BQ24251, and BQ24257 battery
chargers.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: supply: bq24257_charger: Replace depends on REGMAP_I2C with select
2020-04-13 14:10 [PATCH] power: supply: bq24257_charger: Replace depends on REGMAP_I2C with select Enric Balletbo i Serra
@ 2020-04-13 15:34 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2020-04-13 15:34 UTC (permalink / raw)
To: Enric Balletbo i Serra; +Cc: linux-kernel, Collabora Kernel ML, linux-pm
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
Hi,
On Mon, Apr 13, 2020 at 04:10:51PM +0200, Enric Balletbo i Serra wrote:
> regmap is a library function that gets selected by drivers that need
> it. No driver modules should depend on it. Depending on REGMAP_I2C makes
> this driver only build if another driver already selected REGMAP_I2C,
> as the symbol can't be selected through the menu kernel configuration.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index f3424fdce341..d37ec0d03237 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -577,7 +577,7 @@ config CHARGER_BQ24257
> tristate "TI BQ24250/24251/24257 battery charger driver"
> depends on I2C
> depends on GPIOLIB || COMPILE_TEST
> - depends on REGMAP_I2C
> + select REGMAP_I2C
> help
> Say Y to enable support for the TI BQ24250, BQ24251, and BQ24257 battery
> chargers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-13 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 14:10 [PATCH] power: supply: bq24257_charger: Replace depends on REGMAP_I2C with select Enric Balletbo i Serra
2020-04-13 15:34 ` Sebastian Reichel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.