All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	Christoph Hellwig <hch@infradead.org>,
	Joerg Roedel <joro@8bytes.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	"Raj, Ashok" <ashok.raj@intel.com>
Subject: Re: [PATCH v2 1/3] iommu/uapi: Define uapi version and capabilities
Date: Tue, 14 Apr 2020 01:11:07 -0700	[thread overview]
Message-ID: <20200414081107.GA7315@infradead.org> (raw)
In-Reply-To: <20200413134157.395981a6@jacob-builder>

On Mon, Apr 13, 2020 at 01:41:57PM -0700, Jacob Pan wrote:
> Hi All,
> 
> Just a gentle reminder, any feedback on the options I listed below? New
> ideas will be even better.
> 
> Christoph, does the explanation make sense to you? We do have the
> capability/flag based scheme for IOMMU API extension, the version is
> mainly used for size lookup. Compatibility checking is another use of
> the version, it makes checking easy when a vIOMMU is launched.

No.  If you truely need different versions use different ioctl
identifiers.  If it really is just the size pass the size and not a
version.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	"Raj, Ashok" <ashok.raj@intel.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 1/3] iommu/uapi: Define uapi version and capabilities
Date: Tue, 14 Apr 2020 01:11:07 -0700	[thread overview]
Message-ID: <20200414081107.GA7315@infradead.org> (raw)
In-Reply-To: <20200413134157.395981a6@jacob-builder>

On Mon, Apr 13, 2020 at 01:41:57PM -0700, Jacob Pan wrote:
> Hi All,
> 
> Just a gentle reminder, any feedback on the options I listed below? New
> ideas will be even better.
> 
> Christoph, does the explanation make sense to you? We do have the
> capability/flag based scheme for IOMMU API extension, the version is
> mainly used for size lookup. Compatibility checking is another use of
> the version, it makes checking easy when a vIOMMU is launched.

No.  If you truely need different versions use different ioctl
identifiers.  If it really is just the size pass the size and not a
version.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  parent reply	other threads:[~2020-04-14  8:11 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 23:17 [PATCH v2 0/3] IOMMU user API enhancement Jacob Pan
2020-03-25 23:17 ` Jacob Pan
2020-03-25 23:17 ` [PATCH v2 1/3] iommu/uapi: Define uapi version and capabilities Jacob Pan
2020-03-25 23:17   ` Jacob Pan
2020-03-26  9:23   ` Christoph Hellwig
2020-03-26  9:23     ` Christoph Hellwig
2020-03-26 16:44     ` Jacob Pan
2020-03-26 16:44       ` Jacob Pan
2020-03-27  2:49       ` Tian, Kevin
2020-03-27  2:49         ` Tian, Kevin
2020-03-27  7:47         ` Christoph Hellwig
2020-03-27  7:47           ` Christoph Hellwig
2020-03-27 23:53           ` Jacob Pan
2020-03-27 23:53             ` Jacob Pan
2020-03-30  5:40             ` Tian, Kevin
2020-03-30  5:40               ` Tian, Kevin
2020-03-30 16:07               ` Jacob Pan
2020-03-30 16:07                 ` Jacob Pan
2020-03-31  6:06                 ` Tian, Kevin
2020-03-31  6:06                   ` Tian, Kevin
2020-03-31 15:54                   ` Jacob Pan
2020-03-31 15:54                     ` Jacob Pan
2020-04-01  5:32                     ` Tian, Kevin
2020-04-01  5:32                       ` Tian, Kevin
2020-04-02 18:36                       ` Jacob Pan
2020-04-02 18:36                         ` Jacob Pan
2020-04-13 20:41                         ` Jacob Pan
2020-04-13 20:41                           ` Jacob Pan
2020-04-13 22:21                           ` Alex Williamson
2020-04-13 22:21                             ` Alex Williamson
2020-04-14  5:05                             ` Jacob Pan
2020-04-14  5:05                               ` Jacob Pan
2020-04-14 16:13                               ` Alex Williamson
2020-04-14 16:13                                 ` Alex Williamson
2020-04-14 17:13                                 ` Jacob Pan
2020-04-14 17:13                                   ` Jacob Pan
2020-04-14 22:32                                   ` Jacob Pan
2020-04-14 22:32                                     ` Jacob Pan
2020-04-14 23:47                                     ` Tian, Kevin
2020-04-14 23:47                                       ` Tian, Kevin
2020-04-15 15:38                                       ` Jacob Pan
2020-04-15 15:38                                         ` Jacob Pan
2020-04-16  1:27                                         ` Tian, Kevin
2020-04-16  1:27                                           ` Tian, Kevin
2020-04-14  8:15                             ` Christoph Hellwig
2020-04-14  8:15                               ` Christoph Hellwig
2020-04-14  8:11                           ` Christoph Hellwig [this message]
2020-04-14  8:11                             ` Christoph Hellwig
2020-04-14 16:06                             ` Jacob Pan
2020-04-14 16:06                               ` Jacob Pan
2020-03-25 23:17 ` [PATCH v2 2/3] iommu/uapi: Use unified UAPI version Jacob Pan
2020-03-25 23:17   ` Jacob Pan
2020-03-25 23:17 ` [PATCH v2 3/3] iommu/uapi: Add helper function for size lookup Jacob Pan
2020-03-25 23:17   ` Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414081107.GA7315@infradead.org \
    --to=hch@infradead.org \
    --cc=alex.williamson@redhat.com \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=jean-philippe@linaro.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.