* [PATCH] Staging: fbtft : fbtft-bus: fixed two checkpatch errors
@ 2020-04-14 7:30 ` carlosteniswarrior
0 siblings, 0 replies; 4+ messages in thread
From: carlosteniswarrior @ 2020-04-14 7:30 UTC (permalink / raw)
To: gregkh
Cc: nsaenzjulienne, linux, devel, linux-kernel, Carlos Guerrero Álvarez
From: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
Fixed two checkpatch space prohibited before that close parenthesis errors.
Signed-off-by: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 63c65dd67b17..cdb451dd3fde 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -62,9 +62,9 @@ out: \
} \
EXPORT_SYMBOL(func);
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] Staging: fbtft : fbtft-bus: fixed two checkpatch errors
@ 2020-04-14 7:30 ` carlosteniswarrior
0 siblings, 0 replies; 4+ messages in thread
From: carlosteniswarrior @ 2020-04-14 7:30 UTC (permalink / raw)
To: gregkh; +Cc: linux, devel, Carlos Guerrero Álvarez, linux-kernel
From: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
Fixed two checkpatch space prohibited before that close parenthesis errors.
Signed-off-by: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 63c65dd67b17..cdb451dd3fde 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -62,9 +62,9 @@ out: \
} \
EXPORT_SYMBOL(func);
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
--
2.26.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: fbtft : fbtft-bus: fixed two checkpatch errors
2020-04-14 7:30 ` carlosteniswarrior
@ 2020-04-14 8:25 ` Greg KH
-1 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-04-14 8:25 UTC (permalink / raw)
To: carlosteniswarrior; +Cc: linux, devel, linux-kernel
On Tue, Apr 14, 2020 at 09:30:47AM +0200, carlosteniswarrior@gmail.com wrote:
> From: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
>
> Fixed two checkpatch space prohibited before that close parenthesis errors.
>
> Signed-off-by: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
> ---
> drivers/staging/fbtft/fbtft-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 63c65dd67b17..cdb451dd3fde 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -62,9 +62,9 @@ out: \
> } \
> EXPORT_SYMBOL(func);
>
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
> define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)
If I remember correct, the original code here is required, due to how
some older versions of gcc works.
Did you test-build this? Did it work properly?
I would just leave this alone,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: fbtft : fbtft-bus: fixed two checkpatch errors
@ 2020-04-14 8:25 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-04-14 8:25 UTC (permalink / raw)
To: carlosteniswarrior; +Cc: linux, devel, linux-kernel
On Tue, Apr 14, 2020 at 09:30:47AM +0200, carlosteniswarrior@gmail.com wrote:
> From: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
>
> Fixed two checkpatch space prohibited before that close parenthesis errors.
>
> Signed-off-by: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
> ---
> drivers/staging/fbtft/fbtft-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 63c65dd67b17..cdb451dd3fde 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -62,9 +62,9 @@ out: \
> } \
> EXPORT_SYMBOL(func);
>
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
> define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)
If I remember correct, the original code here is required, due to how
some older versions of gcc works.
Did you test-build this? Did it work properly?
I would just leave this alone,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-14 8:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 7:30 [PATCH] Staging: fbtft : fbtft-bus: fixed two checkpatch errors carlosteniswarrior
2020-04-14 7:30 ` carlosteniswarrior
2020-04-14 8:25 ` Greg KH
2020-04-14 8:25 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.