[Buildroot] [PATCH 1/1] package/libid3tag: needs host-gperf

[Buildroot] [PATCH 1/1] package/libid3tag: needs host-gperf

[Fabrice Fontaine]

Since switch to debian in commit
210ccaef5784011bc035d0ae13611cb4e76f389f, host-gperf is needed to
generate frametype.c which is empty by default otherwise build with
madplay will fail on:

configure:17243: checking for snd_pcm_open in -lasound
configure:17268: /home/giuliobenetti/autobuild/run/instance-3/output-1/host/bin/powerpc64-linux-gcc -o conftest -Wall -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=1  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  conftest.c -lasound  -L/home/giuliobenetti/autobuild/run/instance-3/output-1/host/bin/../powerpc64-buildroot-linux-gnu/sysroot/usr/lib -lasound  -L/home/giuliobenetti/autobuild/run/instance-3/output-1/host/bin/../powerpc64-buildroot-linux-gnu/sysroot/usr/lib -lid3tag  >&5
/home/giuliobenetti/autobuild/run/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/powerpc64-buildroot-linux-gnu/8.3.0/../../../../powerpc64-buildroot-linux-gnu/bin/ld: /home/giuliobenetti/autobuild/run/instance-3/output-1/host/bin/../powerpc64-buildroot-linux-gnu/sysroot/usr/lib/libid3tag.so: undefined reference to `id3_frametype_lookup'

Fixes:
 - http://autobuild.buildroot.org/results/15a8c7f6e34b26446179c04383719ea71495403e

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libid3tag/libid3tag.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libid3tag/libid3tag.mk b/package/libid3tag/libid3tag.mk
index 14a7f3f938..5d7b219bb1 100644
--- a/package/libid3tag/libid3tag.mk
+++ b/package/libid3tag/libid3tag.mk
@@ -12,7 +12,7 @@ LIBID3TAG_SITE = \
 LIBID3TAG_LICENSE = GPL-2.0+
 LIBID3TAG_LICENSE_FILES = COPYING COPYRIGHT
 LIBID3TAG_INSTALL_STAGING = YES
-LIBID3TAG_DEPENDENCIES = zlib
+LIBID3TAG_DEPENDENCIES = host-gperf zlib
 
 # debian/patches/10_utf16.dpatch
 LIBID3TAG_IGNORE_CVES += CVE-2004-2779 CVE-2017-11551
-- 
2.25.1

[Buildroot] [PATCH 1/1] package/libid3tag: needs host-gperf

[Thomas Petazzoni]

On Tue, 14 Apr 2020 12:22:59 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Since switch to debian in commit
> 210ccaef5784011bc035d0ae13611cb4e76f389f, host-gperf is needed to
> generate frametype.c which is empty by default otherwise build with

When I run "make libid3tag-patch", frametype.c is definitely not empty.
frametype.c is newer than frametype.gperf:

$ stat -c %y frametype.gperf frametype.c Makefile.am 
2004-01-23 10:41:32.000000000 +0100
2004-02-17 03:34:39.000000000 +0100
2020-04-15 22:19:56.233134509 +0200

However, the Makefile.am seems to be touched by one of the patches, and
the Makefile rule to regenerate using gperf goes like this:

$(srcdir)/frametype.c: $(srcdir)/frametype.gperf Makefile.am
        cd $(srcdir) &&  \
        gperf -tCcTonD -K id -N id3_frametype_lookup -s -3 -k '*'  \
                frametype.gperf |  \
        sed -e 's/\(struct id3_frametype\);/\1/' |  \
        sed -e '/\$$''Id: /s/\$$//g' >frametype.c

So, since the .c is older than the Makefile.am, it tries to regenerate
with gperf.

Could you double check this, and adjust the commit log as necessary ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com