* [PATCH-for-5.0] gdbstub: Introduce gdb_get_freg32() to get float32 registers
@ 2020-04-14 11:18 Philippe Mathieu-Daudé
2020-04-14 15:19 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-04-14 11:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Philippe Mathieu-Daudé, Alex Bennée, Aurelien Jarno
Since we now use a GByteArray, we can not use stfl_p() directly.
Introduce the gdb_get_freg32() helper to load a float32 register.
Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Based-on: <20200414102427.7459-1-philmd@redhat.com>
---
include/exec/gdbstub.h | 12 ++++++++++++
target/sh4/gdbstub.c | 6 ++----
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h
index b52d9933ee..52a4a936c6 100644
--- a/include/exec/gdbstub.h
+++ b/include/exec/gdbstub.h
@@ -125,6 +125,18 @@ static inline int gdb_get_reg128(GByteArray *buf, uint64_t val_hi,
return 16;
}
+static inline int gdb_get_freg32(GByteArray *array, float32 val)
+{
+ uint8_t buf[4];
+
+ QEMU_BUILD_BUG_ON(sizeof(CPU_FloatU) != sizeof(buf));
+
+ stfl_p(buf, val);
+ g_byte_array_append(array, buf, sizeof(buf));
+
+ return sizeof(buf);
+}
+
static inline int gdb_get_zeroes(GByteArray *array, size_t len)
{
for (size_t i = 0; i < len; i++) {
diff --git a/target/sh4/gdbstub.c b/target/sh4/gdbstub.c
index 49fc4a0cc6..da95205889 100644
--- a/target/sh4/gdbstub.c
+++ b/target/sh4/gdbstub.c
@@ -58,11 +58,9 @@ int superh_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)
return gdb_get_regl(mem_buf, env->fpscr);
case 25 ... 40:
if (env->fpscr & FPSCR_FR) {
- stfl_p(mem_buf, env->fregs[n - 9]);
- } else {
- stfl_p(mem_buf, env->fregs[n - 25]);
+ return gdb_get_freg32(mem_buf, env->fregs[n - 9]);
}
- return 4;
+ return gdb_get_freg32(mem_buf, env->fregs[n - 25]);
case 41:
return gdb_get_regl(mem_buf, env->ssr);
case 42:
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH-for-5.0] gdbstub: Introduce gdb_get_freg32() to get float32 registers
2020-04-14 11:18 [PATCH-for-5.0] gdbstub: Introduce gdb_get_freg32() to get float32 registers Philippe Mathieu-Daudé
@ 2020-04-14 15:19 ` Richard Henderson
2020-04-14 15:22 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2020-04-14 15:19 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Alex Bennée, Aurelien Jarno
On 4/14/20 4:18 AM, Philippe Mathieu-Daudé wrote:
> +static inline int gdb_get_freg32(GByteArray *array, float32 val)
> +{
> + uint8_t buf[4];
> +
> + QEMU_BUILD_BUG_ON(sizeof(CPU_FloatU) != sizeof(buf));
Why bother withe the BUG_ON when you could just put the sizeof(CPU_FloatU) into
the array bounds above?
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH-for-5.0] gdbstub: Introduce gdb_get_freg32() to get float32 registers
2020-04-14 15:19 ` Richard Henderson
@ 2020-04-14 15:22 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-04-14 15:22 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: Alex Bennée, Aurelien Jarno
On 4/14/20 5:19 PM, Richard Henderson wrote:
> On 4/14/20 4:18 AM, Philippe Mathieu-Daudé wrote:
>> +static inline int gdb_get_freg32(GByteArray *array, float32 val)
>> +{
>> + uint8_t buf[4];
>> +
>> + QEMU_BUILD_BUG_ON(sizeof(CPU_FloatU) != sizeof(buf));
>
> Why bother withe the BUG_ON when you could just put the sizeof(CPU_FloatU) into
> the array bounds above?
Ah good idea, thanks :)
>
>
> r~
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-14 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 11:18 [PATCH-for-5.0] gdbstub: Introduce gdb_get_freg32() to get float32 registers Philippe Mathieu-Daudé
2020-04-14 15:19 ` Richard Henderson
2020-04-14 15:22 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.