From: Krzysztof Kozlowski <krzk@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: Build regressions/improvements in v5.7-rc1
Date: Tue, 14 Apr 2020 13:19:03 +0200 [thread overview]
Message-ID: <20200414111903.GA1895@kozik-lap> (raw)
In-Reply-To: <20200414110627.GA1373@kozik-lap>
On Tue, Apr 14, 2020 at 01:06:27PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Apr 14, 2020 at 08:23:32PM +1000, Michael Ellerman wrote:
> >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable-4k.h: error: expected ')' before '!=' token: => 58:40
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable-4k.h: error: expected ')' before '==' token: => 57:37
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable-4k.h: error: expected identifier or '(' before '!' token: => 56:25
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected ')' before '!=' token: => 163:40
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected ')' before '==' token: => 333:50
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected ')' before '^' token: => 333:36
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected identifier or '(' before '!' token: => 146:27, 144:24, 160:25, 161:24, 143:25
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected identifier or '(' before 'struct': => 77:21
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/pgtable.h: error: redefinition of 'pgd_huge': => 291:19
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/pte-book3e.h: error: redefinition of 'pte_mkprivileged': => 108:26
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/pte-book3e.h: error: redefinition of 'pte_mkuser': => 115:20
> > >> + /kisskb/src/arch/powerpc/kvm/book3s_64_vio_hv.c: error: 'struct kvm_arch' has no member named 'spapr_tce_tables': => 68:46, 68:2
> > >
> > > ppc64_book3e_allmodconfig
> >
> > Caused by:
> >
> > e93a1695d7fb ("iommu: Enable compile testing for some of drivers")
> >
> > Which did:
> >
> > config SPAPR_TCE_IOMMU
> > bool "sPAPR TCE IOMMU Support"
> > - depends on PPC_POWERNV || PPC_PSERIES
> > + depends on PPC_POWERNV || PPC_PSERIES || (PPC && COMPILE_TEST)
> >
> >
> > Which is just ... not right, the dependencies on the correct platform
> > are important, otherwise the build breaks.
>
> The SPAPR_TCE_IOMMU should compile fine. The actual trouble here is
> that KVM_BOOK3S_64 selects SPAPR_TCE_IOMMU which is a user-visible
> symbol. This is generally discouraged because of exactly this error -
> select ignores any dependencies.
>
> I can revert the COMPILE_TEST for SPAPR_TCE_IOMMU or change
> select->depends in KVM_BOOK3S_64. I think the latter is the proper
> change here.
Eh, not really, it looks more complex because there are more
dependencies (the book3s_64_vio_hv is pulled by KVM Makefile if
SPAPR_TCE_IOMMU is set).
I guess the revert of this part makes most sense.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Build regressions/improvements in v5.7-rc1
Date: Tue, 14 Apr 2020 13:19:03 +0200 [thread overview]
Message-ID: <20200414111903.GA1895@kozik-lap> (raw)
In-Reply-To: <20200414110627.GA1373@kozik-lap>
On Tue, Apr 14, 2020 at 01:06:27PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Apr 14, 2020 at 08:23:32PM +1000, Michael Ellerman wrote:
> >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable-4k.h: error: expected ')' before '!=' token: => 58:40
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable-4k.h: error: expected ')' before '==' token: => 57:37
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable-4k.h: error: expected identifier or '(' before '!' token: => 56:25
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected ')' before '!=' token: => 163:40
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected ')' before '==' token: => 333:50
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected ')' before '^' token: => 333:36
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected identifier or '(' before '!' token: => 146:27, 144:24, 160:25, 161:24, 143:25
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/64/pgtable.h: error: expected identifier or '(' before 'struct': => 77:21
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/pgtable.h: error: redefinition of 'pgd_huge': => 291:19
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/pte-book3e.h: error: redefinition of 'pte_mkprivileged': => 108:26
> > >> + /kisskb/src/arch/powerpc/include/asm/nohash/pte-book3e.h: error: redefinition of 'pte_mkuser': => 115:20
> > >> + /kisskb/src/arch/powerpc/kvm/book3s_64_vio_hv.c: error: 'struct kvm_arch' has no member named 'spapr_tce_tables': => 68:46, 68:2
> > >
> > > ppc64_book3e_allmodconfig
> >
> > Caused by:
> >
> > e93a1695d7fb ("iommu: Enable compile testing for some of drivers")
> >
> > Which did:
> >
> > config SPAPR_TCE_IOMMU
> > bool "sPAPR TCE IOMMU Support"
> > - depends on PPC_POWERNV || PPC_PSERIES
> > + depends on PPC_POWERNV || PPC_PSERIES || (PPC && COMPILE_TEST)
> >
> >
> > Which is just ... not right, the dependencies on the correct platform
> > are important, otherwise the build breaks.
>
> The SPAPR_TCE_IOMMU should compile fine. The actual trouble here is
> that KVM_BOOK3S_64 selects SPAPR_TCE_IOMMU which is a user-visible
> symbol. This is generally discouraged because of exactly this error -
> select ignores any dependencies.
>
> I can revert the COMPILE_TEST for SPAPR_TCE_IOMMU or change
> select->depends in KVM_BOOK3S_64. I think the latter is the proper
> change here.
Eh, not really, it looks more complex because there are more
dependencies (the book3s_64_vio_hv is pulled by KVM Makefile if
SPAPR_TCE_IOMMU is set).
I guess the revert of this part makes most sense.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-04-14 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 9:31 Build regressions/improvements in v5.7-rc1 Geert Uytterhoeven
2020-04-13 10:34 ` Geert Uytterhoeven
2020-04-13 10:34 ` Geert Uytterhoeven
2020-04-14 10:23 ` Michael Ellerman
2020-04-14 10:23 ` Michael Ellerman
2020-04-14 11:06 ` Krzysztof Kozlowski
2020-04-14 11:06 ` Krzysztof Kozlowski
2020-04-14 11:19 ` Krzysztof Kozlowski [this message]
2020-04-14 11:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414111903.GA1895@kozik-lap \
--to=krzk@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.