From: "Michael S. Tsirkin" <mst@redhat.com> To: David Hildenbrand <david@redhat.com> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko <mhocko@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Oscar Salvador <osalvador@suse.com>, Michal Hocko <mhocko@suse.com>, Pavel Tatashin <pasha.tatashin@soleen.com>, Wei Yang <richard.weiyang@gmail.com>, Dan Williams <dan.j.williams@intel.com>, Qian Cai <cai@lca.pw> Subject: Re: [PATCH v2 07/10] mm/memory_hotplug: Introduce offline_and_remove_memory() Date: Tue, 14 Apr 2020 12:35:02 -0400 [thread overview] Message-ID: <20200414123438-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <156601a9-e919-b88f-2278-97ecee554d21@redhat.com> On Wed, Mar 11, 2020 at 06:19:04PM +0100, David Hildenbrand wrote: > On 11.03.20 18:14, David Hildenbrand wrote: > > virtio-mem wants to offline and remove a memory block once it unplugged > > all subblocks (e.g., using alloc_contig_range()). Let's provide > > an interface to do that from a driver. virtio-mem already supports to > > offline partially unplugged memory blocks. Offlining a fully unplugged > > memory block will not require to migrate any pages. All unplugged > > subblocks are PageOffline() and have a reference count of 0 - so > > offlining code will simply skip them. > > > > All we need is an interface to offline and remove the memory from kernel > > module context, where we don't have access to the memory block devices > > (esp. find_memory_block() and device_offline()) and the device hotplug > > lock. > > > > To keep things simple, allow to only work on a single memory block. > > > > Lost the ACK from Michael > > Acked-by: Michal Hocko <mhocko@suse.com> [1] > > [1] https://lkml.kernel.org/r/20200302142737.GP4380@dhcp22.suse.cz Andrew, could you pls ack merging this through the vhost tree, with the rest of the patchset? > -- > Thanks, > > David / dhildenb
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: David Hildenbrand <david@redhat.com> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko <mhocko@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Oscar Salvador <osalvador@suse.com>, Michal Hocko <mhocko@suse.com>, Pavel Tatashin <pasha.tatashin@soleen.com>, Wei Yang <richard.weiyang@gmail.com>, Dan Williams <dan.j.williams@intel.com>, Qian Cai <cai@lca.pw> Subject: [virtio-dev] Re: [PATCH v2 07/10] mm/memory_hotplug: Introduce offline_and_remove_memory() Date: Tue, 14 Apr 2020 12:35:02 -0400 [thread overview] Message-ID: <20200414123438-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <156601a9-e919-b88f-2278-97ecee554d21@redhat.com> On Wed, Mar 11, 2020 at 06:19:04PM +0100, David Hildenbrand wrote: > On 11.03.20 18:14, David Hildenbrand wrote: > > virtio-mem wants to offline and remove a memory block once it unplugged > > all subblocks (e.g., using alloc_contig_range()). Let's provide > > an interface to do that from a driver. virtio-mem already supports to > > offline partially unplugged memory blocks. Offlining a fully unplugged > > memory block will not require to migrate any pages. All unplugged > > subblocks are PageOffline() and have a reference count of 0 - so > > offlining code will simply skip them. > > > > All we need is an interface to offline and remove the memory from kernel > > module context, where we don't have access to the memory block devices > > (esp. find_memory_block() and device_offline()) and the device hotplug > > lock. > > > > To keep things simple, allow to only work on a single memory block. > > > > Lost the ACK from Michael > > Acked-by: Michal Hocko <mhocko@suse.com> [1] > > [1] https://lkml.kernel.org/r/20200302142737.GP4380@dhcp22.suse.cz Andrew, could you pls ack merging this through the vhost tree, with the rest of the patchset? > -- > Thanks, > > David / dhildenb --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2020-04-14 16:35 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-11 17:14 [PATCH v2 00/10] virtio-mem: paravirtualized memory David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-03-11 17:14 ` David Hildenbrand 2020-03-11 17:14 ` [PATCH v2 01/10] virtio-mem: Paravirtualized memory hotplug David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-04-15 5:59 ` Pankaj Gupta 2020-04-15 5:59 ` Pankaj Gupta 2020-03-11 17:14 ` [PATCH v2 02/10] virtio-mem: Allow to specify an ACPI PXM as nid David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-03-30 11:04 ` Pankaj Gupta 2020-03-30 11:04 ` Pankaj Gupta 2020-03-11 17:14 ` [PATCH v2 03/10] virtio-mem: Paravirtualized memory hotunplug part 1 David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-03-11 17:14 ` [PATCH v2 04/10] virtio-mem: Paravirtualized memory hotunplug part 2 David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-03-11 17:14 ` [PATCH v2 05/10] mm: Allow to offline unmovable PageOffline() pages via MEM_GOING_OFFLINE David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-04-14 16:34 ` Michael S. Tsirkin 2020-04-14 16:34 ` [virtio-dev] " Michael S. Tsirkin 2020-04-14 16:34 ` Michael S. Tsirkin 2020-04-15 0:32 ` Andrew Morton 2020-04-15 0:32 ` Andrew Morton 2020-03-11 17:14 ` [PATCH v2 06/10] virtio-mem: Allow to offline partially unplugged memory blocks David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-03-11 17:14 ` [PATCH v2 07/10] mm/memory_hotplug: Introduce offline_and_remove_memory() David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-03-11 17:19 ` David Hildenbrand 2020-03-11 17:19 ` [virtio-dev] " David Hildenbrand 2020-04-14 16:35 ` Michael S. Tsirkin [this message] 2020-04-14 16:35 ` Michael S. Tsirkin 2020-04-15 0:30 ` Andrew Morton 2020-04-15 7:35 ` Pankaj Gupta 2020-04-15 7:35 ` Pankaj Gupta 2020-03-11 17:14 ` [PATCH v2 08/10] virtio-mem: Offline and remove completely unplugged memory blocks David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-04-15 7:42 ` Pankaj Gupta 2020-04-15 7:42 ` Pankaj Gupta 2020-03-11 17:14 ` [PATCH v2 09/10] virtio-mem: Better retry handling David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-03-11 17:14 ` [PATCH v2 10/10] MAINTAINERS: Add myself as virtio-mem maintainer David Hildenbrand 2020-03-11 17:14 ` [virtio-dev] " David Hildenbrand 2020-03-27 16:58 ` [PATCH v2 00/10] virtio-mem: paravirtualized memory Pankaj Gupta 2020-03-27 16:58 ` Pankaj Gupta 2020-03-27 16:58 ` Pankaj Gupta 2020-03-27 17:03 ` David Hildenbrand 2020-03-27 17:03 ` [virtio-dev] " David Hildenbrand 2020-03-27 17:03 ` David Hildenbrand 2020-03-27 17:07 ` David Hildenbrand 2020-03-27 17:07 ` [virtio-dev] " David Hildenbrand 2020-03-27 17:07 ` David Hildenbrand 2020-03-29 15:41 ` Pankaj Gupta 2020-03-29 15:41 ` Pankaj Gupta 2020-03-29 15:41 ` Pankaj Gupta 2020-03-30 8:42 ` David Hildenbrand 2020-03-30 8:42 ` [virtio-dev] " David Hildenbrand 2020-03-30 8:42 ` David Hildenbrand 2020-03-29 12:42 ` Michael S. Tsirkin 2020-03-29 12:42 ` [virtio-dev] " Michael S. Tsirkin 2020-03-29 12:42 ` Michael S. Tsirkin 2020-03-30 8:16 ` David Hildenbrand 2020-03-30 8:16 ` [virtio-dev] " David Hildenbrand 2020-03-30 8:16 ` David Hildenbrand 2020-04-14 9:15 ` David Hildenbrand 2020-04-14 9:15 ` [virtio-dev] " David Hildenbrand 2020-04-14 9:15 ` David Hildenbrand 2020-04-14 16:28 ` Michael S. Tsirkin 2020-04-14 16:28 ` [virtio-dev] " Michael S. Tsirkin 2020-04-14 16:28 ` Michael S. Tsirkin 2020-04-14 18:39 ` David Hildenbrand 2020-04-14 18:39 ` [virtio-dev] " David Hildenbrand 2020-04-14 18:39 ` David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200414123438-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=cai@lca.pw \ --cc=dan.j.williams@intel.com \ --cc=david@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@kernel.org \ --cc=mhocko@suse.com \ --cc=osalvador@suse.com \ --cc=pasha.tatashin@soleen.com \ --cc=richard.weiyang@gmail.com \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.