From: David Sterba <dsterba@suse.cz>
To: Waiman Long <longman@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Joe Perches <joe@perches.com>,
Matthew Wilcox <willy@infradead.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org,
linux-pm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-ppp@vger.kernel.org, wireguard@lists.zx2c4.com,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, linux-fscrypt@vger.kernel.org,
ecryptfs@vger.kernel.org, kasan-dev@googlegroups.com,
linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org,
tipc-discussion@lists.sourceforge.net, cocci@systeme.lip6.fr,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 14:48:54 +0200 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Waiman Long <longman@redhat.com>
Cc: linux-btrfs@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
virtualization@lists.linux-foundation.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, linux-sctp@vger.kernel.org,
keyrings@vger.kernel.org, kasan-dev@googlegroups.com,
samba-technical@lists.samba.org,
linux-stm32@st-md-mailman.stormreply.com,
devel@driverdev.osuosl.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, x86@kernel.org,
James Morris <jmorris@namei.org>,
Matthew Wilcox <willy@infradead.org>,
cocci@systeme.lip6.fr, linux-wpan@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
David Rientjes <rientjes@google.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
linux-security-module@vger.kernel.org,
target-devel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, wireguard@lists.zx2c4.com,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 12:48:54 +0000 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Waiman Long <longman@redhat.com>
Cc: linux-btrfs@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
virtualization@lists.linux-foundation.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, linux-sctp@vger.kernel.org,
keyrings@vger.kernel.org, kasan-dev@googlegroups.com,
samba-technical@lists.samba.org,
linux-stm32@st-md-mailman.stormreply.com,
devel@driverdev.osuosl.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, x86@kernel.org,
James Morris <jmorris@namei.org>,
Matthew Wilcox <willy@infradead.org>,
cocci@systeme.lip6.fr, linux-wpan@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
David Rientjes <rientjes@google.com>,
linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
linux-security-module@vger.kernel.org,
target-devel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, wireguard@lists.zx2c4.com,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 14:48:54 +0200 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Waiman Long <longman@redhat.com>
Cc: linux-btrfs@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
virtualization@lists.linux-foundation.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, linux-sctp@vger.kernel.org,
keyrings@vger.kernel.org, kasan-dev@googlegroups.com,
samba-technical@lists.samba.org,
linux-stm32@st-md-mailman.stormreply.com,
devel@driverdev.osuosl.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, x86@kernel.org,
James Morris <jmorris@namei.org>,
Matthew Wilcox <willy@infradead.org>,
cocci@systeme.lip6.fr, linux-wpan@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
David Rientjes <rientjes@google.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
linux-security-module@vger.kernel.org,
target-devel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, wireguard@lists.zx2c4.com,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 14:48:54 +0200 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Waiman Long <longman@redhat.com>
Cc: linux-btrfs@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
virtualization@lists.linux-foundation.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, linux-sctp@vger.kernel.org,
keyrings@vger.kernel.org, kasan-dev@googlegroups.com,
samba-technical@lists.samba.org,
linux-stm32@st-md-mailman.stormreply.com,
devel@driverdev.osuosl.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, x86@kernel.org,
James Morris <jmorris@namei.org>,
Matthew Wilcox <willy@infradead.org>,
cocci@systeme.lip6.fr, linux-wpan@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
David Rientjes <rientjes@google.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
linux-security-module@vger.kernel.org,
target-devel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, wireguard@lists.zx2c4.com,
linux-ppp@vger.kernel.org
Subject: Re: [Cocci] [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 14:48:54 +0200 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Waiman Long <longman@redhat.com>
Cc: linux-btrfs@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
virtualization@lists.linux-foundation.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, linux-sctp@vger.kernel.org,
keyrings@vger.kernel.org, kasan-dev@googlegroups.com,
samba-technical@lists.samba.org,
linux-stm32@st-md-mailman.stormreply.com,
devel@driverdev.osuosl.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, x86@kernel.org,
James Morris <jmorris@namei.org>,
Matthew Wilcox <willy@infradead.org>,
cocci@systeme.lip6.fr, linux-wpan@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
David Rientjes <rientjes@google.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
linux-security-module@vger.kernel.org,
target-devel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, wireguard@lists.zx2c4.com,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 14:48:54 +0200 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Waiman Long <longman@redhat.com>
Cc: linux-btrfs@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
virtualization@lists.linux-foundation.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, linux-sctp@vger.kernel.org,
keyrings@vger.kernel.org, kasan-dev@googlegroups.com,
samba-technical@lists.samba.org,
linux-stm32@st-md-mailman.stormreply.com,
devel@driverdev.osuosl.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, x86@kernel.org,
James Morris <jmorris@namei.org>,
Matthew Wilcox <willy@infradead.org>,
cocci@systeme.lip6.fr, linux-wpan@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
David Rientjes <rientjes@google.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 14:48:54 +0200 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Waiman Long <longman@redhat.com>
Cc: linux-btrfs@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
virtualization@lists.linux-foundation.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, linux-sctp@vger.kernel.org,
keyrings@vger.kernel.org, kasan-dev@googlegroups.com,
samba-technical@lists.samba.org,
linux-stm32@st-md-mailman.stormreply.com,
devel@driverdev.osuosl.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, x86@kernel.org,
James Morris <jmorris@namei.org>,
Matthew Wilcox <willy@infradead.org>,
cocci@systeme.lip6.fr, linux-wpan@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
David Rientjes <rientjes@google.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
linux-security-module@vger.kernel.org,
target-devel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, wireguard@lists.zx2c4.com,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 14:48:54 +0200 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Waiman Long <longman@redhat.com>
Cc: linux-btrfs@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
virtualization@lists.linux-foundation.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, linux-sctp@vger.kernel.org,
keyrings@vger.kernel.org, kasan-dev@googlegroups.com,
samba-technical@lists.samba.org,
linux-stm32@st-md-mailman.stormreply.com,
devel@driverdev.osuosl.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, x86@kernel.org,
James Morris <jmorris@namei.org>,
Matthew Wilcox <willy@infradead.org>,
cocci@systeme.lip6.fr, linux-wpan@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
David Rientjes <rientjes@google.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
linux-security-module@vger.kernel.org,
target-devel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, wireguard@lists.zx2c4.com,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 14:48:54 +0200 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 14 Apr 2020 14:48:54 +0200 [thread overview]
Message-ID: <20200414124854.GQ5920@twin.jikos.cz> (raw)
In-Reply-To: <20200413211550.8307-2-longman@redhat.com>
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote:
> fs/btrfs/ioctl.c | 2 +-
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 40b729dce91c..eab3f8510426 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -2691,7 +2691,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
> btrfs_put_root(root);
> out_free:
> btrfs_free_path(path);
> - kzfree(subvol_info);
> + kfree_sensitive(subvol_info);
This is not in a sensitive context so please switch it to plain kfree.
With that you have my acked-by. Thanks.
next prev parent reply other threads:[~2020-04-14 12:50 UTC|newest]
Thread overview: 219+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:15 [PATCH 0/2] mm, treewide: Rename kzfree() to kfree_sensitive() Waiman Long
2020-04-13 21:15 ` [Intel-wired-lan] " Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` [Cocci] " Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` [PATCH 1/2] " Waiman Long
2020-04-13 21:15 ` [Intel-wired-lan] " Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` [Cocci] " Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-14 0:29 ` David Rientjes
2020-04-14 0:29 ` [Intel-wired-lan] " David Rientjes
2020-04-14 0:29 ` David Rientjes
2020-04-14 0:29 ` David Rientjes
2020-04-14 0:29 ` David Rientjes
2020-04-14 0:29 ` David Rientjes
2020-04-14 0:29 ` [Cocci] " David Rientjes
2020-04-14 0:29 ` David Rientjes
2020-04-14 0:29 ` David Rientjes
2020-04-14 0:29 ` David Rientjes
2020-04-14 0:29 ` David Rientjes
2020-04-14 8:32 ` Jason A. Donenfeld
2020-04-14 8:32 ` [Intel-wired-lan] " Jason A. Donenfeld
2020-04-14 8:32 ` Jason A. Donenfeld
2020-04-14 8:32 ` Jason A. Donenfeld
2020-04-14 8:32 ` Jason A. Donenfeld
2020-04-14 8:32 ` Jason A. Donenfeld
2020-04-14 8:32 ` [Cocci] " Jason A. Donenfeld
2020-04-14 8:32 ` Jason A. Donenfeld
2020-04-14 8:32 ` Jason A. Donenfeld
2020-04-14 8:32 ` Jason A. Donenfeld
2020-04-14 9:01 ` Michal Hocko
2020-04-14 9:01 ` [Intel-wired-lan] " Michal Hocko
2020-04-14 9:01 ` Michal Hocko
2020-04-14 9:01 ` Michal Hocko
2020-04-14 9:01 ` Michal Hocko
2020-04-14 9:01 ` Michal Hocko
2020-04-14 9:01 ` [Cocci] " Michal Hocko
2020-04-14 9:01 ` Michal Hocko
2020-04-14 9:01 ` Michal Hocko
2020-04-14 9:01 ` Michal Hocko
2020-04-14 12:48 ` David Sterba [this message]
2020-04-14 12:48 ` [Intel-wired-lan] " David Sterba
2020-04-14 12:48 ` David Sterba
2020-04-14 12:48 ` David Sterba
2020-04-14 12:48 ` David Sterba
2020-04-14 12:48 ` David Sterba
2020-04-14 12:48 ` [Cocci] " David Sterba
2020-04-14 12:48 ` David Sterba
2020-04-14 12:48 ` David Sterba
2020-04-14 12:48 ` David Sterba
2020-04-14 18:26 ` Waiman Long
2020-04-14 18:26 ` [Intel-wired-lan] " Waiman Long
2020-04-14 18:26 ` Waiman Long
2020-04-14 18:26 ` Waiman Long
2020-04-14 18:26 ` Waiman Long
2020-04-14 18:26 ` Waiman Long
2020-04-14 18:26 ` [Cocci] " Waiman Long
2020-04-14 18:26 ` Waiman Long
2020-04-14 18:26 ` Waiman Long
2020-04-14 18:26 ` Waiman Long
2020-04-15 5:01 ` Johannes Weiner
2020-04-15 5:01 ` [Intel-wired-lan] " Johannes Weiner
2020-04-15 5:01 ` Johannes Weiner
2020-04-15 5:01 ` Johannes Weiner
2020-04-15 5:01 ` Johannes Weiner
2020-04-15 5:01 ` Johannes Weiner
2020-04-15 5:01 ` [Cocci] " Johannes Weiner
2020-04-15 5:01 ` Johannes Weiner
2020-04-15 5:01 ` Johannes Weiner
2020-04-15 5:01 ` Johannes Weiner
2020-06-15 18:07 ` Dan Carpenter
2020-06-15 18:07 ` [Intel-wired-lan] " Dan Carpenter
2020-06-15 18:07 ` Dan Carpenter
2020-06-15 18:07 ` Dan Carpenter
2020-06-15 18:07 ` Dan Carpenter
2020-06-15 18:07 ` Dan Carpenter
2020-06-15 18:07 ` [Cocci] " Dan Carpenter
2020-06-15 18:07 ` Dan Carpenter
2020-06-15 18:07 ` Dan Carpenter
2020-06-15 18:07 ` Dan Carpenter
2020-06-15 18:39 ` Waiman Long
2020-06-15 18:39 ` [Intel-wired-lan] " Waiman Long
2020-06-15 18:39 ` Waiman Long
2020-06-15 18:39 ` Waiman Long
2020-06-15 18:39 ` Waiman Long
2020-06-15 18:39 ` Waiman Long
2020-06-15 18:39 ` [Cocci] " Waiman Long
2020-06-15 18:39 ` Waiman Long
2020-06-15 18:39 ` Waiman Long
2020-06-15 18:39 ` Waiman Long
2020-04-13 21:15 ` [PATCH 2/2] crypto: Remove unnecessary memzero_explicit() Waiman Long
2020-04-13 21:15 ` [Intel-wired-lan] " Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` [Cocci] " Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:15 ` Waiman Long
2020-04-13 21:31 ` Joe Perches
2020-04-13 21:31 ` [Intel-wired-lan] " Joe Perches
2020-04-13 21:31 ` Joe Perches
2020-04-13 21:31 ` Joe Perches
2020-04-13 21:31 ` Joe Perches
2020-04-13 21:31 ` Joe Perches
2020-04-13 21:31 ` [Cocci] " Joe Perches
2020-04-13 21:31 ` Joe Perches
2020-04-13 21:31 ` Joe Perches
2020-04-13 21:31 ` Joe Perches
2020-04-13 21:31 ` Joe Perches
2020-04-13 21:52 ` Waiman Long
2020-04-13 21:52 ` [Intel-wired-lan] " Waiman Long
2020-04-13 21:52 ` Waiman Long
2020-04-13 21:52 ` Waiman Long
2020-04-13 21:52 ` Waiman Long
2020-04-13 21:52 ` Waiman Long
2020-04-13 21:52 ` Waiman Long
2020-04-13 21:52 ` [Cocci] " Waiman Long
2020-04-13 21:52 ` Waiman Long
2020-04-13 21:52 ` Waiman Long
2020-04-13 21:52 ` Waiman Long
2020-04-13 23:07 ` kbuild test robot
2020-04-13 23:50 ` Waiman Long
2020-04-14 0:01 ` kbuild test robot
2020-04-13 22:28 ` [PATCH v2 " Waiman Long
2020-04-13 22:28 ` [Intel-wired-lan] " Waiman Long
2020-04-13 22:28 ` Waiman Long
2020-04-13 22:28 ` Waiman Long
2020-04-13 22:28 ` Waiman Long
2020-04-13 22:28 ` Waiman Long
2020-04-13 22:28 ` [Cocci] " Waiman Long
2020-04-13 22:28 ` Waiman Long
2020-04-13 22:28 ` Waiman Long
2020-04-13 22:28 ` Waiman Long
2020-04-14 6:08 ` Christophe Leroy
2020-04-14 6:08 ` [Intel-wired-lan] " Christophe Leroy
2020-04-14 6:08 ` Christophe Leroy
2020-04-14 6:08 ` Christophe Leroy
2020-04-14 6:08 ` Christophe Leroy
2020-04-14 6:08 ` Christophe Leroy
2020-04-14 6:08 ` [Cocci] " Christophe Leroy
2020-04-14 6:08 ` Christophe Leroy
2020-04-14 6:08 ` Christophe Leroy
2020-04-14 6:08 ` Christophe Leroy
2020-04-14 16:24 ` Waiman Long
2020-04-14 16:24 ` [Intel-wired-lan] " Waiman Long
2020-04-14 16:24 ` Waiman Long
2020-04-14 16:24 ` Waiman Long
2020-04-14 16:24 ` Waiman Long
2020-04-14 16:24 ` Waiman Long
2020-04-14 16:24 ` [Cocci] " Waiman Long
2020-04-14 16:24 ` Waiman Long
2020-04-14 16:24 ` Waiman Long
2020-04-14 16:24 ` Waiman Long
2020-04-14 19:16 ` Michal Suchánek
2020-04-14 19:16 ` [Intel-wired-lan] " Michal =?unknown-8bit?q?Such=C3=A1nek?=
2020-04-14 19:16 ` Michal Suchánek
2020-04-14 19:16 ` Michal Suchánek
2020-04-14 19:16 ` Michal Suchánek
2020-04-14 19:16 ` Michal Suchánek
2020-04-14 19:16 ` [Cocci] " Michal Suchánek
2020-04-14 19:16 ` Michal Suchánek
2020-04-14 19:16 ` Michal Suchánek
2020-04-14 19:16 ` Michal Suchánek
2020-04-14 19:16 ` Michal Suchánek
2020-04-14 19:37 ` Waiman Long
2020-04-14 19:37 ` [Intel-wired-lan] " Waiman Long
2020-04-14 19:37 ` Waiman Long
2020-04-14 19:37 ` Waiman Long
2020-04-14 19:37 ` Waiman Long
2020-04-14 19:37 ` Waiman Long
2020-04-14 19:37 ` [Cocci] " Waiman Long
2020-04-14 19:37 ` Waiman Long
2020-04-14 19:37 ` Waiman Long
2020-04-14 19:37 ` Waiman Long
2020-04-14 19:37 ` Waiman Long
2020-04-14 19:44 ` Joe Perches
2020-04-14 19:44 ` [Intel-wired-lan] " Joe Perches
2020-04-14 19:44 ` Joe Perches
2020-04-14 19:44 ` Joe Perches
2020-04-14 19:44 ` Joe Perches
2020-04-14 19:44 ` Joe Perches
2020-04-14 19:44 ` [Cocci] " Joe Perches
2020-04-14 19:44 ` Joe Perches
2020-04-14 19:44 ` Joe Perches
2020-04-14 19:44 ` Joe Perches
2020-04-14 19:44 ` Joe Perches
2020-04-14 13:06 ` [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() David Howells
2020-04-14 13:06 ` [Intel-wired-lan] " David Howells
2020-04-14 13:06 ` David Howells
2020-04-14 13:06 ` David Howells
2020-04-14 13:06 ` David Howells
2020-04-14 13:06 ` David Howells
2020-04-14 13:06 ` [Cocci] " David Howells
2020-04-14 13:06 ` David Howells
2020-04-14 13:06 ` David Howells
2020-04-14 13:06 ` David Howells
2020-04-14 19:29 ` [PATCH v2 3/3] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info() Waiman Long
2020-04-14 19:29 ` Waiman Long
2020-04-14 20:02 ` [PATCH v3 2/3] crypto: Remove unnecessary memzero_explicit() Waiman Long
2020-04-14 20:02 ` Waiman Long
2020-04-14 20:02 ` Waiman Long
2020-04-14 20:02 ` Waiman Long
2020-04-16 9:06 ` Corentin Labbe
2020-04-16 9:06 ` Corentin Labbe
2020-04-16 9:06 ` Corentin Labbe
2020-04-16 9:06 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414124854.GQ5920@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cocci@systeme.lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=ecryptfs@vger.kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kasan-dev@googlegroups.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=longman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
--cc=samba-technical@lists.samba.org \
--cc=serge@hallyn.com \
--cc=target-devel@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=wireguard@lists.zx2c4.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.