* [PATCH] x86/umip: make umip_insns static
@ 2020-04-13 8:22 Jason Yan
2020-04-15 3:40 ` Ricardo Neri
2020-04-15 9:20 ` [tip: x86/urgent] x86/umip: Make " tip-bot2 for Jason Yan
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-13 8:22 UTC (permalink / raw)
To: tglx, mingo, bp, hpa, x86, ebiederm, ricardo.neri-calderon,
yanaijie, Babu.Moger, bshanks, wangkefeng.wang, linux-kernel
Cc: Hulk Robot
Fix the following sparse warning:
arch/x86/kernel/umip.c:84:12: warning: symbol 'umip_insns' was not
declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
arch/x86/kernel/umip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/umip.c b/arch/x86/kernel/umip.c
index 4d732a444711..8d5cbe1bbb3b 100644
--- a/arch/x86/kernel/umip.c
+++ b/arch/x86/kernel/umip.c
@@ -81,7 +81,7 @@
#define UMIP_INST_SLDT 3 /* 0F 00 /0 */
#define UMIP_INST_STR 4 /* 0F 00 /1 */
-const char * const umip_insns[5] = {
+static const char * const umip_insns[5] = {
[UMIP_INST_SGDT] = "SGDT",
[UMIP_INST_SIDT] = "SIDT",
[UMIP_INST_SMSW] = "SMSW",
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/umip: make umip_insns static
2020-04-13 8:22 [PATCH] x86/umip: make umip_insns static Jason Yan
@ 2020-04-15 3:40 ` Ricardo Neri
2020-04-15 9:20 ` [tip: x86/urgent] x86/umip: Make " tip-bot2 for Jason Yan
1 sibling, 0 replies; 3+ messages in thread
From: Ricardo Neri @ 2020-04-15 3:40 UTC (permalink / raw)
To: Jason Yan
Cc: tglx, mingo, bp, hpa, x86, ebiederm, Babu.Moger, bshanks,
wangkefeng.wang, linux-kernel, Hulk Robot
On Mon, Apr 13, 2020 at 04:22:13PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> arch/x86/kernel/umip.c:84:12: warning: symbol 'umip_insns' was not
> declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
FWIW. This looks good to me.
Acked-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Thanks and BR,
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: x86/urgent] x86/umip: Make umip_insns static
2020-04-13 8:22 [PATCH] x86/umip: make umip_insns static Jason Yan
2020-04-15 3:40 ` Ricardo Neri
@ 2020-04-15 9:20 ` tip-bot2 for Jason Yan
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Jason Yan @ 2020-04-15 9:20 UTC (permalink / raw)
To: linux-tip-commits
Cc: Hulk Robot, Jason Yan, Thomas Gleixner, Ricardo Neri, x86, LKML
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: b0e387c3ec0170b429f15c53b6183fe1c691403b
Gitweb: https://git.kernel.org/tip/b0e387c3ec0170b429f15c53b6183fe1c691403b
Author: Jason Yan <yanaijie@huawei.com>
AuthorDate: Mon, 13 Apr 2020 16:22:13 +08:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 15 Apr 2020 11:13:12 +02:00
x86/umip: Make umip_insns static
Fix the following sparse warning:
arch/x86/kernel/umip.c:84:12: warning: symbol 'umip_insns' was not declared.
Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Link: https://lkml.kernel.org/r/20200413082213.22934-1-yanaijie@huawei.com
---
arch/x86/kernel/umip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/umip.c b/arch/x86/kernel/umip.c
index 4d732a4..8d5cbe1 100644
--- a/arch/x86/kernel/umip.c
+++ b/arch/x86/kernel/umip.c
@@ -81,7 +81,7 @@
#define UMIP_INST_SLDT 3 /* 0F 00 /0 */
#define UMIP_INST_STR 4 /* 0F 00 /1 */
-const char * const umip_insns[5] = {
+static const char * const umip_insns[5] = {
[UMIP_INST_SGDT] = "SGDT",
[UMIP_INST_SIDT] = "SIDT",
[UMIP_INST_SMSW] = "SMSW",
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-15 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 8:22 [PATCH] x86/umip: make umip_insns static Jason Yan
2020-04-15 3:40 ` Ricardo Neri
2020-04-15 9:20 ` [tip: x86/urgent] x86/umip: Make " tip-bot2 for Jason Yan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.