All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY
@ 2020-04-15  6:07 Bjorn Andersson
  2020-04-20 21:49 ` Rob Herring
  0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2020-04-15  6:07 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I, Rob Herring
  Cc: linux-arm-msm, linux-kernel, devicetree

The SM8250 UFS PHY can run off the same initialization sequence as
SM8150, but add the compatible to allow future changes.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +++++
 drivers/phy/qualcomm/phy-qcom-qmp.c                    | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
index 54d6f8d43508..5ff9e7ab6001 100644
--- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
+++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
@@ -19,6 +19,7 @@ Required properties:
 	       "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845,
 	       "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845,
 	       "qcom,sm8150-qmp-ufs-phy" for UFS QMP phy on sm8150.
+	       "qcom,sm8250-qmp-ufs-phy" for UFS QMP phy on sm8250.
 
 - reg:
   - index 0: address and length of register set for PHY's common
@@ -69,6 +70,8 @@ Required properties:
 			"ref", "ref_aux".
 		For "qcom,sm8150-qmp-ufs-phy" must contain:
 			"ref", "ref_aux".
+		For "qcom,sm8250-qmp-ufs-phy" must contain:
+			"ref", "ref_aux".
 
  - resets: a list of phandles and reset controller specifier pairs,
 	   one for each entry in reset-names.
@@ -103,6 +106,8 @@ Required properties:
 			"ufsphy".
 		For "qcom,sm8150-qmp-ufs-phy": must contain:
 			"ufsphy".
+		For "qcom,sm8250-qmp-ufs-phy": must contain:
+			"ufsphy".
 
  - vdda-phy-supply: Phandle to a regulator supply to PHY core block.
  - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block.
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index c190406246ab..50cbcdce3680 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -2536,6 +2536,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
 	}, {
 		.compatible = "qcom,sm8150-qmp-ufs-phy",
 		.data = &sm8150_ufsphy_cfg,
+	}, {
+		.compatible = "qcom,sm8250-qmp-ufs-phy",
+		.data = &sm8150_ufsphy_cfg,
 	},
 	{ },
 };
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY
  2020-04-15  6:07 [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY Bjorn Andersson
@ 2020-04-20 21:49 ` Rob Herring
  2020-04-21  6:32   ` Vinod Koul
  2020-04-28  5:03   ` Vinod Koul
  0 siblings, 2 replies; 4+ messages in thread
From: Rob Herring @ 2020-04-20 21:49 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I,
	linux-arm-msm, linux-kernel, devicetree

On Tue, 14 Apr 2020 23:07:45 -0700, Bjorn Andersson wrote:
> The SM8250 UFS PHY can run off the same initialization sequence as
> SM8150, but add the compatible to allow future changes.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +++++
>  drivers/phy/qualcomm/phy-qcom-qmp.c                    | 3 +++
>  2 files changed, 8 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY
  2020-04-20 21:49 ` Rob Herring
@ 2020-04-21  6:32   ` Vinod Koul
  2020-04-28  5:03   ` Vinod Koul
  1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-04-21  6:32 UTC (permalink / raw)
  To: Rob Herring
  Cc: Bjorn Andersson, Andy Gross, Kishon Vijay Abraham I,
	linux-arm-msm, linux-kernel, devicetree

On 20-04-20, 16:49, Rob Herring wrote:
> On Tue, 14 Apr 2020 23:07:45 -0700, Bjorn Andersson wrote:
> > The SM8250 UFS PHY can run off the same initialization sequence as
> > SM8150, but add the compatible to allow future changes.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +++++
> >  drivers/phy/qualcomm/phy-qcom-qmp.c                    | 3 +++
> >  2 files changed, 8 insertions(+)
> > 
> 
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Vinod Koul <vkoul@kernel.org>
Tested-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY
  2020-04-20 21:49 ` Rob Herring
  2020-04-21  6:32   ` Vinod Koul
@ 2020-04-28  5:03   ` Vinod Koul
  1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-04-28  5:03 UTC (permalink / raw)
  To: Rob Herring
  Cc: Bjorn Andersson, Andy Gross, Kishon Vijay Abraham I,
	linux-arm-msm, linux-kernel, devicetree

On 20-04-20, 16:49, Rob Herring wrote:
> On Tue, 14 Apr 2020 23:07:45 -0700, Bjorn Andersson wrote:
> > The SM8250 UFS PHY can run off the same initialization sequence as
> > SM8150, but add the compatible to allow future changes.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +++++
> >  drivers/phy/qualcomm/phy-qcom-qmp.c                    | 3 +++
> >  2 files changed, 8 insertions(+)
> > 
> 
> Acked-by: Rob Herring <robh@kernel.org>

Applied, thanks


-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-28  5:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15  6:07 [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY Bjorn Andersson
2020-04-20 21:49 ` Rob Herring
2020-04-21  6:32   ` Vinod Koul
2020-04-28  5:03   ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.