[stable:linux-4.4.y 9934/9999] drivers/scsi/NCR5380.c:951:124: warning: for loop has empty body

[stable:linux-4.4.y 9934/9999] drivers/scsi/NCR5380.c:951:124: warning: for loop has empty body

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 6035 bytes --]

Hi Dirk,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.4.y
head:   10d9c6f92756c1b9049e409cd5e7faed40f95294
commit: ce513359d8507123e63f34b56e67ad558074be22 [9934/9999] scripts/dtc: Remove redundant YYLOC global declaration
config: x86_64-randconfig-c003-20200414 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project f3da6b7ab5698bb0b9bd208972115dbcbbc59f27)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout ce513359d8507123e63f34b56e67ad558074be22
        # save the attached .config to linux build tree
        COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/scsi/dmx3191d.c:52:
>> drivers/scsi/NCR5380.c:951:124: warning: for loop has empty body [-Wempty-body]
                   for (tmp = (struct scsi_cmnd *) hostdata->issue_queue; tmp->host_scribble; tmp = (struct scsi_cmnd *) tmp->host_scribble);
                                                                                                                                            ^
   drivers/scsi/NCR5380.c:951:124: note: put the semicolon on a separate line to silence this warning
   1 warning generated.
--
>> drivers/scsi/mpt3sas/mpt3sas_scsih.c:2393:20: warning: address of array 'sas_device->connector_name' will always evaluate to 'true' [-Wpointer-bool-conversion]
                           if (sas_device->connector_name)
                           ~~  ~~~~~~~~~~~~^~~~~~~~~~~~~~
   drivers/scsi/mpt3sas/mpt3sas_scsih.c:3128:19: warning: address of array 'sas_device->connector_name' will always evaluate to 'true' [-Wpointer-bool-conversion]
                   if (sas_device->connector_name)
                   ~~  ~~~~~~~~~~~~^~~~~~~~~~~~~~
   2 warnings generated.
--
>> drivers/net/ethernet/via/via-velocity.c:1731:14: warning: address of array 'tdinfo->skb_dma' will always evaluate to 'true' [-Wpointer-bool-conversion]
           if (tdinfo->skb_dma) {
           ~~  ~~~~~~~~^~~~~~~
   1 warning generated.
--
>> arch/x86/kernel/cpu/perf_event_amd_iommu.c:36:30: warning: tentative definition of variable with internal linkage has incomplete non-array type 'struct perf_amd_iommu' [-Wtentative-definition-incomplete-type]
   static struct perf_amd_iommu __perf_iommu;
                                ^
   arch/x86/kernel/cpu/perf_event_amd_iommu.c:36:15: note: forward declaration of 'struct perf_amd_iommu'
   static struct perf_amd_iommu __perf_iommu;
                 ^
   1 warning generated.

vim +951 drivers/scsi/NCR5380.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  929  
^1da177e4c3f41 Linus Torvalds 2005-04-16  930  	/* 
^1da177e4c3f41 Linus Torvalds 2005-04-16  931  	 * We use the host_scribble field as a pointer to the next command  
^1da177e4c3f41 Linus Torvalds 2005-04-16  932  	 * in a queue 
^1da177e4c3f41 Linus Torvalds 2005-04-16  933  	 */
^1da177e4c3f41 Linus Torvalds 2005-04-16  934  
^1da177e4c3f41 Linus Torvalds 2005-04-16  935  	cmd->host_scribble = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16  936  	cmd->scsi_done = done;
^1da177e4c3f41 Linus Torvalds 2005-04-16  937  	cmd->result = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  938  
^1da177e4c3f41 Linus Torvalds 2005-04-16  939  	/* 
^1da177e4c3f41 Linus Torvalds 2005-04-16  940  	 * Insert the cmd into the issue queue. Note that REQUEST SENSE 
^1da177e4c3f41 Linus Torvalds 2005-04-16  941  	 * commands are added to the head of the queue since any command will
^1da177e4c3f41 Linus Torvalds 2005-04-16  942  	 * clear the contingent allegiance condition that exists and the 
^1da177e4c3f41 Linus Torvalds 2005-04-16  943  	 * sense data is only guaranteed to be valid while the condition exists.
^1da177e4c3f41 Linus Torvalds 2005-04-16  944  	 */
^1da177e4c3f41 Linus Torvalds 2005-04-16  945  
^1da177e4c3f41 Linus Torvalds 2005-04-16  946  	if (!(hostdata->issue_queue) || (cmd->cmnd[0] == REQUEST_SENSE)) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  947  		LIST(cmd, hostdata->issue_queue);
^1da177e4c3f41 Linus Torvalds 2005-04-16  948  		cmd->host_scribble = (unsigned char *) hostdata->issue_queue;
^1da177e4c3f41 Linus Torvalds 2005-04-16  949  		hostdata->issue_queue = cmd;
^1da177e4c3f41 Linus Torvalds 2005-04-16  950  	} else {
710ddd0d50d22b Finn Thain     2014-11-12 @951  		for (tmp = (struct scsi_cmnd *) hostdata->issue_queue; tmp->host_scribble; tmp = (struct scsi_cmnd *) tmp->host_scribble);
^1da177e4c3f41 Linus Torvalds 2005-04-16  952  		LIST(cmd, tmp);
^1da177e4c3f41 Linus Torvalds 2005-04-16  953  		tmp->host_scribble = (unsigned char *) cmd;
^1da177e4c3f41 Linus Torvalds 2005-04-16  954  	}
52a6a1cbd9615d Finn Thain     2014-03-18  955  	dprintk(NDEBUG_QUEUES, "scsi%d : command added to %s of queue\n", instance->host_no, (cmd->cmnd[0] == REQUEST_SENSE) ? "head" : "tail");
^1da177e4c3f41 Linus Torvalds 2005-04-16  956  
^1da177e4c3f41 Linus Torvalds 2005-04-16  957  	/* Run the coroutine if it isn't already running. */
^1da177e4c3f41 Linus Torvalds 2005-04-16  958  	/* Kick off command processing */
c4028958b6ecad David Howells  2006-11-22  959  	schedule_delayed_work(&hostdata->coroutine, 0);
^1da177e4c3f41 Linus Torvalds 2005-04-16  960  	return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  961  }
^1da177e4c3f41 Linus Torvalds 2005-04-16  962  

:::::: The code at line 951 was first introduced by commit
:::::: 710ddd0d50d22b40e3b644ea35966489ad178978 ncr5380: Drop legacy scsi.h include

:::::: TO: Finn Thain <fthain@telegraphics.com.au>
:::::: CC: Christoph Hellwig <hch@lst.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26013 bytes --]